All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xen.org
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH] xen: fix initialization of wallclock time for PVHVM on migration
Date: Tue, 11 Jun 2013 12:46:17 +0200	[thread overview]
Message-ID: <1370947577-5965-1-git-send-email-roger.pau@citrix.com> (raw)

The initial values of the wallclock time in the shared info page are
set for PVHVM guests when the hypercall page is initialized, since the
hypercall page is not reinitialized on resume, the hypervisor
wallclock time is not properly set on resume.

Fix it by forcing an update of the wallclock values when the shared
info page is mapped.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
---
Since this is a bug fix, I think it is suitable for inclusion in the
4.3 release, and backported to older releases.
---
 xen/arch/x86/mm.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 5123860..1591528 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -4629,6 +4629,14 @@ static int xenmem_add_to_physmap_once(
         put_gfn(d, gfn);
     domain_unlock(d);
 
+    if ( !rc && xatp->space == XENMAPSPACE_shared_info )
+        /*
+         * Force an update of the wallclock values in the shared info
+         * page, since in the PVHVM resume path the hypercall page is
+         * not reinitialized.
+         */
+        update_domain_wallclock_time(d);
+
     return rc;
 }
 
-- 
1.7.7.5 (Apple Git-26)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

             reply	other threads:[~2013-06-11 10:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-11 10:46 Roger Pau Monne [this message]
2013-06-11 11:59 ` [PATCH] xen: fix initialization of wallclock time for PVHVM on migration Jan Beulich
2013-06-11 12:01   ` George Dunlap
2013-06-11 12:12     ` Jan Beulich
2013-06-11 13:59       ` Ian Campbell
2013-06-11 14:04         ` Jan Beulich
2013-06-12 13:36           ` Egger, Christoph
2013-06-11 12:17   ` Roger Pau Monné
2013-06-11 13:15     ` konrad wilk
2013-06-11 14:02     ` Jan Beulich
2013-06-11 13:38   ` Roger Pau Monné
2013-06-11 14:16     ` Jan Beulich
2013-06-11 14:41       ` Konrad Rzeszutek Wilk
2013-06-11 15:05       ` Keir Fraser
2013-06-11 15:45         ` Keir Fraser
2013-06-11 15:59           ` Roger Pau Monné
2013-06-11 16:12             ` Keir Fraser
2013-06-11 16:14               ` Roger Pau Monné
2013-06-11 15:59           ` Jan Beulich
2013-06-12 13:50           ` Konrad Rzeszutek Wilk
2013-06-12 13:55             ` Roger Pau Monné
2013-06-11 15:50     ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370947577-5965-1-git-send-email-roger.pau@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.