From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 745C3C4320E for ; Sat, 31 Jul 2021 07:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 539E660F35 for ; Sat, 31 Jul 2021 07:29:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230439AbhGaH3r (ORCPT ); Sat, 31 Jul 2021 03:29:47 -0400 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]:41056 "EHLO smtp-relay-canonical-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbhGaH3q (ORCPT ); Sat, 31 Jul 2021 03:29:46 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id C59743F243 for ; Sat, 31 Jul 2021 07:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627716579; bh=7szpzek0sYJQJU9q3jPOrpIZQhKhL2Waoumc2yNvU78=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=gK78iDW31WXNAKEY4Te/5C3LOWAvuswD7dRowoPNOqIa7S7gKSrL/h4sAjkLqOmO4 690GdyEGZKfaksZdIxDQ1bhvZLp0inZ7qBzjfR/FNodDiojeXoiH3dvv+/uho0iY4K uL2Gwcr5PesTeHH0lexDebXVRP8SM9tRaBgBTQsWaGyKQUdwLU95OZ3GPzDLWLyOA5 mQAi3umgoOZLfoCSHXlqlNfzh/nrx6B9srMGjZ47Oho4xhDRjxlI1Lcz9akh46w8r6 sTrfPNVbyRMVPs4y2HaRSeOBvxQwVyITfQOvCW8h4iQqVXJYMnjtMHOR/WbbXat/Bq qcoorMFnGj/fg== Received: by mail-ed1-f70.google.com with SMTP id s8-20020a0564020148b02903948b71f25cso5767134edu.4 for ; Sat, 31 Jul 2021 00:29:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7szpzek0sYJQJU9q3jPOrpIZQhKhL2Waoumc2yNvU78=; b=bmmFBPzNhSh6tZJK7XYlvrsC5Imwy6P+p7OigmhtKyV501ItLIgYQkVyJDAL3pLsjC Fd3n0T5RO2a8qhHaRvqA7njqgHUABU6AdKtF2tNm1KZxon5YlH8a7g9inrRFUbhnAAfm VZ3vN7zxF75ah5Wa/XUXqAp9URewZrFfJfcl9JCDCKAElqmG9VI7rtjissMsrVWjrPuE 3KEmfWlOb49zVo5IzfnaIodl6ld1jsjKN1fee7rEfpWq9RLj9DVjfJdsMdX4zb6nXPWC N9P7p+PRBD9zTdcYLpMXo4kOGoK/2LexMNoN6iVuZ1HxiF1akTGFikV99bpVReyXXIej CbKQ== X-Gm-Message-State: AOAM532RyKMkWmpWiLih5GXKf8svrBG/j7bJJlT0n/kV1U6t9HqGO4kk WUWQPQ/1mgMPpIkz+5A4u5oHR+PvfFR3UI4cHaWLVA4vIxNb6GzIYToePmkieZihyHN+e042wdU +fboKwaHuKQEZIcQjKFfr1GWXs9JRqkF5wfphSSM= X-Received: by 2002:a05:6402:299:: with SMTP id l25mr7768578edv.283.1627716579287; Sat, 31 Jul 2021 00:29:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUxBOyxyGNdZMeniqKHPWuWGs2AKaZZj7ShbIHSxUlg3RJCNhhDtExvwhxpbohpRLzf5RItQ== X-Received: by 2002:a05:6402:299:: with SMTP id l25mr7768575edv.283.1627716579171; Sat, 31 Jul 2021 00:29:39 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id v13sm1361312ejh.62.2021.07.31.00.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jul 2021 00:29:38 -0700 (PDT) To: Sam Protsenko Cc: Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux Samsung SOC , "open list:SERIAL DRIVERS" References: <20210730144922.29111-1-semen.protsenko@linaro.org> <5e35b0a7-13aa-3c62-ca49-14af2fcb2a08@canonical.com> From: Krzysztof Kozlowski Subject: Re: [PATCH 00/12] Add minimal support for Exynos850 SoC Message-ID: <13f166bb-7103-25d5-35a6-8ec53a1f1817@canonical.com> Date: Sat, 31 Jul 2021 09:29:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 30/07/2021 21:02, Sam Protsenko wrote: > Hi Krzysztof, > > On Fri, 30 Jul 2021 at 20:21, Krzysztof Kozlowski > wrote: >> >> On 30/07/2021 17:18, Krzysztof Kozlowski wrote: >>> On 30/07/2021 16:49, Sam Protsenko wrote: >>>> This patch series adds initial platform support for Samsung Exynos850 >>>> SoC [1]. With this patchset it's possible to run the kernel with BusyBox >>>> rootfs as a RAM disk. More advanced platform support (like MMC driver >>>> additions) will be added later. The idea is to keep the first submission >>>> minimal to ease the review, and then build up on top of that. >>>> >>>> [1] https://www.samsung.com/semiconductor/minisite/exynos/products/mobileprocessor/exynos-850/ >>>> >>> >>> Great work! >>> > > Thanks, Krzysztof! And thank you for reviewing the whole series. > >>> What's the SoC revision number (should be accessible via >>> /sys/bus/soc/devices/soc0/)? Recent wrap in numbering of Exynos chips >>> might bring confusion... > > # cat /sys/devices/soc0/revision > 0 soc_id but you're right it won't be set for unknown SoCs. You need to extend drivers/soc/samsung/exynos-chipid.c to parse new values (E3830000 for product ID) and maybe new register offsets (previous offset is 0x0, for 3830 is 0x10 I think). Also revision mask might change. >> Judging by vendor's sources it is quite confusing. It looks mostly like >> Exynos3830 but in few other cases it uses Exynos9 compatibles (Exynos9, >> Exynos9820). Only in few places there is Exynos850. Marketing department >> made it so confusing... The revision embedded in SoC would be very >> interesting. >> > > As I understand, this SoC is called Exynos850 everywhere now. > Exynos3830 is its old name, not used anymore. As you noticed from > patch #2, it shares some definitions with Exynos9 SoC, so I guess some > software is similar for both architectures. Not sure about hardware > though, never worked with Exynos9 CPUs. Anyway, I asked Samsung > representatives about naming, and it seems like we should stick to > "Exynos850" name, even in code. Since the chip identifies itself as E3830000, I would prefer naming matching real product ID instead of what is pushed by marketing or sales representatives. The marketing names don't have to follow any engineering rules, they can be changed and renamed. Sales follows rather money and corporate rules, not consistency for upstream project. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05124C4338F for ; Sat, 31 Jul 2021 07:31:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C320A60EBC for ; Sat, 31 Jul 2021 07:31:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C320A60EBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:Subject:From:References:Cc:To:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=AglcOq1DsWbpugTsuWDgwrFvbhJl7NOYz7Suo9sFsbQ=; b=EpvTZbptbd1ZXaasv+q4rjar4a 2cK83abEpkGOeiVnx5K9fQMpw9eHlTf1UlfG8FamiIH0nUbgzuawrg8RqJ6Crcv4k5pWG6Fpgr8eU o8up5vXC7vFjZlrSyxeKS6it9qvrEE5qHnznMC+G3hkWGsN34Qcy54GjjOpObIW3Mq5sYNJ5tlDAL ZAITV2FMZUuvY6ma0Ui9+5ajPKkjTm7yAXKKAWSyVuiTi+hKfi2C+r9rcKzd+hScDnmmQSC/jFul6 Tq7KftWhwcGKfOboyw6Pt8Ai7X61vNQUgNEHqg9LqSQ0PqcnIhCtcX18SowAKqnzkQa+aB7NqjLGq GNdLhcZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9jRJ-00BAgF-EZ; Sat, 31 Jul 2021 07:29:45 +0000 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9jRF-00BAfT-0Q for linux-arm-kernel@lists.infradead.org; Sat, 31 Jul 2021 07:29:42 +0000 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id BA6633F106 for ; Sat, 31 Jul 2021 07:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627716579; bh=7szpzek0sYJQJU9q3jPOrpIZQhKhL2Waoumc2yNvU78=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=gK78iDW31WXNAKEY4Te/5C3LOWAvuswD7dRowoPNOqIa7S7gKSrL/h4sAjkLqOmO4 690GdyEGZKfaksZdIxDQ1bhvZLp0inZ7qBzjfR/FNodDiojeXoiH3dvv+/uho0iY4K uL2Gwcr5PesTeHH0lexDebXVRP8SM9tRaBgBTQsWaGyKQUdwLU95OZ3GPzDLWLyOA5 mQAi3umgoOZLfoCSHXlqlNfzh/nrx6B9srMGjZ47Oho4xhDRjxlI1Lcz9akh46w8r6 sTrfPNVbyRMVPs4y2HaRSeOBvxQwVyITfQOvCW8h4iQqVXJYMnjtMHOR/WbbXat/Bq qcoorMFnGj/fg== Received: by mail-ed1-f72.google.com with SMTP id y39-20020a50bb2a0000b02903bc05daccbaso5770111ede.5 for ; Sat, 31 Jul 2021 00:29:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7szpzek0sYJQJU9q3jPOrpIZQhKhL2Waoumc2yNvU78=; b=rGF1JyQdS39EGS9OQHLrNXaEOE7o33b6wNX2dXcxm/i/ObVi9FdVAVfZvwS5EgM6y2 Ztn77jjTkJQLP1+s9SmyZtFZM8GozgXsy/j2ogkq84kOl0QiTm2p0mWJl+TKBnh4YJfl ntAY/aeC2oiComMbwnTqalUowQMxZuI8WgWrOGCY4iQ18+egGghe1WR9z3bnS7OfFjas AToO72ICejM8l6Gs5bJwSjtvqgM6G3RWqxZUo1Uvfmq3hPKLvNrp6Gv3BOZozVA+/Bgh vZhnf9RoiKDzhtOrfiv10ew1f4EnTf4Zv+NuXlGd5UaH/Z8nj2kgZ2G9JBi9HYV7924a Lrxw== X-Gm-Message-State: AOAM532rlt7XCjmr77nUZOJhkLwOgMDm4Cwfed1uuTWhPgUSPIMFWLtP QHiyjfFgsGLK3f8cTEQ1o4P0r6lWe1FOlqcO98NhihXZK4o/i9fUN83+d0fc2gfHMWwwPZQ5/lD +loXnBWG34c+e2l3pPKX+/MRQ3+lT9HXXiHEg4AwhHmyqvM88y6iS X-Received: by 2002:a05:6402:299:: with SMTP id l25mr7768579edv.283.1627716579287; Sat, 31 Jul 2021 00:29:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUxBOyxyGNdZMeniqKHPWuWGs2AKaZZj7ShbIHSxUlg3RJCNhhDtExvwhxpbohpRLzf5RItQ== X-Received: by 2002:a05:6402:299:: with SMTP id l25mr7768575edv.283.1627716579171; Sat, 31 Jul 2021 00:29:39 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id v13sm1361312ejh.62.2021.07.31.00.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jul 2021 00:29:38 -0700 (PDT) To: Sam Protsenko Cc: Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa , Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree , linux-arm Mailing List , linux-clk , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linux Samsung SOC , "open list:SERIAL DRIVERS" References: <20210730144922.29111-1-semen.protsenko@linaro.org> <5e35b0a7-13aa-3c62-ca49-14af2fcb2a08@canonical.com> From: Krzysztof Kozlowski Subject: Re: [PATCH 00/12] Add minimal support for Exynos850 SoC Message-ID: <13f166bb-7103-25d5-35a6-8ec53a1f1817@canonical.com> Date: Sat, 31 Jul 2021 09:29:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210731_002941_305082_F71DB539 X-CRM114-Status: GOOD ( 26.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/07/2021 21:02, Sam Protsenko wrote: > Hi Krzysztof, > > On Fri, 30 Jul 2021 at 20:21, Krzysztof Kozlowski > wrote: >> >> On 30/07/2021 17:18, Krzysztof Kozlowski wrote: >>> On 30/07/2021 16:49, Sam Protsenko wrote: >>>> This patch series adds initial platform support for Samsung Exynos850 >>>> SoC [1]. With this patchset it's possible to run the kernel with BusyBox >>>> rootfs as a RAM disk. More advanced platform support (like MMC driver >>>> additions) will be added later. The idea is to keep the first submission >>>> minimal to ease the review, and then build up on top of that. >>>> >>>> [1] https://www.samsung.com/semiconductor/minisite/exynos/products/mobileprocessor/exynos-850/ >>>> >>> >>> Great work! >>> > > Thanks, Krzysztof! And thank you for reviewing the whole series. > >>> What's the SoC revision number (should be accessible via >>> /sys/bus/soc/devices/soc0/)? Recent wrap in numbering of Exynos chips >>> might bring confusion... > > # cat /sys/devices/soc0/revision > 0 soc_id but you're right it won't be set for unknown SoCs. You need to extend drivers/soc/samsung/exynos-chipid.c to parse new values (E3830000 for product ID) and maybe new register offsets (previous offset is 0x0, for 3830 is 0x10 I think). Also revision mask might change. >> Judging by vendor's sources it is quite confusing. It looks mostly like >> Exynos3830 but in few other cases it uses Exynos9 compatibles (Exynos9, >> Exynos9820). Only in few places there is Exynos850. Marketing department >> made it so confusing... The revision embedded in SoC would be very >> interesting. >> > > As I understand, this SoC is called Exynos850 everywhere now. > Exynos3830 is its old name, not used anymore. As you noticed from > patch #2, it shares some definitions with Exynos9 SoC, so I guess some > software is similar for both architectures. Not sure about hardware > though, never worked with Exynos9 CPUs. Anyway, I asked Samsung > representatives about naming, and it seems like we should stick to > "Exynos850" name, even in code. Since the chip identifies itself as E3830000, I would prefer naming matching real product ID instead of what is pushed by marketing or sales representatives. The marketing names don't have to follow any engineering rules, they can be changed and renamed. Sales follows rather money and corporate rules, not consistency for upstream project. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel