From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Manuel Lauss <manuel.lauss@gmail.com>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 0/2] ASoC: Fix wm97xx touchscreen driver
Date: Fri, 23 Jan 2015 16:21:35 +0100 [thread overview]
Message-ID: <1422026497-23180-1-git-send-email-lars@metafoo.de> (raw)
The wm97xx touchscreen driver will bind itself to the snd_ac97 device
registered by CODEC drivers and expects that the device has already been
reset by the CODEC driver. Previous to commit 6794f709b712 ("ASoC: ac97:
Drop delayed device registration") the snd_ac97 device was only registered
after the CODEC driver probe function had finished running, but starting
with the commit it is registered within snd_soc_new_ac97_codec(). This
breaks the touchscreen driver as the reset is no longer performed before the
touchscreen driver probe function runs. This patch series introduces a new
function snd_soc_alloc_ac97_codec() which allocates the snd_ac97 device, but
does not yet register it yet. This allows the CODEC drivers to perform the
reset before the device is registered.
The series is meant to perform a minimum amount of changes while fixing the
issue to prevent introducing other regressions. I have a few more patches
that consolidate the reset handling in the drivers and puts it into the core
in snd_soc_new_ac97_codec() which makes the split in the drivers
unnecessary, but that's something for next and not for stable.
Manuel can you give this another round of testing?
Thanks,
- Lars
Lars-Peter Clausen (2):
ASoC: Add support for allocating AC'97 device before registering it
ASoC: wm97xx: Reset AC'97 device before registering it
include/sound/soc.h | 1 +
sound/soc/codecs/wm9705.c | 16 ++++++++++------
sound/soc/codecs/wm9712.c | 12 ++++++++----
sound/soc/codecs/wm9713.c | 12 ++++++++----
sound/soc/soc-ac97.c | 34 +++++++++++++++++++++++++++++-----
5 files changed, 56 insertions(+), 19 deletions(-)
--
1.8.0
next reply other threads:[~2015-01-23 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 15:21 Lars-Peter Clausen [this message]
2015-01-23 15:21 ` [PATCH 1/2] ASoC: Add support for allocating AC'97 device before registering it Lars-Peter Clausen
2015-01-23 15:21 ` [PATCH 2/2] ASoC: wm97xx: Reset " Lars-Peter Clausen
2015-01-26 13:14 ` Charles Keepax
2015-01-23 19:09 ` [PATCH 0/2] ASoC: Fix wm97xx touchscreen driver Manuel Lauss
2015-01-24 13:15 ` Lars-Peter Clausen
2015-01-26 19:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422026497-23180-1-git-send-email-lars@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=manuel.lauss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.