From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 04/29] libxl: suspend: common suspend callbacks take rc Date: Tue, 24 Mar 2015 10:55:54 +0000 Message-ID: <1427194554.21742.337.camel@citrix.com> References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com> <1423599016-32639-5-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423599016-32639-5-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Euan Harris List-Id: xen-devel@lists.xenproject.org On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote: > Change the following functions to take a libxl error code rather than > a boolean "ok" value, and translate that value to the boolean expected > by libxc at the last moment: > domain_suspend_callback_common_done } dss->callback_common_done > remus_domain_suspend_callback_common_done } > domain_suspend_common_done > > Also, abolish domain_suspend_common_failed as > domain_suspend_common_done can easily do its job and the call sites > now have to supply the right rc value anyway. > > In domain_suspend_common_guest_suspended, change "ret" to "rc" > as it contains a libxl error code. > > There is no functional change in this patch: the proper rc value now > propagates further, but is still eventually smashed to a boolean. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell There are a few new ERROR_FAILs which we might like to consider making more specific either now or later. Ian.