From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 12/29] libxl: events: Permit timeouts to signal cancellation Date: Tue, 24 Mar 2015 11:22:44 +0000 Message-ID: <1427196164.21742.348.camel@citrix.com> References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com> <1423599016-32639-13-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423599016-32639-13-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Euan Harris List-Id: xen-devel@lists.xenproject.org On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote: > The callback functions provided by users must take an rc value. This > rc value can be ERROR_TIMEDOUT or ERROR_CANCELLED. > > Users of xswait are now expected to deal correctly with > ERROR_CANCELLED. If they experience this, it hasn't been logged. > And the caller won't log it either since it's not TIMEDOUT. > Luckily this is correct, so we can just change the doc comment. > > Currently nothing generates ERROR_CANCELLED; in particular the > timeouts cannot in fact signal cancellation. > > There should be no publicly visible change except that some error > returns from libxl will change from ERROR_FAIL to ERROR_TIMEDOUT, and > some changes to debugging messages. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell