All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bard Liao <bardliao@realtek.com>
To: broonie@kernel.org, lgirdwood@gmail.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
	lars@metafoo.de, john.lin@realtek.com,
	Bard Liao <bardliao@realtek.com>,
	jason.ym.lin@realtek.com, flove@realtek.com
Subject: [PATCH 4/4] ASoC: rt5645: Restore HP depop setting in HP off
Date: Fri, 27 Mar 2015 20:19:09 +0800	[thread overview]
Message-ID: <1427458749-821-4-git-send-email-bardliao@realtek.com> (raw)
In-Reply-To: <1427458749-821-1-git-send-email-bardliao@realtek.com>

This driver will set RT5645_DEPOP_MAN bit in headphone power up
depop process. We need to restore it in headphone power down
process. Otherwise, we will get headphone noise when push button
function is enabled.

Signed-off-by: Bard Liao <bardliao@realtek.com>
---
 sound/soc/codecs/rt5645.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index b6d5b95..69528ae 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -1270,6 +1270,8 @@ static void hp_amp_power(struct snd_soc_codec *codec, int on)
 			snd_soc_update_bits(codec, RT5645_PWR_ANLG1,
 				RT5645_PWR_HP_L | RT5645_PWR_HP_R |
 				RT5645_PWR_HA, 0);
+			snd_soc_update_bits(codec, RT5645_DEPOP_M2,
+				RT5645_DEPOP_MASK, 0);
 		}
 	}
 }
-- 
1.8.1.1.439.g50a6b54

  parent reply	other threads:[~2015-03-27 12:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 12:19 [PATCH 1/4] ASoC: rt5645: Redefine format config for rt5650 Bard Liao
2015-03-27 12:19 ` [PATCH 2/4] ASoC: rt5645: Set use_single_rw flag for regmap Bard Liao
2015-03-27 12:19 ` [PATCH 3/4] ASoC: rt5645: Use update_bits for bit control Bard Liao
2015-03-27 12:19 ` Bard Liao [this message]
2015-03-27 16:51 ` [PATCH 1/4] ASoC: rt5645: Redefine format config for rt5650 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427458749-821-4-git-send-email-bardliao@realtek.com \
    --to=bardliao@realtek.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=flove@realtek.com \
    --cc=jason.ym.lin@realtek.com \
    --cc=john.lin@realtek.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=oder_chiou@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.