From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 06/29] libxl: Use libxl__xswait* in libxl__ao_device Date: Wed, 1 Apr 2015 10:25:16 +0100 Message-ID: <1427880316.2115.245.camel@citrix.com> References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com> <1423599016-32639-7-git-send-email-ian.jackson@eu.citrix.com> <1427195094.21742.340.camel@citrix.com> <21786.57894.19796.237655@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21786.57894.19796.237655@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Euan Harris List-Id: xen-devel@lists.xenproject.org On Tue, 2015-03-31 at 19:06 +0100, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] [PATCH 06/29] libxl: Use libxl__xswait* in libxl__ao_device"): > > On Tue, 2015-02-10 at 20:09 +0000, Ian Jackson wrote: > > > @@ -1164,7 +1136,7 @@ static void device_hotplug_clean(libxl__gc *gc, libxl__ao_device *aodev) > > > { > > > /* Clean events and check reentrancy */ > > > libxl__ev_time_deregister(gc, &aodev->timeout); > > > > You seem to have removed the initialisation of this in a previous hunk > > but not this deregistration or the field itself. > > > > Was that deliberate, perhaps it was serving dual purpose somewhere? > > Yes. See "TODO: 4.2 Bodge due to QEMU, see comment on top of"... > in libxl__initiate_device_remove in libxl_device.c. Ah, yes, thanks. Then: Acked-by: Ian Campbell