From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753125AbbENIYp (ORCPT ); Thu, 14 May 2015 04:24:45 -0400 Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:41779 "EHLO lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325AbbENIYm (ORCPT ); Thu, 14 May 2015 04:24:42 -0400 Message-ID: <1431591878.2650.26.camel@x220> Subject: Re: [PATCH 5/5] usb: add pxa1928 ehci support From: Paul Bolle To: Rob Herring Cc: Greg Kroah-Hartman , Alan Stern , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org Date: Thu, 14 May 2015 10:24:38 +0200 In-Reply-To: <1431557340-5421-6-git-send-email-robh@kernel.org> References: <1431557340-5421-1-git-send-email-robh@kernel.org> <1431557340-5421-6-git-send-email-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-05-13 at 17:49 -0500, Rob Herring wrote: > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > +config USB_EHCI_MV_OF > + bool "EHCI OF support for Marvell PXA/MMP USB controller" > + depends on (ARCH_PXA || ARCH_MMP) > + select USB_EHCI_ROOT_HUB_TT > + ---help--- > + Enables support for Marvell (including PXA and MMP series) on-chip > + USB SPH and OTG controller. SPH is a single port host, and it can > + only be EHCI host. OTG is controller that can switch to host mode. > + Note that this driver will not work on Marvell's other EHCI > + controller used by the EBU-type SoCs including Orion, Kirkwood, > + Dova, Armada 370 and Armada XP. See "Support for Marvell EBU > + on-chip EHCI USB controller" for those. > --- a/drivers/usb/host/Makefile > +++ b/drivers/usb/host/Makefile > +obj-$(CONFIG_USB_EHCI_MV_OF) += ehci-mv-of.o USB_EHCI_MV_OF is a bool symbol so ehci-mv-of.o will never be part of a module, correct? > --- /dev/null > +++ b/drivers/usb/host/ehci-mv-of.c > +MODULE_DEVICE_TABLE(of, mv_ehci_dt_match); > +module_init(ehci_mv_init); > + > +static void __exit ehci_mv_cleanup(void) > +{ > + platform_driver_unregister(&ehci_mv_driver); > +} > +module_exit(ehci_mv_cleanup); > + > +MODULE_AUTHOR("Rob Herring "); > +MODULE_LICENSE("GPL v2"); The code contains a few module-specific constructs. (These will be preprocessed away, replaced with a built-in equivalent, etc.) Was it your intention to make USB_EHCI_MV_OF tristate? Paul Bolle