From mboxrd@z Thu Jan 1 00:00:00 1970 From: ville.syrjala@linux.intel.com Subject: [PATCH] drm: Don't oops in drm_calc_timestamping_constants() if drm_vblank_init() wasn't called Date: Thu, 12 Nov 2015 14:34:18 +0200 Message-ID: <1447331658-15628-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 403596E337 for ; Thu, 12 Nov 2015 04:34:22 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Jeff Moyer List-Id: dri-devel@lists.freedesktop.org RnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClNl ZW1zIHRoZSBjcnRjIGhlbHBlcnMgY2FsbCBkcm1fY2FsY190aW1lc3RhbXBpbmdfY29uc3RhbnRz KCkKdW5jb25kaXRpb25hbGx5IGV2ZW4gaWYgdGhlIGRyaXZlciBkaWRuJ3QgaW5pdGlhbGl6ZSB2 Ymxhbmsgc3VwcG9ydCBieQpjYWxsaW5nIGRybV92YmxhbmtfaW5pdCgpLiBUaGF0IHVzZWQgdG8g YmUgT0sgc2luY2UgdGhlIGNvbnN0YW50cyB3ZXJlCnN0b3JlZCB1bmRlciBkcm1fY3J0Yy4KCkhv d2V2ZXIgSSBicm9rZSB0aGlzIHdpdGgKY29tbWl0IGViYTFmMzVkZmUxNCAoImRybTogTW92ZSB0 aW1lc3RhbXBpbmcgY29uc3RhbnRzIGludG8gZHJtX3ZibGFua19jcnRjIikKd2hlbiBJIG1vdmVk IHRoZSBjb25zdGFudHMgdG8gbGl2ZSBpbnNpZGUgdGhlIGRybV92YmxhbmtfY3J0YyBzdHJ1Y3QK aW5zdGVhZC4gSWYgZHJtX3ZibGFua19pbml0KCkgaXNuJ3QgY2FsbGVkLCB3ZSBkb24ndCBhbGxv Y2F0ZSB0aGVzZQpzdHJ1Y3R1cmVzLCBhbmQgc28gZHJtX2NhbGNfdGltZXN0YW1waW5nX2NvbnN0 YW50cygpIHdpbGwgb29wcy4KCkZpeCBpdCBieSBhZGRpbmcgYSBjaGVjayBpbnRvIGRybV9jYWxj X3RpbWVzdGFtcGluZ19jb25zdGFudHMoKSB0byBzZWUKaWYgdmJsYW5rIHN1cHBvcnQgd2FzIGlu aXRpYWxpemVkIGF0IGFsbC4gQW5kIHRvIGtlZXAgaW4gbGluZSB3aXRoIG90aGVyCnN1Y2ggY2hl Y2tzLCBhbHNvIHRvc3MgaW4gYSBjaGVjayBhbmQgd2FybiBmb3IgdGhlIGNhc2Ugd2hlcmUgdmJs YW5rCnN1cHBvcnQgd2FzIGluaXRpYWxpemVkLCBidXQgdGhlIHdyb25nIG51bWJlciBvZiBjcnRj cyB3YXMgc3BlY2lmaWVkLgoKRml4ZXMgdGhlIGZvbGxvd2luZyBzb3J0IG9mIG9vcHM6CiBCVUc6 IHVuYWJsZSB0byBoYW5kbGUga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBhdCAwMDAw MDAwMDAwMDAwMGIwCiBJUDogWzxmZmZmZmZmZmEwMTRiMjY2Pl0gZHJtX2NhbGNfdGltZXN0YW1w aW5nX2NvbnN0YW50cysweDg2LzB4MTMwIFtkcm1dCiBQR0QgMAogT29wczogMDAwMiBbIzFdIFNN UAogTW9kdWxlcyBsaW5rZWQgaW46IHNyX21vZCBjZHJvbSBtZ2FnMjAwKCspIGkyY19hbGdvX2Jp dCBkcm1fa21zX2hlbHBlciBhaGNpIHN5c2NvcHlhcmVhIHN5c2ZpbGxyZWN0IHN5c2ltZ2JsdCBs aWJhaGNpIGZiX3N5c19mb3BzIGJueDJ4IHR0bSB0ZzMoKykgbWRpbyBkcm0gcHRwIHNkX21vZCBs aWJhdGEgaTJjX2NvcmUgcHBzX2NvcmUgbGliY3JjMzJjIGhwc2EgZG1fbWlycm9yIGRtX3JlZ2lv bl9oYXNoIGRtX2xvZyBkbV9tb2QKIENQVTogMCBQSUQ6IDQxOCBDb21tOiBrd29ya2VyLzA6MiBO b3QgdGFpbnRlZCA0LjMuMCsgIzEKIEhhcmR3YXJlIG5hbWU6IEhQIFByb0xpYW50IERMMzgwIEdl bjksIEJJT1MgUDg5IDA2LzA5LzIwMTUKIFdvcmtxdWV1ZTogZXZlbnRzIHdvcmtfZm9yX2NwdV9m bgogdGFzazogZmZmZjg4MDQ2Y2E5NTUwMCB0aTogZmZmZjg4MDA3ODMwYzAwMCB0YXNrLnRpOiBm ZmZmODgwMDc4MzBjMDAwCiBSSVA6IDAwMTA6WzxmZmZmZmZmZmEwMTRiMjY2Pl0gIFs8ZmZmZmZm ZmZhMDE0YjI2Nj5dIGRybV9jYWxjX3RpbWVzdGFtcGluZ19jb25zdGFudHMrMHg4Ni8weDEzMCBb ZHJtXQogUlNQOiAwMDE4OmZmZmY4ODAwNzgzMGY0ZTggIEVGTEFHUzogMDAwMTAyNDYKIFJBWDog MDAwMDAwMDAwMGZlNGMwMCBSQlg6IGZmZmY4ODAwNmE4NDkxNjAgUkNYOiAwMDAwMDAwMDAwMDAw NTQwCiBSRFg6IDAwMDAwMDAwMDAwMDAwMDAgUlNJOiAwMDAwMDAwMDAwMDBmZGU4IFJESTogZmZm Zjg4MDA2YTg0OTAwMAogUkJQOiBmZmZmODgwMDc4MzBmNTE4IFIwODogZmZmZjg4MDA3ODMwYzAw MCBSMDk6IDAwMDAwMDAxYjg3ZTM3MTIKIFIxMDogMDAwMDAwMDAwMDAwNTBjNCBSMTE6IDAwMDAw MDAwMDAwMDAwMDAgUjEyOiAwMDAwMDAwMDAwZmU0YzAwCiBSMTM6IGZmZmY4ODAwNmE4NDkwMDAg UjE0OiAwMDAwMDAwMDAwMDAwMDAwIFIxNTogMDAwMDAwMDAwMDAwZmRlOAogRlM6ICAwMDAwMDAw MDAwMDAwMDAwKDAwMDApIEdTOmZmZmY4ODA0NmY4MDAwMDAoMDAwMCkga25sR1M6MDAwMDAwMDAw MDAwMDAwMAogQ1M6ICAwMDEwIERTOiAwMDAwIEVTOiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAz MwogQ1IyOiAwMDAwMDAwMDAwMDAwMGIwIENSMzogMDAwMDAwMDAwMTlkNjAwMCBDUjQ6IDAwMDAw MDAwMDAxNDA2ZjAKIFN0YWNrOgogIGZmZmY4ODAwNzgzMGY1MTggZmZmZjg4MDA2YTg0OTAwMCBm ZmZmODgwYzY5YjkwMzQwIGZmZmY4ODBjNjliOTAwMDAKICBmZmZmODgwYzY5YjkwMzQ4IGZmZmY4 ODBjNjliOTAzNDAgZmZmZjg4MDA3ODMwZjc0OCBmZmZmZmZmZmEwNDJmN2U3CiAgZmZmZjg4MDA2 YTg0OTA5MCAwMDAwMDAwMDAwMDAwMDAwIGZmZmY4ODAwNmE4NDkxNjAgMDAwMDAwMDAwMDAwMDAw MAogQ2FsbCBUcmFjZToKICBbPGZmZmZmZmZmYTA0MmY3ZTc+XSBkcm1fY3J0Y19oZWxwZXJfc2V0 X21vZGUrMHgzZDcvMHg0YjAgW2RybV9rbXNfaGVscGVyXQogIFs8ZmZmZmZmZmZhMDQzMDdkND5d IGRybV9jcnRjX2hlbHBlcl9zZXRfY29uZmlnKzB4OGQ0LzB4YjEwIFtkcm1fa21zX2hlbHBlcl0K ICBbPGZmZmZmZmZmYTAxNTQ4ZDQ+XSBkcm1fbW9kZV9zZXRfY29uZmlnX2ludGVybmFsKzB4NjQv MHgxMDAgW2RybV0KICBbPGZmZmZmZmZmYTA0M2MzNDI+XSBkcm1fZmJfaGVscGVyX3Bhbl9kaXNw bGF5KzB4YTIvMHgyODAgW2RybV9rbXNfaGVscGVyXQogIFs8ZmZmZmZmZmY4MTM5MmM3Yj5dIGZi X3Bhbl9kaXNwbGF5KzB4YmIvMHgxNzAKICBbPGZmZmZmZmZmODEzOGNmNzA+XSBiaXRfdXBkYXRl X3N0YXJ0KzB4MjAvMHg1MAogIFs8ZmZmZmZmZmY4MTM4YjgxYj5dIGZiY29uX3N3aXRjaCsweDM5 Yi8weDU5MAogIFs8ZmZmZmZmZmY4MTQwYTNkMD5dIHJlZHJhd19zY3JlZW4rMHgxYTAvMHgyNDAK ICBbPGZmZmZmZmZmODE0MGIzMGU+XSBkb19iaW5kX2Nvbl9kcml2ZXIrMHgyZWUvMHgzMTAKICBb PGZmZmZmZmZmODE0MGI2NTE+XSBkb190YWtlX292ZXJfY29uc29sZSsweDE0MS8weDFiMAogIFs8 ZmZmZmZmZmY4MTM4NzM3Nz5dIGRvX2ZiY29uX3Rha2VvdmVyKzB4NTcvMHhiMAogIFs8ZmZmZmZm ZmY4MTM4Yzk4Yj5dIGZiY29uX2V2ZW50X25vdGlmeSsweDYwYi8weDc1MAogIFs8ZmZmZmZmZmY4 MTBhNTU5OT5dIG5vdGlmaWVyX2NhbGxfY2hhaW4rMHg0OS8weDcwCiAgWzxmZmZmZmZmZjgxMGE1 OGRkPl0gX19ibG9ja2luZ19ub3RpZmllcl9jYWxsX2NoYWluKzB4NGQvMHg3MAogIFs8ZmZmZmZm ZmY4MTBhNTkxNj5dIGJsb2NraW5nX25vdGlmaWVyX2NhbGxfY2hhaW4rMHgxNi8weDIwCiAgWzxm ZmZmZmZmZjgxMzkyODJiPl0gZmJfbm90aWZpZXJfY2FsbF9jaGFpbisweDFiLzB4MjAKICBbPGZm ZmZmZmZmODEzOTQ4ODE+XSByZWdpc3Rlcl9mcmFtZWJ1ZmZlcisweDFmMS8weDMzMAogIFs8ZmZm ZmZmZmZhMDQzZDlhYT5dIGRybV9mYl9oZWxwZXJfaW5pdGlhbF9jb25maWcrMHgyN2EvMHgzZDAg W2RybV9rbXNfaGVscGVyXQogIFs8ZmZmZmZmZmZhMDQ2OWI0ZD5dIG1nYWcyMDBfZmJkZXZfaW5p dCsweGRkLzB4ZjAgW21nYWcyMDBdCiAgWzxmZmZmZmZmZmEwNDY4NTg2Pl0gbWdhZzIwMF9tb2Rl c2V0X2luaXQrMHgxNzYvMHgxZTAgW21nYWcyMDBdCiAgWzxmZmZmZmZmZmEwNDY0NjU5Pl0gbWdh ZzIwMF9kcml2ZXJfbG9hZCsweDNmOS8weDU4MCBbbWdhZzIwMF0KICBbPGZmZmZmZmZmYTAxNGUw Njc+XSBkcm1fZGV2X3JlZ2lzdGVyKzB4YTcvMHhiMCBbZHJtXQogIFs8ZmZmZmZmZmZhMDE1MDU0 Zj5dIGRybV9nZXRfcGNpX2RldisweDhmLzB4MWUwIFtkcm1dCiAgWzxmZmZmZmZmZmEwNDY5Mzdi Pl0gbWdhX3BjaV9wcm9iZSsweDliLzB4YzAgW21nYWcyMDBdCiAgWzxmZmZmZmZmZjgxMzY2MmQ1 Pl0gbG9jYWxfcGNpX3Byb2JlKzB4NDUvMHhhMAogIFs8ZmZmZmZmZmY4MTA5YWZlND5dIHdvcmtf Zm9yX2NwdV9mbisweDE0LzB4MjAKICBbPGZmZmZmZmZmODEwOWUxM2M+XSBwcm9jZXNzX29uZV93 b3JrKzB4MTRjLzB4M2MwCiAgWzxmZmZmZmZmZjgxMDllYWE0Pl0gd29ya2VyX3RocmVhZCsweDI0 NC8weDQ3MAogIFs8ZmZmZmZmZmY4MTY4YmZiYT5dID8gX19zY2hlZHVsZSsweDJhYS8weDc2MAog IFs8ZmZmZmZmZmY4MTA5ZTg2MD5dID8gcmVzY3Vlcl90aHJlYWQrMHgzMTAvMHgzMTAKICBbPGZm ZmZmZmZmODEwYTQ0Mzg+XSBrdGhyZWFkKzB4ZDgvMHhmMAogIFs8ZmZmZmZmZmY4MTBhNDM2MD5d ID8ga3RocmVhZF9wYXJrKzB4NjAvMHg2MAogIFs8ZmZmZmZmZmY4MTY5MDMwZj5dIHJldF9mcm9t X2ZvcmsrMHgzZi8weDcwCiAgWzxmZmZmZmZmZjgxMGE0MzYwPl0gPyBrdGhyZWFkX3BhcmsrMHg2 MC8weDYwCiBDb2RlOiBmNiAzMSBkMiA0MSA4OSBjMiA4YiA4MyBiNCAwMCAwMCAwMCAwZiBhZiBj MSA0OCA5OCA0OCA2OSBjMCA0MCA0MiAwZiAwMCA0OCBmNyBmNiBmNiA0MyA3NCAxMCA0MSA4OSBj NCA3NSAyNiBmNiAwNSA5YSA2ZiAwMyAwMCAwMSA8NDU+IDg5IDk2IGIwIDAwIDAwIDAwIDQ1IDg5 IGE2IGFjIDAwIDAwIDAwIDc1IDM1IDQ4IDgzIGM0IDA4IDViCiBSSVAgIFs8ZmZmZmZmZmZhMDE0 YjI2Nj5dIGRybV9jYWxjX3RpbWVzdGFtcGluZ19jb25zdGFudHMrMHg4Ni8weDEzMCBbZHJtXQog IFJTUCA8ZmZmZjg4MDA3ODMwZjRlOD4KIENSMjogMDAwMDAwMDAwMDAwMDBiMAoKQ2M6IEplZmYg TW95ZXIgPGptb3llckByZWRoYXQuY29tPgpSZXBvcnRlZC1ieTogSmVmZiBNb3llciA8am1veWVy QHJlZGhhdC5jb20+ClJlZmVyZW5jZXM6IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJj aGl2ZXMvZHJpLWRldmVsLzIwMTUtTm92ZW1iZXIvMDk0MjE3Lmh0bWwKRml4ZXM6IGViYTFmMzVk ZmUxNCAoImRybTogTW92ZSB0aW1lc3RhbXBpbmcgY29uc3RhbnRzIGludG8gZHJtX3ZibGFua19j cnRjIikKU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jIHwgMTAgKysrKysrKysr LQogMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ly cS5jCmluZGV4IGViYTYzMzcuLjIxNTFlYTUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1faXJxLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwpAQCAtNjE2LDEwICs2MTYs MTggQEAgaW50IGRybV9jb250cm9sKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEs CiB2b2lkIGRybV9jYWxjX3RpbWVzdGFtcGluZ19jb25zdGFudHMoc3RydWN0IGRybV9jcnRjICpj cnRjLAogCQkJCSAgICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpCiB7Ci0J c3RydWN0IGRybV92YmxhbmtfY3J0YyAqdmJsYW5rID0gJmNydGMtPmRldi0+dmJsYW5rW2RybV9j cnRjX2luZGV4KGNydGMpXTsKKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owor CXVuc2lnbmVkIGludCBwaXBlID0gZHJtX2NydGNfaW5kZXgoY3J0Yyk7CisJc3RydWN0IGRybV92 YmxhbmtfY3J0YyAqdmJsYW5rID0gJmRldi0+dmJsYW5rW3BpcGVdOwogCWludCBsaW5lZHVyX25z ID0gMCwgZnJhbWVkdXJfbnMgPSAwOwogCWludCBkb3RjbG9jayA9IG1vZGUtPmNydGNfY2xvY2s7 CiAKKwlpZiAoIWRldi0+bnVtX2NydGNzKQorCQlyZXR1cm47CisKKwlpZiAoV0FSTl9PTihwaXBl ID49IGRldi0+bnVtX2NydGNzKSkKKwkJcmV0dXJuOworCiAJLyogVmFsaWQgZG90Y2xvY2s/ICov CiAJaWYgKGRvdGNsb2NrID4gMCkgewogCQlpbnQgZnJhbWVfc2l6ZSA9IG1vZGUtPmNydGNfaHRv dGFsICogbW9kZS0+Y3J0Y192dG90YWw7Ci0tIAoyLjQuMTAKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==