All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Zaborowski <andrew.zaborowski@intel.com>
To: ell@lists.01.org
Subject: [PATCH 3/5] unit: Update _dbus_filter usage in test-dbus-watch
Date: Mon, 18 Apr 2016 16:31:15 +0200	[thread overview]
Message-ID: <1460989877-20113-8-git-send-email-andrew.zaborowski@intel.com> (raw)
In-Reply-To: <1460989877-20113-1-git-send-email-andrew.zaborowski@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]

Also fix what seems to be incorrect use of l_dbus_message_set_arguments
---
 unit/test-dbus-watch.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/unit/test-dbus-watch.c b/unit/test-dbus-watch.c
index 684ac34..1d8f94c 100644
--- a/unit/test-dbus-watch.c
+++ b/unit/test-dbus-watch.c
@@ -387,7 +387,7 @@ static void test_filter_tree(const void *test_data)
 		{ L_DBUS_MATCH_PATH, DBUS_PATH_DBUS },
 		{ L_DBUS_MATCH_INTERFACE, DBUS_INTERFACE_DBUS },
 		{ L_DBUS_MATCH_MEMBER, "NameOwnerChanged" },
-		{ L_DBUS_MATCH_ARGUMENT(0), ":1.101" }
+		{ L_DBUS_MATCH_ARGUMENT(0), "org.test" }
 	};
 	static struct _dbus_filter_condition rule4[] = {
 		{ L_DBUS_MATCH_TYPE, "signal" },
@@ -396,7 +396,7 @@ static void test_filter_tree(const void *test_data)
 	unsigned int id1, id2, id3, id4, internal_id1, internal_id4;
 	struct l_dbus_message *message;
 
-	filter = _dbus_filter_new(&test.dbus, &filter_ops);
+	filter = _dbus_filter_new(&test.dbus, &filter_ops, NULL);
 	assert(filter);
 
 	test.expected_rule = rule123;
@@ -423,7 +423,8 @@ static void test_filter_tree(const void *test_data)
 	message = _dbus_message_new_signal(2, DBUS_PATH_DBUS,
 						DBUS_INTERFACE_DBUS,
 						"NameOwnerChanged");
-	l_dbus_message_set_arguments(message, "sss", ":1.101", "", ":1.101");
+	l_dbus_message_set_arguments(message, "sss", "org.test",
+					":1.101", "", ":1.101");
 	_dbus_message_set_sender(message, DBUS_SERVICE_DBUS);
 	_dbus_filter_dispatch(message, filter);
 	l_dbus_message_unref(message);
-- 
2.5.0


  parent reply	other threads:[~2016-04-18 14:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-18 14:31 [PATCH 1/2] dbus: Add private _dbus_message_new_error Andrew Zaborowski
2016-04-18 14:31 ` [PATCH 2/2] dbus: Handle kdbus KDBUS_ITEM_REPLY_TIMEOUT / _DEAD Andrew Zaborowski
2016-04-18 14:31 ` [PATCH] dbus: Check message->sealed before get_header_field() Andrew Zaborowski
2016-04-19  2:39   ` Denis Kenzior
2016-04-18 14:31 ` [PATCH] dbus: Don't send replies to messages with no reply flag Andrew Zaborowski
2016-04-18 14:31 ` [PATCH] unit: Add test-dbus-properties --kdbus option Andrew Zaborowski
2016-04-19  2:41   ` Denis Kenzior
2016-04-18 14:31 ` [PATCH 1/5] dbus: Add a Bus Name cache Andrew Zaborowski
2016-04-21  3:30   ` Denis Kenzior
2016-04-18 14:31 ` [PATCH 2/5] dbus: Use the name cache API in _dbus_filter Andrew Zaborowski
2016-04-18 14:31 ` Andrew Zaborowski [this message]
2016-04-18 14:31 ` [PATCH 4/5] dbus: Add service watch API based on the name cache Andrew Zaborowski
2016-04-18 14:31 ` [PATCH 5/5] dbus: Use the name cache for public service watches Andrew Zaborowski
2016-04-19  2:37 ` [PATCH 1/2] dbus: Add private _dbus_message_new_error Denis Kenzior
2016-04-22  0:03   ` Andrzej Zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460989877-20113-8-git-send-email-andrew.zaborowski@intel.com \
    --to=andrew.zaborowski@intel.com \
    --cc=ell@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.