All of lore.kernel.org
 help / color / mirror / Atom feed
From: vedang.patel@intel.com
To: alsa-devel@alsa-project.org
Cc: vinod.koul@intel.com, marc.herbert@intel.com,
	liam.r.girdwood@intel.com, jeeja.kp@intel.com,
	subhransu.s.prusty@intel.com,
	Vedang Patel <vedang.patel@intel.com>
Subject: [PATCH v2 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed
Date: Tue, 26 Apr 2016 16:03:08 -0700	[thread overview]
Message-ID: <1461711790-7277-2-git-send-email-vedang.patel@intel.com> (raw)
In-Reply-To: <1461711790-7277-1-git-send-email-vedang.patel@intel.com>

From: Vedang Patel <vedang.patel@intel.com>

The hdac_hdmi codec driver prints the ELD information everytime an
external monitor is connected. Make it so that the information is only
printed when someone trying to debug the driver explicitly enables it.

print_hex_dump_bytes (which just calls print_hex_dump) uses
printk(KERN_DEBUG,... which is different from dev_dbg used elsewhere in
the driver: it's always enabled at compile-time. Change it to
print_hex_dump_debug for logging consistency.

Change-Id: I6a7ac1d40a73369ea5dc58b7afde0288b8e86558
Signed-off-by: Vedang Patel <vedang.patel@intel.com>
---
 sound/soc/codecs/hdac_hdmi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c
index aaa038f..def565d 100644
--- a/sound/soc/codecs/hdac_hdmi.c
+++ b/sound/soc/codecs/hdac_hdmi.c
@@ -1066,8 +1066,9 @@ static void hdac_hdmi_present_sense(struct hdac_hdmi_pin *pin, int repoll)
 				snd_jack_report(pcm->jack, SND_JACK_AVOUT);
 			}
 
-			print_hex_dump_bytes("ELD: ", DUMP_PREFIX_OFFSET,
-					pin->eld.eld_buffer, pin->eld.eld_size);
+			print_hex_dump_debug("ELD: ",
+					DUMP_PREFIX_OFFSET, 16, 1,
+					pin->eld.eld_buffer, pin->eld.eld_size, true);
 		} else {
 			pin->eld.monitor_present = false;
 			pin->eld.eld_valid = false;
-- 
2.1.2

  reply	other threads:[~2016-04-26 23:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 22:08 [PATCH 0/3] ASoC: Reduce audio related kernel spew vedang.patel
2016-04-12 22:08 ` [PATCH 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-04-13  1:09   ` Takashi Sakamoto
2016-04-14 15:15     ` Vedang Patel
2016-04-15 19:13       ` Vedang Patel
2016-04-12 22:08 ` [PATCH 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-06-27 16:40   ` Applied "ASoC: Intel: common: increase the loglevel of "FW Poll Status"." to the asoc tree Mark Brown
2016-04-12 22:08 ` [PATCH 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-04-26 23:03   ` [PATCH v2 0/3] ASoC: Reduce audio related kernel spew vedang.patel
2016-04-26 23:03     ` vedang.patel [this message]
2016-04-26 23:03     ` [PATCH v2 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-04-26 23:03     ` [PATCH v2 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-06-01  1:14       ` [PATCH v3 0/3] ASoC: Reduce audio related kernel spew vedang.patel
2016-06-01  1:14         ` [PATCH v3 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-06-27 16:40           ` Applied "ASoC: hdac_hdmi: Increase loglevel of hex dump printed" to the asoc tree Mark Brown
2016-06-01  1:15         ` [PATCH v3 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-06-01  1:15         ` [PATCH v3 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-06-01  5:56         ` [PATCH v3 0/3] ASoC: Reduce audio related kernel spew Vinod Koul
2016-06-25  0:37       ` [REPOST REPOST PATCH " vedang.patel
2016-06-25  0:37         ` [REPOST REPOST PATCH v3 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-06-25  0:37         ` [REPOST REPOST PATCH v3 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-06-25  0:37         ` [REPOST REPOST PATCH v3 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-06-27 14:50         ` [REPOST REPOST PATCH v3 0/3] ASoC: Reduce audio related kernel spew Mark Brown
2016-06-29 23:39           ` Patel, Vedang
2016-06-30  2:27             ` Vinod Koul
2016-07-01  7:50               ` Mark Brown
2016-06-27 16:40       ` Applied "ASoC: Intel: Skylake: Increase loglevel of debug messages." to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461711790-7277-2-git-send-email-vedang.patel@intel.com \
    --to=vedang.patel@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jeeja.kp@intel.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=marc.herbert@intel.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.