All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jiri Kosina <jikos@kernel.org>,
	Colin Ian King <colin.king@canonical.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] trivial for 4.9
Date: Fri, 07 Oct 2016 14:44:27 -0700	[thread overview]
Message-ID: <1475876667.1945.28.camel@perches.com> (raw)
In-Reply-To: <CA+55aFzXfy3X5-0V=jNEKUVntfq_2e8-ExxCTfcgSr+LhVBv+w@mail.gmail.com>

On Fri, 2016-10-07 at 14:06 -0700, Linus Torvalds wrote:
> And btw, even without an explicit KERN_<level>, you should still not
> get any interleaving. Only an _explicit_ KERN_CONT should cause
> interleaving, and dammit, if some interrupt does a KERN_CONT without
> having had a non-cont printk before it, that code is buggy and should
> damn well be fixed.

That's not true.  KERN_CONT is a no-op.
Bare printks interleave.

$ git grep KERN_CONT include/linux/kern_levels.h
include/linux/kern_levels.h:#define KERN_CONT   ""

I think it was like 2007 when I first suggested _not_ having
newlines on the pr_<level> macros that were eventually added
by Emil Medve.

  parent reply	other threads:[~2016-10-07 21:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07  8:51 [GIT PULL] trivial for 4.9 Jiri Kosina
2016-10-07 19:22 ` Linus Torvalds
2016-10-07 20:04   ` Joe Perches
2016-10-07 20:13     ` Linus Torvalds
2016-10-07 20:18       ` Joe Perches
2016-10-07 20:25         ` Linus Torvalds
2016-10-07 20:33           ` Joe Perches
2016-10-07 21:06             ` Linus Torvalds
2016-10-07 21:37               ` Linus Torvalds
2016-10-08  7:36                 ` Joe Perches
2016-10-10  5:48                 ` Joe Perches
2016-10-07 21:44               ` Joe Perches [this message]
2016-10-07 23:01                 ` Tony Luck
2016-10-07 23:09                   ` Tony Luck
2016-10-07 23:36                     ` Linus Torvalds
2016-10-08 13:16                     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475876667.1945.28.camel@perches.com \
    --to=joe@perches.com \
    --cc=colin.king@canonical.com \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.