From: Amir Goldstein <amir73il@gmail.com>
To: "Darrick J . Wong" <darrick.wong@oracle.com>
Cc: Brian Foster <bfoster@redhat.com>, linux-xfs@vger.kernel.org
Subject: [PATCH v6 0/3] xfs: fixes for malformed on-disk i_mode
Date: Mon, 9 Jan 2017 15:06:26 +0200 [thread overview]
Message-ID: <1483967189-27313-1-git-send-email-amir73il@gmail.com> (raw)
Darrick,
This is 6th revision of the fixes for malformed on-disk i_mode.
I implemented the xfs specific test case (xfs/348) to test all
possible malformed file type values as you suggested.
Tested with generic/401 with -n ftype=0|1.
Tested with new xfs/348 test with -n ftype=0|1.
Test xfs/348 exposed an ASSERT on attempt to readdir of regular
file that is posing as a directory.
Patch 2 implements your suggestion to address this case.
Patch 3 fixes a very strage upsidedown unlikely() in the
xfs ASSERT macros. I hope I am not tripping...
Amir.
v6:
- Added Reviewed-by Brian for patch 1
- Added patch 2 to address new xfs/348 failures
- Added patch 3 to fix ASSERT() likely
v5:
- remove wrong argument about on-disk malformed mode from commit message
- address Brian's review comments
v4:
- independent fix patch for xfs
Amir Goldstein (3):
xfs: fix the size of xfs_mode_to_ftype table
xfs: sanity check directory inode di_size
xfs: make the ASSERT() condition likely
fs/xfs/libxfs/xfs_dir2.c | 21 +++++++++++----------
fs/xfs/libxfs/xfs_dir2.h | 4 +++-
fs/xfs/libxfs/xfs_inode_buf.c | 7 +++++--
fs/xfs/xfs_iops.c | 2 +-
fs/xfs/xfs_linux.h | 6 +++---
5 files changed, 23 insertions(+), 17 deletions(-)
--
2.7.4
next reply other threads:[~2017-01-09 13:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 13:06 Amir Goldstein [this message]
2017-01-09 13:06 ` [PATCH v6 1/3] xfs: fix the size of xfs_mode_to_ftype table Amir Goldstein
2017-01-09 15:51 ` Christoph Hellwig
2017-01-09 17:21 ` Amir Goldstein
2017-01-09 21:17 ` Darrick J. Wong
2017-01-10 7:54 ` Amir Goldstein
2017-01-09 13:06 ` [PATCH v6 2/3] xfs: sanity check directory inode di_size Amir Goldstein
2017-01-09 15:52 ` Christoph Hellwig
2017-01-09 13:06 ` [PATCH v6 3/3] xfs: make the ASSERT() condition likely Amir Goldstein
2017-01-09 15:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483967189-27313-1-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.