From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932382AbdBHQq7 (ORCPT ); Wed, 8 Feb 2017 11:46:59 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:59353 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752529AbdBHQqQ (ORCPT ); Wed, 8 Feb 2017 11:46:16 -0500 Message-ID: <1486570580.7066.7.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion From: "Nicholas A. Bellinger" To: Christoph Hellwig Cc: target-devel , linux-scsi , lkml , Benjamin ESTRABAUD Date: Wed, 08 Feb 2017 08:16:20 -0800 In-Reply-To: <20170207224453.GB5274@infradead.org> References: <1486473470-15837-1-git-send-email-nab@linux-iscsi.org> <1486473470-15837-2-git-send-email-nab@linux-iscsi.org> <20170207224453.GB5274@infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-02-07 at 14:44 -0800, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 01:17:46PM +0000, Nicholas A. Bellinger wrote: > > + if (orig->se_lun_acl != NULL) { > > + pr_warn_ratelimited("Detected existing explicit" > > + " se_lun_acl->se_lun_group reference for %s" > > + " mapped_lun: %llu, ignoring\n", > > + nacl->initiatorname, mapped_lun); > > The ignoring in the message confused the heck out of me first. But it > seems that's just an incorrect leftover from the original message, as the > changelog also says fail instead. With that fixed up (and maybe the > whole message in a single string literal on a single line): > Fixed up the message to use 'failed'.