All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Balean <james@balean.com.au>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add out-of-source U-Boot device tree support
Date: Mon, 27 Mar 2017 20:19:49 -0500	[thread overview]
Message-ID: <1490663989-14886-1-git-send-email-james@balean.com.au> (raw)
In-Reply-To: <07d14184-7b9c-dd29-569c-db46aa765118@mind.be>

Hi Arnout,

Thank you for your reviewing this patch and for your response.

On 27 March 2017 at 23:12, Arnout Vandecappelle <arnout@mind.be> wrote:
>  Would it make sense to add
>         default BR2_LINUX_KERNEL_CUSTOM_DTS_PATH if BR2_LINUX_KERNEL_USE_CUSTOM_DTS
> ?

>  Perhaps also
>         depends on BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
> (AFAIK it's not possible to link in a DTB in the legacy build system.)

>  Indentation should be 1 tab + 2 spaces, and wrap at 72 columns (where tab
> counts as 8, so 62 significant characters).

>  Perhaps you can add
>
>           To use this device tree source file, the U-Boot configuration
>           file must refer to it.

All very good suggestions, which I will incorporate in a new version of the patch shortly.

Thanks again,
James
-- 
2.7.4

  reply	other threads:[~2017-03-28  1:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-27  6:12 [Buildroot] [PATCH] Add out-of-source U-Boot device tree support James Balean
2017-03-27 12:12 ` Arnout Vandecappelle
2017-03-28  1:19   ` James Balean [this message]
2017-03-28  6:14   ` James Balean
2017-03-28  9:01     ` Arnout Vandecappelle
2017-03-28 19:53       ` Thomas Petazzoni
2017-03-28 20:19         ` Arnout Vandecappelle
2017-03-28 20:29           ` Thomas Petazzoni
2017-03-28 22:17             ` Arnout Vandecappelle
2017-03-29  7:09               ` Thomas Petazzoni
2017-04-05  3:29                 ` James Balean
2017-04-05  3:45                   ` [Buildroot] [PATCH v2] " James Balean
2017-04-05 20:30                     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490663989-14886-1-git-send-email-james@balean.com.au \
    --to=james@balean.com.au \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.