From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Remove extra fdt_fixup_ethernet() call
Date: Mon, 3 Apr 2017 07:03:22 +0000 [thread overview]
Message-ID: <1491203001.4177.77.camel@infinera.com> (raw)
In-Reply-To: <CAPnjgZ00RL1N6MtMKkrv0oXex4Ni7gvhq_fd1HnX17Yzh5_ZGQ@mail.gmail.com>
On Fri, 2017-03-31 at 22:21 -0600, Simon Glass wrote:
> Hi Joakim,
>
> On 23 March 2017 at 11:02, Joakim Tjernlund
> <joakim.tjernlund@infinera.com> wrote:
> > ft_cpu_setup() already calls fdt_fixup_ethernet(), calling it
> > in image_setup_libfdt() is both redundant and breaks any modifications
> > done by ft_board_setup(). Restore the old behavior by removing
> > the call in image_setup_libfdt()
>
> Which old behaviour? Can you please add a Fixes: tag with the details?
The feature of having the possibility to rewrite the dev trees MAC addresses in
ft_board_setup(). Currently such rewrites are overwritten by the call to dt_fixup_ethernet(blob)
in image_setup_libfdt().
Looking into the history I see that commit 13d06981(by you as it happens :) is the one adding
the extra call to fdt_fixup_ethernet()
>
> Also, which ft_cpu_setup()?
# > git grep fdt_fixup_ethernet
arch/arm/cpu/armv7/ls102xa/fdt.c: fdt_fixup_ethernet(blob);
arch/mips/lib/bootm.c: fdt_fixup_ethernet(images->ft_addr);
arch/nios2/cpu/fdt.c: fdt_fixup_ethernet(blob);
arch/powerpc/cpu/mpc512x/cpu.c: fdt_fixup_ethernet(blob);
arch/powerpc/cpu/mpc8260/cpu.c: fdt_fixup_ethernet(blob);
arch/powerpc/cpu/mpc83xx/fdt.c: fdt_fixup_ethernet(blob);
arch/powerpc/cpu/mpc85xx/fdt.c: fdt_fixup_ethernet(blob);
arch/powerpc/cpu/mpc86xx/fdt.c: fdt_fixup_ethernet(blob);
arch/powerpc/cpu/mpc8xx/fdt.c: fdt_fixup_ethernet(blob);
arch/powerpc/cpu/ppc4xx/fdt.c: fdt_fixup_ethernet(blob);
Seems like it is mostly PPC which has fdt_fixup_ethernet() call though.
Jocke
>
> >
> > Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> > ---
> > common/image-fdt.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/common/image-fdt.c b/common/image-fdt.c
> > index 80e3e63..b8f5654 100644
> > --- a/common/image-fdt.c
> > +++ b/common/image-fdt.c
> > @@ -498,7 +498,6 @@ int image_setup_libfdt(bootm_headers_t *images, void *blob,
> > goto err;
> > }
> > }
> > - fdt_fixup_ethernet(blob);
> >
> > /* Delete the old LMB reservation */
> > lmb_free(lmb, (phys_addr_t)(u32)(uintptr_t)blob,
> > --
> > 2.10.2
> >
>
> Regards,
> Simon
next prev parent reply other threads:[~2017-04-03 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 17:02 [U-Boot] [PATCH] Remove extra fdt_fixup_ethernet() call Joakim Tjernlund
2017-03-28 17:47 ` Joakim Tjernlund
2017-04-01 4:21 ` Simon Glass
2017-04-03 7:03 ` Joakim Tjernlund [this message]
2017-04-28 7:27 ` Chen-Yu Tsai
2017-04-09 1:14 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491203001.4177.77.camel@infinera.com \
--to=joakim.tjernlund@infinera.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.