From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"ming.lei@redhat.com" <ming.lei@redhat.com>
Subject: Re: [PATCH v2 4/8] blk-mq: fix blk_mq_quiesce_queue
Date: Sat, 27 May 2017 21:46:45 +0000 [thread overview]
Message-ID: <1495921605.13651.2.camel@sandisk.com> (raw)
In-Reply-To: <20170527142126.26079-5-ming.lei@redhat.com>
T24gU2F0LCAyMDE3LTA1LTI3IGF0IDIyOjIxICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gSXQg
aXMgcmVxdWlyZWQgdGhhdCBubyBkaXNwYXRjaCBjYW4gaGFwcGVuIGFueSBtb3JlIG9uY2UNCj4g
YmxrX21xX3F1aWVzY2VfcXVldWUoKSByZXR1cm5zLCBhbmQgd2UgZG9uJ3QgaGF2ZSBzdWNoIHJl
cXVpcmVtZW50DQo+IG9uIEFQSXMgb2Ygc3RvcHBpbmcgcXVldWUuDQo+IA0KPiBCdXQgYmxrX21x
X3F1aWVzY2VfcXVldWUoKSBzdGlsbCBtYXkgbm90IGJsb2NrL2RyYWluIGRpc3BhdGNoIGluIHRo
ZQ0KPiBmb2xsb3dpbmcgY2FzZXM6DQo+IA0KPiAtIGRpcmVjdCBpc3N1ZSBvciBCTEtfTVFfU19T
VEFSVF9PTl9SVU4NCj4gLSBpbiB0aGVvcnksIG5ldyBSQ1UgcmVhZC1zaWRlIGNyaXRpY2FsIHNl
Y3Rpb25zIG1heSBiZWdpbiB3aGlsZQ0KPiBzeW5jaHJvbml6ZV9yY3UoKSB3YXMgd2FpdGluZywg
YW5kIGVuZCBhZnRlciBzeW5jaHJvbml6ZV9yY3UoKQ0KPiByZXR1cm5zLCBkdXJpbmcgdGhlIHBl
cmlvZCBkaXNwYXRjaCBzdGlsbCBtYXkgaGFwcGVuDQoNCkhlbGxvIE1pbmcsDQoNCkkgdGhpbmsg
dGhlIHRpdGxlIGFuZCB0aGUgZGVzY3JpcHRpb24gb2YgdGhpcyBwYXRjaCBhcmUgd3JvbmcuIFNp
bmNlDQp0aGUgY3VycmVudCBxdWV1ZSBxdWllc2NpbmcgbWVjaGFuaXNtIHdvcmtzIGZpbmUgZm9y
IGRyaXZlcnMgdGhhdCBkbw0Kbm90IHN0b3AgYW5kIHJlc3RhcnQgYSBxdWV1ZSAoZS5nLiBTQ1NJ
IGFuZCBkbS1jb3JlKSwgcGxlYXNlIGNoYW5nZSB0aGUNCnRpdGxlIGFuZCBkZXNjcmlwdGlvbiB0
byByZWZsZWN0IHRoYXQgdGhlIHB1cnBvc2Ugb2YgdGhpcyBwYXRjaCBpcw0KdG8gYWxsb3cgZHJp
dmVycyB0aGF0IHVzZSB0aGUgcXVpZXNjZSBtZWNoYW5pc20gdG8gcmVzdGFydCBhIHF1ZXVlDQp3
aXRob3V0IHVucXVpZXNjaW5nIGl0Lg0KDQo+IEBAIC0yMDksNiArMjE3LDkgQEAgdm9pZCBibGtf
bXFfd2FrZV93YWl0ZXJzKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxKQ0KPiAgCSAqIHRoZSBxdWV1
ZSBhcmUgbm90aWZpZWQgYXMgd2VsbC4NCj4gIAkgKi8NCj4gIAl3YWtlX3VwX2FsbCgmcS0+bXFf
ZnJlZXplX3dxKTsNCj4gKw0KPiArCS8qIEZvcmNpYmx5IHVucXVpZXNjZSB0aGUgcXVldWUgdG8g
YXZvaWQgaGF2aW5nIHN0dWNrIHJlcXVlc3RzICovDQo+ICsJYmxrX21xX3VucXVpZXNjZV9xdWV1
ZShxKTsNCj4gIH0NCg0KU2hvdWxkIHRoZSBibG9jayBsYXllciB1bnF1aWVzY2UgYSBxdWV1ZSBp
ZiBhIGJsb2NrIGRyaXZlciBoYXNuJ3QgDQpkb25lIHRoYXQgYmVmb3JlIHF1ZXVlIHJlbW92YWwg
c3RhcnRzIG9yIHNob3VsZCB0aGUgYmxvY2sgZHJpdmVyDQppdHNlbGYgZG8gdGhhdD8gVGhlIGJs
b2NrIGxheWVyIGRvZXNuJ3QgcmVzdGFydCBzdG9wcGVkIHF1ZXVlcyBmcm9tDQppbnNpZGUgYmxr
X3NldF9xdWV1ZV9keWluZygpIHNvIHdoeSBzaG91bGQgaXQgdW5xdWllc2NlIGEgcXVpZXNjZWQN
CnF1ZXVlPw0KIA0KPiAgYm9vbCBibGtfbXFfY2FuX3F1ZXVlKHN0cnVjdCBibGtfbXFfaHdfY3R4
ICpoY3R4KQ0KPiBAQCAtMTEwOCwxMyArMTExOSwxNSBAQCBzdGF0aWMgdm9pZCBfX2Jsa19tcV9y
dW5faHdfcXVldWUoc3RydWN0IGJsa19tcV9od19jdHggKmhjdHgpDQo+ICANCj4gIAlpZiAoISho
Y3R4LT5mbGFncyAmIEJMS19NUV9GX0JMT0NLSU5HKSkgew0KPiAgCQlyY3VfcmVhZF9sb2NrKCk7
DQo+IC0JCWJsa19tcV9zY2hlZF9kaXNwYXRjaF9yZXF1ZXN0cyhoY3R4KTsNCj4gKwkJaWYgKCFi
bGtfcXVldWVfcXVpZXNjZWQoaGN0eC0+cXVldWUpKQ0KPiArCQkJYmxrX21xX3NjaGVkX2Rpc3Bh
dGNoX3JlcXVlc3RzKGhjdHgpOw0KPiAgCQlyY3VfcmVhZF91bmxvY2soKTsNCj4gIAl9IGVsc2Ug
ew0KPiAgCQltaWdodF9zbGVlcCgpOw0KPiAgDQo+ICAJCXNyY3VfaWR4ID0gc3JjdV9yZWFkX2xv
Y2soJmhjdHgtPnF1ZXVlX3JxX3NyY3UpOw0KPiAtCQlibGtfbXFfc2NoZWRfZGlzcGF0Y2hfcmVx
dWVzdHMoaGN0eCk7DQo+ICsJCWlmICghYmxrX3F1ZXVlX3F1aWVzY2VkKGhjdHgtPnF1ZXVlKSkN
Cj4gKwkJCWJsa19tcV9zY2hlZF9kaXNwYXRjaF9yZXF1ZXN0cyhoY3R4KTsNCj4gIAkJc3JjdV9y
ZWFkX3VubG9jaygmaGN0eC0+cXVldWVfcnFfc3JjdSwgc3JjdV9pZHgpOw0KPiAgCX0NCj4gIH0N
Cg0KU29ycnkgYnV0IEkgZG9uJ3QgbGlrZSB0aGVzZSBjaGFuZ2VzLiBXaHkgaGF2ZSB0aGUgYmxr
X3F1ZXVlX3F1aWVzY2VkKCkNCmNhbGxzIGJlIGFkZGVkIGF0IG90aGVyIGNvZGUgbG9jYXRpb25z
IHRoYW4gdGhlIGJsa19tcV9oY3R4X3N0b3BwZWQoKSBjYWxscz8NClRoaXMgd2lsbCBtYWtlIHRo
ZSBibG9jayBsYXllciB1bm5lY2Vzc2FyeSBoYXJkIHRvIG1haW50YWluLiBQbGVhc2UgY29uc2lk
ZXINCnRvIGNoYW5nZSB0aGUgYmxrX21xX2hjdHhfc3RvcHBlZChoY3R4KSBjYWxscyBpbiBibGtf
bXFfc2NoZWRfZGlzcGF0Y2hfcmVxdWVzdHMoKQ0KYW5kICpibGtfbXFfKnJ1bl9od19xdWV1ZSoo
KSBpbnRvIGJsa19tcV9oY3R4X3N0b3BwZWQoaGN0eCkgfHwgYmxrX3F1ZXVlX3F1aWVzY2VkKHEp
Lg0KDQpUaGFua3MsDQoNCkJhcnQu
next prev parent reply other threads:[~2017-05-27 21:46 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 14:21 [PATCH v2 0/8] blk-mq: fix & improve queue quiescing Ming Lei
2017-05-27 14:21 ` [PATCH v2 1/8] blk-mq: introduce blk_mq_unquiesce_queue Ming Lei
2017-05-30 15:09 ` Bart Van Assche
2017-05-27 14:21 ` [PATCH v2 2/8] block: introduce flag of QUEUE_FLAG_QUIESCED Ming Lei
2017-05-30 15:11 ` Bart Van Assche
2017-05-27 14:21 ` [PATCH v2 3/8] blk-mq: use the introduced blk_mq_unquiesce_queue() Ming Lei
2017-05-27 14:21 ` Ming Lei
2017-05-30 15:12 ` Bart Van Assche
2017-05-30 15:12 ` Bart Van Assche
2017-05-30 15:12 ` Bart Van Assche
2017-05-31 2:29 ` Ming Lei
2017-05-31 2:29 ` Ming Lei
2017-05-30 19:04 ` Eduardo Valentin
2017-05-30 19:04 ` Eduardo Valentin
2017-05-30 19:04 ` Eduardo Valentin
2017-05-31 2:28 ` Ming Lei
2017-05-31 2:28 ` Ming Lei
2017-05-27 14:21 ` [PATCH v2 4/8] blk-mq: fix blk_mq_quiesce_queue Ming Lei
2017-05-27 21:46 ` Bart Van Assche [this message]
2017-05-28 10:44 ` Ming Lei
2017-05-28 16:10 ` Bart Van Assche
2017-05-30 0:22 ` Ming Lei
2017-05-30 16:54 ` Bart Van Assche
2017-05-31 2:38 ` Ming Lei
2017-05-30 19:23 ` Bart Van Assche
2017-05-31 2:52 ` Ming Lei
2017-05-27 14:21 ` [PATCH v2 5/8] blk-mq: update comments on blk_mq_quiesce_queue() Ming Lei
2017-05-30 17:14 ` Bart Van Assche
2017-05-31 9:51 ` Ming Lei
2017-05-27 14:21 ` [PATCH v2 6/8] blk-mq: don't stop queue for quiescing Ming Lei
2017-05-27 21:49 ` Bart Van Assche
2017-05-28 10:50 ` Ming Lei
2017-05-28 16:03 ` Bart Van Assche
2017-05-30 0:27 ` Ming Lei
2017-05-30 17:02 ` Bart Van Assche
2017-05-31 2:55 ` Ming Lei
2017-05-27 14:21 ` [PATCH v2 7/8] blk-mq: clarify dispatch may not be drained/blocked by stopping queue Ming Lei
2017-05-27 14:21 ` [PATCH v2 8/8] Revert "blk-mq: don't use sync workqueue flushing from drivers" Ming Lei
2017-05-27 21:32 ` [PATCH v2 0/8] blk-mq: fix & improve queue quiescing Bart Van Assche
2017-05-28 11:11 ` Ming Lei
2017-05-28 16:01 ` Bart Van Assche
2017-05-30 0:34 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495921605.13651.2.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.