From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Chris Wilson In-Reply-To: <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> References: <1502849538-14284-1-git-send-email-chrism@mellanox.com> <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> Message-ID: <150287519355.15499.3124883464555211520@mail.alporthouse.com> Subject: Re: [patch net-next 0/3] net/sched: Improve getting objects by indexes Date: Wed, 16 Aug 2017 10:19:53 +0100 To: =?utf-8?q?Christian_K=C3=B6nig?= , Chris Mi , netdev@vger.kernel.org Cc: aditr@vmware.com, stern@rowland.harvard.edu, agk@redhat.com, alexander.shishkin@linux.intel.com, alexandre.bounine@idt.com, alexander.deucher@amd.com, oakad@yahoo.com, ast@kernel.org, elder@kernel.org, adobriyan@gmail.com, alex.williamson@redhat.com, AlexBin.Xie@amd.com, viro@zeniv.linux.org.uk, amd-gfx@lists.freedesktop.org, amitkarwar@gmail.com, andresx7@gmail.com, andrew.donnellan@au1.ibm.com, afd@ti.com, akpm@linux-foundation.org, anil.gurumurthy@qlogic.com, anna.schumaker@netapp.com, acme@kernel.org, arnd@arndb.de, dedekind1@gmail.com, ashutosh.dixit@intel.com, ath10k@lists.infradead.org, Bart.VanAssche@sandisk.com, bhaktipriya96@gmail.com, bjorn.andersson@linaro.org, boris.brezillon@free-electrons.com, computersforpeace@gmail.com, bryan.thompson@unisys.com, cgroups@vger.kernel.org, 3chas3@gmail.com, ccaulfie@redhat.com, david1.zhou@amd.com, cluster-devel@redhat.com, colin.king@canonical.com, xiyou.wangcong@gmail.com, cyrille.pitchen@wedev4u.fr, daniel@iogearbox.net, daniel.vetter@intel.com, dasaratharaman.chandramouli@intel.com, airlied@redhat.com, dsa@cumulusnetworks.com, airlied@linux.ie, david.binder@unisys.com, dhowells@redhat.com, david.kershner@unisys.com, dtwlin@gmail.com, dave@stgolabs.net, davem@davemloft.net, teigland@redhat.com, dwindsor@gmail.com, dwmw2@infradead.org, dennis.dalessandro@intel.com, devel@driverdev.osuosl.org, devesh.sharma@broadcom.com, devicetree@vger.kernel.org, dick.kennedy@broadcom.com, dm-devel@redhat.com, don.hiatt@intel.com, dgilbert@interlog.com, dledford@redhat.com, drbd-dev@lists.linbit.com, dri-devel@lists.freedesktop.org, elena.reshetova@intel.com, edumazet@google.com, eparis@parisplace.org, ericvh@gmail.com, ebiederm@xmission.com, evan.quan@amd.com, felipe.balbi@linux.intel.com, Felix.Kuehling@amd.com, f.fainelli@gmail.com, fw@strlen.de, frowand.list@gmail.com, fbarrat@linux.vnet.ibm.com, fujita.tomonori@lab.ntt.co.jp, gbhat@marvell.com, geliangtang@gmail.com, kraxel@redhat.com, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux@roeck-us.net, gustavo.padovan@collabora.co.uk, hal.rosenstock@gmail.com, hannes@stressinduktion.org, hare@suse.de, ishkamiel@gmail.com, hans.westgaard.ry@oracle.com, ray.huang@amd.com, mingo@redhat.com, inki.dae@samsung.com, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, iommu@lists.linux-foundation.org, ira.weiny@intel.com, jinpu.wang@profitbricks.com, jhs@mojatatu.com, jejb@linux.vnet.ibm.com, james.smart@broadcom.com, jani.nikula@linux.intel.com, jack@suse.cz, jarkko.sakkinen@linux.intel.com, jarno@ovn.org, Jason@zx2c4.com, jgunthorpe@obsidianresearch.com, jasowang@redhat.com, javier@osg.samsung.com, bfields@fieldses.org, jlayton@poochiereds.net, axboe@kernel.dk, jens.wiklander@linaro.org, jiangyilism@gmail.com, jiri@mellanox.com, jiri@resnulli.us, jlbec@evilplan.org, joro@8bytes.org, johan@kernel.org, johannes@sipsolutions.net, hannes@cmpxchg.org, john@johnmccutchan.com, jonathanh@nvidia.com, jon.maloy@ericsson.com, joonas.lahtinen@linux.intel.com, jy0922.shim@samsung.com, jbacik@fb.com, Jerry.Zhang@amd.com, jsarha@ti.com, Kai.Makisara@kolumbus.fi, kvalo@qca.qualcomm.com, keescook@chromium.org, krzk@kernel.org, kgene@kernel.org, kvm@vger.kernel.org, kyungmin.park@samsung.com, jiangshanlai@gmail.com, lars.ellenberg@linbit.com, lucho@ionkov.net, lee.jones@linaro.org, leo.liu@amd.com, leon@kernel.org, linux1394-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-atm-general@lists.sourceforge.net, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ppp@vger.kernel.org, linux-raid@vger.kernel.org, linux-rdma@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, logang@deltatee.com, majd@mellanox.com, manfred@colorfullife.com, tpmdd@selhorst.net, marcos.souza.org@gmail.com, marek.vasut@gmail.com, mario.kleiner.de@gmail.com, markb@mellanox.com, mfasheh@versity.com, elfring@users.sourceforge.net, martin.petersen@oracle.com, matan@mellanox.com, mawilcox@microsoft.com, mporter@kernel.crashing.org, mchehab@kernel.org, maximlevitsky@gmail.com, mst@redhat.com, mhocko@kernel.org, michel.daenzer@amd.com, mike.marciniszyn@intel.com, rppt@linux.vnet.ibm.com, snitzer@redhat.com, mszeredi@redhat.com, minchan@kernel.org, tom.leiming@gmail.com, monis@mellanox.com, Monk.Liu@amd.com, nbd-general@lists.sourceforge.net, neilb@suse.com, nhorman@tuxdriver.com, nab@linux-iscsi.org, nicolai.haehnle@amd.com, nicolas.dichtel@6wind.com, niranjana.vishwanathapura@intel.com, nishants@marvell.com, ngupta@vflare.org, ocfs2-devel@oss.oracle.com, ohad@wizery.com, oneukum@suse.com, osandov@fb.com, ogerlitz@mellanox.com, pali.rohar@gmail.com, pantelis.antoniou@konsulko.com, paulus@samba.org, paul@paul-moore.com, peterhuewe@gmx.de, peterz@infradead.org, pmladek@suse.com, philipp.reisner@linbit.com, pshelar@ovn.org, rjw@rjwysocki.net, richard@nod.at, rlove@rlove.org, robh+dt@kernel.org, giometti@enneenne.com, rogerq@ti.com, roman.kapl@sysgo.com, rminnich@sandia.gov, rmk+kernel@armlinux.org.uk, sainath.grandhi@intel.com, sameer.wadgaonkar@unisys.com, sean.hefty@intel.com, seanpaul@chromium.org, bigeasy@linutronix.de, sre@kernel.org, nsekhar@ti.com, selvin.xavier@broadcom.com, sergey.senozhatsky.work@gmail.com, sw0312.kim@samsung.com, p.shailesh@samsung.com, shli@kernel.org, shaun.tancheff@seagate.com, syeh@vmware.com, sparmaintainer@unisys.com, stefanr@s5r6.in-berlin.de, sboyd@codeaurora.org, stephen@networkplumber.org, swise@chelsio.com, sudarsana.kalluru@qlogic.com, sudeep.dutt@intel.com, sumit.semwal@linaro.org, target-devel@vger.kernel.org, tj@kernel.org, thierry.reding@gmail.com, thellstrom@vmware.com, timothy.sell@unisys.com, tipc-discussion@lists.sourceforge.net, tomas.winkler@intel.com, tomi.valkeinen@ti.com, tpmdd-devel@lists.sourceforge.net, trond.myklebust@primarydata.com, v9fs-developer@lists.sourceforge.net, varun@chelsio.com, virtualization@lists.linux-foundation.org, vdavydov.dev@gmail.com, vyasevich@gmail.com, linux-graphics-maintainer@vmware.com, longman@redhat.com, weiyj.lk@gmail.com, wsa@the-dreams.de, huxm@marvell.com, ying.xue@windriver.com, yishaih@mellanox.com, yuval.shaia@oracle.com, lizefan@huawei.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com List-ID: Quoting Christian K=C3=B6nig (2017-08-16 08:49:07) > Am 16.08.2017 um 04:12 schrieb Chris Mi: > > Using current TC code, it is very slow to insert a lot of rules. > > > > In order to improve the rules update rate in TC, > > we introduced the following two changes: > > 1) changed cls_flower to use IDR to manage the filters. > > 2) changed all act_xxx modules to use IDR instead of > > a small hash table > > > > But IDR has a limitation that it uses int. TC handle uses u32. > > To make sure there is no regression, we also changed IDR to use > > unsigned long. All clients of IDR are changed to use new IDR API. > = > WOW, wait a second. The idr change is touching a lot of drivers and to = > be honest doesn't looks correct at all. > = > Just look at the first chunk of your modification: > > @@ -998,8 +999,9 @@ int bsg_register_queue(struct request_queue *q, str= uct device *parent, > > = > > mutex_lock(&bsg_mutex); > > = > > - ret =3D idr_alloc(&bsg_minor_idr, bcd, 0, BSG_MAX_DEVS, GFP_KERNE= L); > > - if (ret < 0) { > > + ret =3D idr_alloc(&bsg_minor_idr, bcd, &idr_index, 0, BSG_MAX_DEV= S, > > + GFP_KERNEL); > > + if (ret) { > > if (ret =3D=3D -ENOSPC) { > > printk(KERN_ERR "bsg: too many bsg devices\n"); > > ret =3D -EINVAL; > The condition "if (ret)" will now always be true after the first = > allocation and so we always run into the error handling after that. ret is now purely the error code, so it doesn't look that suspicious. > I've never read the bsg code before, but that's certainly not correct. = > And that incorrect pattern repeats over and over again in this code. > = > Apart from that why the heck do you want to allocate more than 1<<31 = > handles? And more to the point, arbitrarily changing the maximum to ULONG_MAX where the ABI only supports U32_MAX is dangerous. Unless you do the analysis otherwise, you have to replace all the end=3D0 with end=3DINT_MAX to maintain existing behaviour. -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [patch net-next 0/3] net/sched: Improve getting objects by indexes Date: Wed, 16 Aug 2017 10:19:53 +0100 Message-ID: <150287519355.15499.3124883464555211520@mail.alporthouse.com> References: <1502849538-14284-1-git-send-email-chrism@mellanox.com> <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+gldad-ath10k=m.gmane.org@lists.infradead.org To: =?utf-8?q?Christian_K=C3=B6nig?= , Chris Mi , netdev@vger.kernel.org Cc: lucho@ionkov.net, sergey.senozhatsky.work@gmail.com, snitzer@redhat.com, wsa@the-dreams.de, markb@mellanox.com, tom.leiming@gmail.com, stefanr@s5r6.in-berlin.de, zhi.a.wang@intel.com, nsekhar@ti.com, dri-devel@lists.freedesktop.org, bfields@fieldses.org, linux-sctp@vger.kernel.org, paulus@samba.org, jinpu.wang@profitbricks.com, pshelar@ovn.org, sumit.semwal@linaro.org, AlexBin.Xie@amd.com, david1.zhou@amd.com, linux-samsung-soc@vger.kernel.org, maximlevitsky@gmail.com, sudarsana.kalluru@qlogic.com, marek.vasut@gmail.com, linux-atm-general@lists.sourceforge.net, dtwlin@gmail.com, michel.daenzer@amd.com, dledford@redhat.com, tpmdd-devel@lists.sourceforge.net, stern@rowland.harvard.edu, longman@redhat.com, niranjana.vishwanathapura@intel.com, philipp.reisner@linbit.com, shli@kernel.org, linux@roeck-us.net, ohad@wizery.com, pmladek@suse.com, dick.kennedy@broadcom.comlinux- List-Id: linux-raid.ids UXVvdGluZyBDaHJpc3RpYW4gS8O2bmlnICgyMDE3LTA4LTE2IDA4OjQ5OjA3KQo+IEFtIDE2LjA4 LjIwMTcgdW0gMDQ6MTIgc2NocmllYiBDaHJpcyBNaToKPiA+IFVzaW5nIGN1cnJlbnQgVEMgY29k ZSwgaXQgaXMgdmVyeSBzbG93IHRvIGluc2VydCBhIGxvdCBvZiBydWxlcy4KPiA+Cj4gPiBJbiBv cmRlciB0byBpbXByb3ZlIHRoZSBydWxlcyB1cGRhdGUgcmF0ZSBpbiBUQywKPiA+IHdlIGludHJv ZHVjZWQgdGhlIGZvbGxvd2luZyB0d28gY2hhbmdlczoKPiA+ICAgICAgICAgIDEpIGNoYW5nZWQg Y2xzX2Zsb3dlciB0byB1c2UgSURSIHRvIG1hbmFnZSB0aGUgZmlsdGVycy4KPiA+ICAgICAgICAg IDIpIGNoYW5nZWQgYWxsIGFjdF94eHggbW9kdWxlcyB0byB1c2UgSURSIGluc3RlYWQgb2YKPiA+ ICAgICAgICAgICAgIGEgc21hbGwgaGFzaCB0YWJsZQo+ID4KPiA+IEJ1dCBJRFIgaGFzIGEgbGlt aXRhdGlvbiB0aGF0IGl0IHVzZXMgaW50LiBUQyBoYW5kbGUgdXNlcyB1MzIuCj4gPiBUbyBtYWtl IHN1cmUgdGhlcmUgaXMgbm8gcmVncmVzc2lvbiwgd2UgYWxzbyBjaGFuZ2VkIElEUiB0byB1c2UK PiA+IHVuc2lnbmVkIGxvbmcuIEFsbCBjbGllbnRzIG9mIElEUiBhcmUgY2hhbmdlZCB0byB1c2Ug bmV3IElEUiBBUEkuCj4gCj4gV09XLCB3YWl0IGEgc2Vjb25kLiBUaGUgaWRyIGNoYW5nZSBpcyB0 b3VjaGluZyBhIGxvdCBvZiBkcml2ZXJzIGFuZCB0byAKPiBiZSBob25lc3QgZG9lc24ndCBsb29r cyBjb3JyZWN0IGF0IGFsbC4KPiAKPiBKdXN0IGxvb2sgYXQgdGhlIGZpcnN0IGNodW5rIG9mIHlv dXIgbW9kaWZpY2F0aW9uOgo+ID4gQEAgLTk5OCw4ICs5OTksOSBAQCBpbnQgYnNnX3JlZ2lzdGVy X3F1ZXVlKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxLCBzdHJ1Y3QgZGV2aWNlICpwYXJlbnQsCj4g PiAgIAo+ID4gICAgICAgbXV0ZXhfbG9jaygmYnNnX211dGV4KTsKPiA+ICAgCj4gPiAtICAgICBy ZXQgPSBpZHJfYWxsb2MoJmJzZ19taW5vcl9pZHIsIGJjZCwgMCwgQlNHX01BWF9ERVZTLCBHRlBf S0VSTkVMKTsKPiA+IC0gICAgIGlmIChyZXQgPCAwKSB7Cj4gPiArICAgICByZXQgPSBpZHJfYWxs b2MoJmJzZ19taW5vcl9pZHIsIGJjZCwgJmlkcl9pbmRleCwgMCwgQlNHX01BWF9ERVZTLAo+ID4g KyAgICAgICAgICAgICAgICAgICAgIEdGUF9LRVJORUwpOwo+ID4gKyAgICAgaWYgKHJldCkgewo+ ID4gICAgICAgICAgICAgICBpZiAocmV0ID09IC1FTk9TUEMpIHsKPiA+ICAgICAgICAgICAgICAg ICAgICAgICBwcmludGsoS0VSTl9FUlIgImJzZzogdG9vIG1hbnkgYnNnIGRldmljZXNcbiIpOwo+ ID4gICAgICAgICAgICAgICAgICAgICAgIHJldCA9IC1FSU5WQUw7Cj4gVGhlIGNvbmRpdGlvbiAi aWYgKHJldCkiIHdpbGwgbm93IGFsd2F5cyBiZSB0cnVlIGFmdGVyIHRoZSBmaXJzdCAKPiBhbGxv Y2F0aW9uIGFuZCBzbyB3ZSBhbHdheXMgcnVuIGludG8gdGhlIGVycm9yIGhhbmRsaW5nIGFmdGVy IHRoYXQuCgpyZXQgaXMgbm93IHB1cmVseSB0aGUgZXJyb3IgY29kZSwgc28gaXQgZG9lc24ndCBs b29rIHRoYXQgc3VzcGljaW91cy4KCj4gSSd2ZSBuZXZlciByZWFkIHRoZSBic2cgY29kZSBiZWZv cmUsIGJ1dCB0aGF0J3MgY2VydGFpbmx5IG5vdCBjb3JyZWN0LiAKPiBBbmQgdGhhdCBpbmNvcnJl Y3QgcGF0dGVybiByZXBlYXRzIG92ZXIgYW5kIG92ZXIgYWdhaW4gaW4gdGhpcyBjb2RlLgo+IAo+ IEFwYXJ0IGZyb20gdGhhdCB3aHkgdGhlIGhlY2sgZG8geW91IHdhbnQgdG8gYWxsb2NhdGUgbW9y ZSB0aGFuIDE8PDMxIAo+IGhhbmRsZXM/CgpBbmQgbW9yZSB0byB0aGUgcG9pbnQsIGFyYml0cmFy aWx5IGNoYW5naW5nIHRoZSBtYXhpbXVtIHRvIFVMT05HX01BWAp3aGVyZSB0aGUgQUJJIG9ubHkg c3VwcG9ydHMgVTMyX01BWCBpcyBkYW5nZXJvdXMuIFVubGVzcyB5b3UgZG8gdGhlCmFuYWx5c2lz IG90aGVyd2lzZSwgeW91IGhhdmUgdG8gcmVwbGFjZSBhbGwgdGhlIGVuZD0wIHdpdGggZW5kPUlO VF9NQVgKdG8gbWFpbnRhaW4gZXhpc3RpbmcgYmVoYXZpb3VyLgotQ2hyaXMKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QK YXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 To: =?utf-8?q?Christian_K=C3=B6nig?= , "Chris Mi" , netdev@vger.kernel.org From: Chris Wilson In-Reply-To: <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> Cc: aditr@vmware.com, stern@rowland.harvard.edu, agk@redhat.com, alexander.shishkin@linux.intel.com, alexandre.bounine@idt.com, alexander.deucher@amd.com, oakad@yahoo.com, ast@kernel.org, elder@kernel.org, adobriyan@gmail.com, alex.williamson@redhat.com, AlexBin.Xie@amd.com, viro@zeniv.linux.org.uk, amd-gfx@lists.freedesktop.org, amitkarwar@gmail.com, andresx7@gmail.com, andrew.donnellan@au1.ibm.com, afd@ti.com, akpm@linux-foundation.org, anil.gurumurthy@qlogic.com, anna.schumaker@netapp.com, acme@kernel.org, arnd@arndb.de, dedekind1@gmail.com, ashutosh.dixit@intel.com, ath10k@lists.infradead.org, Bart.VanAssche@sandisk.com, bhaktipriya96@gmail.com, bjorn.andersson@linaro.org, boris.brezillon@free-electrons.com, computersforpeace@gmail.com, bryan.thompson@unisys.com, cgroups@vger.kernel.org, 3chas3@gmail.com, ccaulfie@redhat.com, david1.zhou@amd.com, cluster-devel@redhat.com, colin.king@canonical.com, xiyou.wangcong@gmail.com, cyrille.pitchen@wedev4u.fr, daniel@iogearbox.net, daniel.vetter@intel.com, dasaratharaman.chandramouli@intel.com, airlied@redhat.com, dsa@cumulusnetworks.com, airlied@linux.ie, david.binder@unisys.com, dhowells@redhat.com, david.kershner@unisys.com, dtwlin@gmail.com, dave@stgolabs.net, davem@davemloft.net, teigland@redhat.com, dwindsor@gmail.com, dwmw2@infradead.org, dennis.dalessandro@intel.com, devel@driverdev.osuosl.org, devesh.sharma@broadcom.com, devicetree@vger.kernel.org, dick.kennedy@broadcom.com, dm-devel@redhat.com, don.hiatt@intel.com, dgilbert@interlog.com, dledford@redhat.com, drbd-dev@lists.linbit.com, dri-devel@lists.freedesktop.org, elena.reshetova@intel.com, edumazet@google.com, eparis@parisplace.org, ericvh@gmail.com, ebiederm@xmission.com, evan.quan@amd.com, felipe.balbi@linux.intel.com, Felix.Kuehling@amd.com, f.fainelli@gmail.com, fw@strlen.de, frowand.list@gmail.com, fbarrat@linux.vnet.ibm.com, fujita.tomonori@lab.ntt.co.jp, gbhat@marvell.com, geliangtang@gmail.com, kraxel@redhat.com, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux@roeck-us.net, gustavo.padovan@collabora.co.uk, hal.rosenstock@gmail.com, hannes@stressinduktion.org, hare@suse.de, ishkamiel@gmail.com, hans.westgaard.ry@oracle.com, ray.huang@amd.com, mingo@redhat.com, inki.dae@samsung.com, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, iommu@lists.linux-foundation.org, ira.weiny@intel.com, jinpu.wang@profitbricks.com, jhs@mojatatu.com, jejb@linux.vnet.ibm.com, james.smart@broadcom.com, jani.nikula@linux.intel.com, jack@suse.cz, jarkko.sakkinen@linux.intel.com, jarno@ovn.org, Jason@zx2c4.com, jgunthorpe@obsidianresearch.com, jasowang@redhat.com, javier@osg.samsung.com, bfields@fieldses.org, jlayton@poochiereds.net, axboe@kernel.dk, jens.wiklander@linaro.org, jiangyilism@gmail.com, jiri@mellanox.com, jiri@resnulli.us, jlbec@evilplan.org, joro@8bytes.org, johan@kernel.org, johannes@sipsolutions.net, hannes@cmpxchg.org, john@johnmccutchan.com, jonathanh@nvidia.com, jon.maloy@ericsson.com, joonas.lahtinen@linux.intel.com, jy0922.shim@samsung.com, jbacik@fb.com, Jerry.Zhang@amd.com, jsarha@ti.com, Kai.Makisara@kolumbus.fi, kvalo@qca.qualcomm.com, keescook@chromium.org, krzk@kernel.org, kgene@kernel.org, kvm@vger.kernel.org, kyungmin.park@samsung.com, jiangshanlai@gmail.com, lars.ellenberg@linbit.com, lucho@ionkov.net, lee.jones@linaro.org, leo.liu@amd.com, leon@kernel.org, linux1394-devel@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-atm-general@lists.sourceforge.net, linux-block@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ppp@vger.kernel.org, linux-raid@vger.kernel.org, linux-rdma@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, logang@deltatee.com, majd@mellanox.com, manfred@colorfullife.com, tpmdd@selhorst.net, marcos.souza.org@gmail.com, marek.vasut@gmail.com, mario.kleiner.de@gmail.com, markb@mellanox.com, mfasheh@versity.com, elfring@users.sourceforge.net, martin.petersen@oracle.com, matan@mellanox.com, mawilcox@microsoft.com, mporter@kernel.crashing.org, mchehab@kernel.org, maximlevitsky@gmail.com, mst@redhat.com, mhocko@kernel.org, michel.daenzer@amd.com, mike.marciniszyn@intel.com, rppt@linux.vnet.ibm.com, snitzer@redhat.com, mszeredi@redhat.com, minchan@kernel.org, tom.leiming@gmail.com, monis@mellanox.com, Monk.Liu@amd.com, nbd-general@lists.sourceforge.net, neilb@suse.com, nhorman@tuxdriver.com, nab@linux-iscsi.org, nicolai.haehnle@amd.com, nicolas.dichtel@6wind.com, niranjana.vishwanathapura@intel.com, nishants@marvell.com, ngupta@vflare.org, ocfs2-devel@oss.oracle.com, ohad@wizery.com, oneukum@suse.com, osandov@fb.com, ogerlitz@mellanox.com, pali.rohar@gmail.com, pantelis.antoniou@konsulko.com, paulus@samba.org, paul@paul-moore.com, peterhuewe@gmx.de, peterz@infradead.org, pmladek@suse.com, philipp.reisner@linbit.com, pshelar@ovn.org, rjw@rjwysocki.net, richard@nod.at, rlove@rlove.org, robh+dt@kernel.org, giometti@enneenne.com, rogerq@ti.com, roman.kapl@sysgo.com, rminnich@sandia.gov, rmk+kernel@armlinux.org.uk, sainath.grandhi@intel.com, sameer.wadgaonkar@unisys.com, sean.hefty@intel.com, seanpaul@chromium.org, bigeasy@linutronix.de, sre@kernel.org, nsekhar@ti.com, selvin.xavier@broadcom.com, sergey.senozhatsky.work@gmail.com, sw0312.kim@samsung.com, p.shailesh@samsung.com, shli@kernel.org, shaun.tancheff@seagate.com, syeh@vmware.com, sparmaintainer@unisys.com, stefanr@s5r6.in-berlin.de, sboyd@codeaurora.org, stephen@networkplumber.org, swise@chelsio.com, sudarsana.kalluru@qlogic.com, sudeep.dutt@intel.com, sumit.semwal@linaro.org, target-devel@vger.kernel.org, tj@kernel.org, thierry.reding@gmail.com, thellstrom@vmware.com, timothy.sell@unisys.com, tipc-discussion@lists.sourceforge.net, tomas.winkler@intel.com, tomi.valkeinen@ti.com, tpmdd-devel@lists.sourceforge.net, trond.myklebust@primarydata.com, v9fs-developer@lists.sourceforge.net, varun@chelsio.com, virtualization@lists.linux-foundation.org, vdavydov.dev@gmail.com, vyasevich@gmail.com, linux-graphics-maintainer@vmware.com, longman@redhat.com, weiyj.lk@gmail.com, wsa@the-dreams.de, huxm@marvell.com, ying.xue@windriver.com, yishaih@mellanox.com, yuval.shaia@oracle.com, lizefan@huawei.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com References: <1502849538-14284-1-git-send-email-chrism@mellanox.com> <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> Message-ID: <150287519355.15499.3124883464555211520@mail.alporthouse.com> Subject: Re: [patch net-next 0/3] net/sched: Improve getting objects by indexes Date: Wed, 16 Aug 2017 10:19:53 +0100 List-ID: Quoting Christian K=C3=B6nig (2017-08-16 08:49:07) > Am 16.08.2017 um 04:12 schrieb Chris Mi: > > Using current TC code, it is very slow to insert a lot of rules. > > > > In order to improve the rules update rate in TC, > > we introduced the following two changes: > > 1) changed cls_flower to use IDR to manage the filters. > > 2) changed all act_xxx modules to use IDR instead of > > a small hash table > > > > But IDR has a limitation that it uses int. TC handle uses u32. > > To make sure there is no regression, we also changed IDR to use > > unsigned long. All clients of IDR are changed to use new IDR API. > = > WOW, wait a second. The idr change is touching a lot of drivers and to = > be honest doesn't looks correct at all. > = > Just look at the first chunk of your modification: > > @@ -998,8 +999,9 @@ int bsg_register_queue(struct request_queue *q, str= uct device *parent, > > = > > mutex_lock(&bsg_mutex); > > = > > - ret =3D idr_alloc(&bsg_minor_idr, bcd, 0, BSG_MAX_DEVS, GFP_KERNE= L); > > - if (ret < 0) { > > + ret =3D idr_alloc(&bsg_minor_idr, bcd, &idr_index, 0, BSG_MAX_DEV= S, > > + GFP_KERNEL); > > + if (ret) { > > if (ret =3D=3D -ENOSPC) { > > printk(KERN_ERR "bsg: too many bsg devices\n"); > > ret =3D -EINVAL; > The condition "if (ret)" will now always be true after the first = > allocation and so we always run into the error handling after that. ret is now purely the error code, so it doesn't look that suspicious. > I've never read the bsg code before, but that's certainly not correct. = > And that incorrect pattern repeats over and over again in this code. > = > Apart from that why the heck do you want to allocate more than 1<<31 = > handles? And more to the point, arbitrarily changing the maximum to ULONG_MAX where the ABI only supports U32_MAX is dangerous. Unless you do the analysis otherwise, you have to replace all the end=3D0 with end=3DINT_MAX to maintain existing behaviour. -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [patch net-next 0/3] net/sched: Improve getting objects by indexes Date: Wed, 16 Aug 2017 10:19:53 +0100 Message-ID: <150287519355.15499.3124883464555211520@mail.alporthouse.com> References: <1502849538-14284-1-git-send-email-chrism@mellanox.com> <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: lucho@ionkov.net, sergey.senozhatsky.work@gmail.com, snitzer@redhat.com, wsa@the-dreams.de, markb@mellanox.com, tom.leiming@gmail.com, stefanr@s5r6.in-berlin.de, zhi.a.wang@intel.com, nsekhar@ti.com, dri-devel@lists.freedesktop.org, bfields@fieldses.org, linux-sctp@vger.kernel.org, paulus@samba.org, jinpu.wang@profitbricks.com, pshelar@ovn.org, sumit.semwal@linaro.org, AlexBin.Xie@amd.com, david1.zhou@amd.com, linux-samsung-soc@vger.kernel.org, maximlevitsky@gmail.com, sudarsana.kalluru@qlogic.com, marek.vasut@gmail.com, linux-atm-general@lists.sourceforge.net, dtwlin@gmail.com, michel.daenzer@amd.com, dledford@redhat.com, tpmdd-devel@lists.sourceforge.net, stern@rowland.harvard.edu, longman@redhat.com, niranjana.vishwanathapura@intel.com, philipp.reisner@linbit.com, shli@kernel.org, linux@roeck-us.net, ohad@wizery.com, pmladek@suse.com, dick.kennedy@broadcom.com, linux- To: =?utf-8?q?Christian_K=C3=B6nig?= , "Chris Mi" , netdev@vger.kernel.org Return-path: In-Reply-To: <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+gldad-ath10k=m.gmane.org@lists.infradead.org List-Id: netdev.vger.kernel.org UXVvdGluZyBDaHJpc3RpYW4gS8O2bmlnICgyMDE3LTA4LTE2IDA4OjQ5OjA3KQo+IEFtIDE2LjA4 LjIwMTcgdW0gMDQ6MTIgc2NocmllYiBDaHJpcyBNaToKPiA+IFVzaW5nIGN1cnJlbnQgVEMgY29k ZSwgaXQgaXMgdmVyeSBzbG93IHRvIGluc2VydCBhIGxvdCBvZiBydWxlcy4KPiA+Cj4gPiBJbiBv cmRlciB0byBpbXByb3ZlIHRoZSBydWxlcyB1cGRhdGUgcmF0ZSBpbiBUQywKPiA+IHdlIGludHJv ZHVjZWQgdGhlIGZvbGxvd2luZyB0d28gY2hhbmdlczoKPiA+ICAgICAgICAgIDEpIGNoYW5nZWQg Y2xzX2Zsb3dlciB0byB1c2UgSURSIHRvIG1hbmFnZSB0aGUgZmlsdGVycy4KPiA+ICAgICAgICAg IDIpIGNoYW5nZWQgYWxsIGFjdF94eHggbW9kdWxlcyB0byB1c2UgSURSIGluc3RlYWQgb2YKPiA+ ICAgICAgICAgICAgIGEgc21hbGwgaGFzaCB0YWJsZQo+ID4KPiA+IEJ1dCBJRFIgaGFzIGEgbGlt aXRhdGlvbiB0aGF0IGl0IHVzZXMgaW50LiBUQyBoYW5kbGUgdXNlcyB1MzIuCj4gPiBUbyBtYWtl IHN1cmUgdGhlcmUgaXMgbm8gcmVncmVzc2lvbiwgd2UgYWxzbyBjaGFuZ2VkIElEUiB0byB1c2UK PiA+IHVuc2lnbmVkIGxvbmcuIEFsbCBjbGllbnRzIG9mIElEUiBhcmUgY2hhbmdlZCB0byB1c2Ug bmV3IElEUiBBUEkuCj4gCj4gV09XLCB3YWl0IGEgc2Vjb25kLiBUaGUgaWRyIGNoYW5nZSBpcyB0 b3VjaGluZyBhIGxvdCBvZiBkcml2ZXJzIGFuZCB0byAKPiBiZSBob25lc3QgZG9lc24ndCBsb29r cyBjb3JyZWN0IGF0IGFsbC4KPiAKPiBKdXN0IGxvb2sgYXQgdGhlIGZpcnN0IGNodW5rIG9mIHlv dXIgbW9kaWZpY2F0aW9uOgo+ID4gQEAgLTk5OCw4ICs5OTksOSBAQCBpbnQgYnNnX3JlZ2lzdGVy X3F1ZXVlKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxLCBzdHJ1Y3QgZGV2aWNlICpwYXJlbnQsCj4g PiAgIAo+ID4gICAgICAgbXV0ZXhfbG9jaygmYnNnX211dGV4KTsKPiA+ICAgCj4gPiAtICAgICBy ZXQgPSBpZHJfYWxsb2MoJmJzZ19taW5vcl9pZHIsIGJjZCwgMCwgQlNHX01BWF9ERVZTLCBHRlBf S0VSTkVMKTsKPiA+IC0gICAgIGlmIChyZXQgPCAwKSB7Cj4gPiArICAgICByZXQgPSBpZHJfYWxs b2MoJmJzZ19taW5vcl9pZHIsIGJjZCwgJmlkcl9pbmRleCwgMCwgQlNHX01BWF9ERVZTLAo+ID4g KyAgICAgICAgICAgICAgICAgICAgIEdGUF9LRVJORUwpOwo+ID4gKyAgICAgaWYgKHJldCkgewo+ ID4gICAgICAgICAgICAgICBpZiAocmV0ID09IC1FTk9TUEMpIHsKPiA+ICAgICAgICAgICAgICAg ICAgICAgICBwcmludGsoS0VSTl9FUlIgImJzZzogdG9vIG1hbnkgYnNnIGRldmljZXNcbiIpOwo+ ID4gICAgICAgICAgICAgICAgICAgICAgIHJldCA9IC1FSU5WQUw7Cj4gVGhlIGNvbmRpdGlvbiAi aWYgKHJldCkiIHdpbGwgbm93IGFsd2F5cyBiZSB0cnVlIGFmdGVyIHRoZSBmaXJzdCAKPiBhbGxv Y2F0aW9uIGFuZCBzbyB3ZSBhbHdheXMgcnVuIGludG8gdGhlIGVycm9yIGhhbmRsaW5nIGFmdGVy IHRoYXQuCgpyZXQgaXMgbm93IHB1cmVseSB0aGUgZXJyb3IgY29kZSwgc28gaXQgZG9lc24ndCBs b29rIHRoYXQgc3VzcGljaW91cy4KCj4gSSd2ZSBuZXZlciByZWFkIHRoZSBic2cgY29kZSBiZWZv cmUsIGJ1dCB0aGF0J3MgY2VydGFpbmx5IG5vdCBjb3JyZWN0LiAKPiBBbmQgdGhhdCBpbmNvcnJl Y3QgcGF0dGVybiByZXBlYXRzIG92ZXIgYW5kIG92ZXIgYWdhaW4gaW4gdGhpcyBjb2RlLgo+IAo+ IEFwYXJ0IGZyb20gdGhhdCB3aHkgdGhlIGhlY2sgZG8geW91IHdhbnQgdG8gYWxsb2NhdGUgbW9y ZSB0aGFuIDE8PDMxIAo+IGhhbmRsZXM/CgpBbmQgbW9yZSB0byB0aGUgcG9pbnQsIGFyYml0cmFy aWx5IGNoYW5naW5nIHRoZSBtYXhpbXVtIHRvIFVMT05HX01BWAp3aGVyZSB0aGUgQUJJIG9ubHkg c3VwcG9ydHMgVTMyX01BWCBpcyBkYW5nZXJvdXMuIFVubGVzcyB5b3UgZG8gdGhlCmFuYWx5c2lz IG90aGVyd2lzZSwgeW91IGhhdmUgdG8gcmVwbGFjZSBhbGwgdGhlIGVuZD0wIHdpdGggZW5kPUlO VF9NQVgKdG8gbWFpbnRhaW4gZXhpc3RpbmcgYmVoYXZpb3VyLgotQ2hyaXMKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QK YXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: MIME-Version: 1.0 From: Chris Wilson In-Reply-To: <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> References: <1502849538-14284-1-git-send-email-chrism@mellanox.com> <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> Message-ID: <150287519355.15499.3124883464555211520@mail.alporthouse.com> Subject: Re: [patch net-next 0/3] net/sched: Improve getting objects by indexes Date: Wed, 16 Aug 2017 10:19:53 +0100 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: =?utf-8?q?Christian_K=C3=B6nig?= , Chris Mi , netdev@vger.kernel.org Cc: lucho@ionkov.net, sergey.senozhatsky.work@gmail.com, snitzer@redhat.com, wsa@the-dreams.de, markb@mellanox.com, tom.leiming@gmail.com, stefanr@s5r6.in-berlin.de, zhi.a.wang@intel.com, nsekhar@ti.com, dri-devel@lists.freedesktop.org, bfields@fieldses.org, linux-sctp@vger.kernel.org, paulus@samba.org, jinpu.wang@profitbricks.com, pshelar@ovn.org, sumit.semwal@linaro.org, AlexBin.Xie@amd.com, david1.zhou@amd.com, linux-samsung-soc@vger.kernel.org, maximlevitsky@gmail.com, sudarsana.kalluru@qlogic.com, marek.vasut@gmail.com, linux-atm-general@lists.sourceforge.net, dtwlin@gmail.com, michel.daenzer@amd.com, dledford@redhat.com, tpmdd-devel@lists.sourceforge.net, stern@rowland.harvard.edu, longman@redhat.com, niranjana.vishwanathapura@intel.com, philipp.reisner@linbit.com, shli@kernel.org, linux@roeck-us.net, ohad@wizery.com, pmladek@suse.com, dick.kennedy@broadcom.com, linux-pm@vger.kernel.org, ericvh@gmail.com, geliangtang@gmail.com, sparmaintainer@unisys.com, giometti@enneenne.com, acme@kernel.org, inki.dae@samsung.com, alex.williamson@redhat.com, rppt@linux.vnet.ibm.com, teigland@redhat.com, viro@zeniv.linux.org.uk, ishkamiel@gmail.com, weiyj.lk@gmail.com, marcos.souza.org@gmail.com, mike.marciniszyn@intel.com, elder@kernel.org, nbd-general@lists.sourceforge.net, nhorman@tuxdriver.com, nicolai.haehnle@amd.com, david.binder@unisys.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, anil.gurumurthy@qlogic.com, linux-kernel@vger.kernel.org, varun@chelsio.com, majd@mellanox.com, devesh.sharma@broadcom.com, sameer.wadgaonkar@unisys.com, bhaktipriya96@gmail.com, alexander.deucher@amd.com, shaun.tancheff@seagate.com, akpm@linux-foundation.org, matan@mellanox.com, jlbec@evilplan.org, kraxel@redhat.com, Jason@zx2c4.com, timothy.sell@unisys.com, airlied@linux.ie, linux-wireless@vger.kernel.org, pantelis.antoniou@konsulko.com, sudeep.dutt@intel.com, neilb@suse.com, edumazet@google.com, target-devel@vger.kernel.org, linux-i2c@vger.kernel.org, daniel.vetter@intel.com, jsarha@ti.com, osandov@fb.com, agk@redhat.com, drbd-dev@lists.linbit.com, boris.brezillon@free-electrons.com, thellstrom@vmware.com, dave@stgolabs.net, paul@paul-moore.com, leon@kernel.org, sainath.grandhi@intel.com, gustavo.padovan@collabora.co.uk, james.smart@broadcom.com, jonathanh@nvidia.com, selvin.xavier@broadcom.com, kgene@kernel.org, linux-graphics-maintainer@vmware.com, andresx7@gmail.com, 3chas3@gmail.com, airlied@redhat.com, sean.hefty@intel.com, virtualization@lists.linux-foundation.org, hal.rosenstock@gmail.com, tj@kernel.org, mszeredi@redhat.com, hannes@stressinduktion.org, felipe.balbi@linux.intel.com, pali.rohar@gmail.com, tpmdd@selhorst.net, linuxppc-dev@lists.ozlabs.org, jani.nikula@linux.intel.com, greybus-dev@lists.linaro.org, nishants@marvell.com, swise@chelsio.com, yuval.shaia@oracle.com, xiyou.wangcong@gmail.com, evan.quan@amd.com, lars.ellenberg@linbit.com, linux-arm-kernel@lists.infradead.org, dwindsor@gmail.com, linux-raid@vger.kernel.org, syeh@vmware.com, bryan.thompson@unisys.com, Felix.Kuehling@amd.com, oneukum@suse.com, fw@strlen.de, anna.schumaker@netapp.com, minchan@kernel.org, kyungmin.park@samsung.com, monis@mellanox.com, ebiederm@xmission.com, sre@kernel.org, don.hiatt@intel.com, leo.liu@amd.com, jens.wiklander@linaro.org, hans.westgaard.ry@oracle.com, alexander.shishkin@linux.intel.com, dennis.dalessandro@intel.com, jasowang@redhat.com, joonas.lahtinen@linux.intel.com, jiangshanlai@gmail.com, ast@kernel.org, fbarrat@linux.vnet.ibm.com, mhocko@kernel.org, alexandre.bounine@idt.com, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, cgroups@vger.kernel.org, jlayton@poochiereds.net, frowand.list@gmail.com, elena.reshetova@intel.com, f.fainelli@gmail.com, jejb@linux.vnet.ibm.com, daniel@iogearbox.net, linux-rdma@vger.kernel.org, p.shailesh@samsung.com, ath10k@lists.infradead.org, jgunthorpe@obsidianresearch.com, ccaulfie@redhat.com, tomi.valkeinen@ti.com, Monk.Liu@amd.com, dgilbert@interlog.com, ira.weiny@intel.com, david.kershner@unisys.com, adobriyan@gmail.com, jon.maloy@ericsson.com, keescook@chromium.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, jhs@mojatatu.com, zhenyuw@linux.intel.com, v9fs-developer@lists.sourceforge.net, rmk+kernel@armlinux.org.uk, seanpaul@chromium.org, nab@linux-iscsi.org, Jerry.Zhang@amd.com, eparis@parisplace.org, nicolas.dichtel@6wind.com, Kai.Makisara@kolumbus.fi, mporter@kernel.crashing.org, rogerq@ti.com, linux-nfs@vger.kernel.org, martin.petersen@oracle.com, linux-ppp@vger.kernel.org, dm-devel@redhat.com, sw0312.kim@samsung.com, fujita.tomonori@lab.ntt.co.jp, iommu@lists.linux-foundation.org, roman.kapl@sysgo.com, ngupta@vflare.org, andrew.donnellan@au1.ibm.com, cyrille.pitchen@wedev4u.fr, ying.xue@windriver.com, colin.king@canonical.com, computersforpeace@gmail.com, logang@deltatee.com, davem@davemloft.net, ocfs2-devel@oss.oracle.com, rlove@rlove.org, jack@suse.cz, kvm@vger.kernel.org, mst@redhat.com, peterz@infradead.org, bigeasy@linutronix.de, trond.myklebust@primarydata.com, linux-remoteproc@vger.kernel.org, amitkarwar@gmail.com, bjorn.andersson@linaro.org, dhowells@redhat.com, linux-mm@kvack.org, ray.huang@amd.com, jiri@resnulli.us, peterhuewe@gmx.de, linux1394-devel@lists.sourceforge.net, lee.jones@linaro.org, john@johnmccutchan.com, devel@driverdev.osuosl.org, stephen@networkplumber.org, mario.kleiner.de@gmail.com, manfred@colorfullife.com, oakad@yahoo.com, linux-scsi@vger.kernel.org, mawilcox@microsoft.com, mfasheh@versity.com, richard@nod.at, joro@8bytes.org, jiangyilism@gmail.com, elfring@users.sourceforge.net, cluster-devel@redhat.com, javier@osg.samsung.com, jarkko.sakkinen@linux.intel.com, mingo@redhat.com, vdavydov.dev@gmail.com, kvalo@qca.qualcomm.com, tipc-discussion@lists.sourceforge.net, ogerlitz@mellanox.com, devicetree@vger.kernel.org, lizefan@huawei.com, huxm@marvell.com, mchehab@kernel.org, johan@kernel.org, aditr@vmware.com, linux-block@vger.kernel.org, robh+dt@kernel.org, thierry.reding@gmail.com, hare@suse.de, rminnich@sandia.gov, linux-tegra@vger.kernel.org, dsa@cumulusnetworks.com, intel-gvt-dev@lists.freedesktop.org, jy0922.shim@samsung.com, axboe@kernel.dk, gbhat@marvell.com, tomas.winkler@intel.com, dedekind1@gmail.com, jbacik@fb.com, jarno@ovn.org, vyasevich@gmail.com, krzk@kernel.org, sboyd@codeaurora.org, jiri@mellanox.com, afd@ti.com, ashutosh.dixit@intel.com, yishaih@mellanox.com, rjw@rjwysocki.net, hannes@cmpxchg.org, Bart.VanAssche@sandisk.com, johannes@sipsolutions.net, dwmw2@infradead.org, dasaratharaman.chandramouli@intel.com UXVvdGluZyBDaHJpc3RpYW4gS8O2bmlnICgyMDE3LTA4LTE2IDA4OjQ5OjA3KQo+IEFtIDE2LjA4 LjIwMTcgdW0gMDQ6MTIgc2NocmllYiBDaHJpcyBNaToKPiA+IFVzaW5nIGN1cnJlbnQgVEMgY29k ZSwgaXQgaXMgdmVyeSBzbG93IHRvIGluc2VydCBhIGxvdCBvZiBydWxlcy4KPiA+Cj4gPiBJbiBv cmRlciB0byBpbXByb3ZlIHRoZSBydWxlcyB1cGRhdGUgcmF0ZSBpbiBUQywKPiA+IHdlIGludHJv ZHVjZWQgdGhlIGZvbGxvd2luZyB0d28gY2hhbmdlczoKPiA+ICAgICAgICAgIDEpIGNoYW5nZWQg Y2xzX2Zsb3dlciB0byB1c2UgSURSIHRvIG1hbmFnZSB0aGUgZmlsdGVycy4KPiA+ICAgICAgICAg IDIpIGNoYW5nZWQgYWxsIGFjdF94eHggbW9kdWxlcyB0byB1c2UgSURSIGluc3RlYWQgb2YKPiA+ ICAgICAgICAgICAgIGEgc21hbGwgaGFzaCB0YWJsZQo+ID4KPiA+IEJ1dCBJRFIgaGFzIGEgbGlt aXRhdGlvbiB0aGF0IGl0IHVzZXMgaW50LiBUQyBoYW5kbGUgdXNlcyB1MzIuCj4gPiBUbyBtYWtl IHN1cmUgdGhlcmUgaXMgbm8gcmVncmVzc2lvbiwgd2UgYWxzbyBjaGFuZ2VkIElEUiB0byB1c2UK PiA+IHVuc2lnbmVkIGxvbmcuIEFsbCBjbGllbnRzIG9mIElEUiBhcmUgY2hhbmdlZCB0byB1c2Ug bmV3IElEUiBBUEkuCj4gCj4gV09XLCB3YWl0IGEgc2Vjb25kLiBUaGUgaWRyIGNoYW5nZSBpcyB0 b3VjaGluZyBhIGxvdCBvZiBkcml2ZXJzIGFuZCB0byAKPiBiZSBob25lc3QgZG9lc24ndCBsb29r cyBjb3JyZWN0IGF0IGFsbC4KPiAKPiBKdXN0IGxvb2sgYXQgdGhlIGZpcnN0IGNodW5rIG9mIHlv dXIgbW9kaWZpY2F0aW9uOgo+ID4gQEAgLTk5OCw4ICs5OTksOSBAQCBpbnQgYnNnX3JlZ2lzdGVy X3F1ZXVlKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxLCBzdHJ1Y3QgZGV2aWNlICpwYXJlbnQsCj4g PiAgIAo+ID4gICAgICAgbXV0ZXhfbG9jaygmYnNnX211dGV4KTsKPiA+ICAgCj4gPiAtICAgICBy ZXQgPSBpZHJfYWxsb2MoJmJzZ19taW5vcl9pZHIsIGJjZCwgMCwgQlNHX01BWF9ERVZTLCBHRlBf S0VSTkVMKTsKPiA+IC0gICAgIGlmIChyZXQgPCAwKSB7Cj4gPiArICAgICByZXQgPSBpZHJfYWxs b2MoJmJzZ19taW5vcl9pZHIsIGJjZCwgJmlkcl9pbmRleCwgMCwgQlNHX01BWF9ERVZTLAo+ID4g KyAgICAgICAgICAgICAgICAgICAgIEdGUF9LRVJORUwpOwo+ID4gKyAgICAgaWYgKHJldCkgewo+ ID4gICAgICAgICAgICAgICBpZiAocmV0ID09IC1FTk9TUEMpIHsKPiA+ICAgICAgICAgICAgICAg ICAgICAgICBwcmludGsoS0VSTl9FUlIgImJzZzogdG9vIG1hbnkgYnNnIGRldmljZXNcbiIpOwo+ ID4gICAgICAgICAgICAgICAgICAgICAgIHJldCA9IC1FSU5WQUw7Cj4gVGhlIGNvbmRpdGlvbiAi aWYgKHJldCkiIHdpbGwgbm93IGFsd2F5cyBiZSB0cnVlIGFmdGVyIHRoZSBmaXJzdCAKPiBhbGxv Y2F0aW9uIGFuZCBzbyB3ZSBhbHdheXMgcnVuIGludG8gdGhlIGVycm9yIGhhbmRsaW5nIGFmdGVy IHRoYXQuCgpyZXQgaXMgbm93IHB1cmVseSB0aGUgZXJyb3IgY29kZSwgc28gaXQgZG9lc24ndCBs b29rIHRoYXQgc3VzcGljaW91cy4KCj4gSSd2ZSBuZXZlciByZWFkIHRoZSBic2cgY29kZSBiZWZv cmUsIGJ1dCB0aGF0J3MgY2VydGFpbmx5IG5vdCBjb3JyZWN0LiAKPiBBbmQgdGhhdCBpbmNvcnJl Y3QgcGF0dGVybiByZXBlYXRzIG92ZXIgYW5kIG92ZXIgYWdhaW4gaW4gdGhpcyBjb2RlLgo+IAo+ IEFwYXJ0IGZyb20gdGhhdCB3aHkgdGhlIGhlY2sgZG8geW91IHdhbnQgdG8gYWxsb2NhdGUgbW9y ZSB0aGFuIDE8PDMxIAo+IGhhbmRsZXM/CgpBbmQgbW9yZSB0byB0aGUgcG9pbnQsIGFyYml0cmFy aWx5IGNoYW5naW5nIHRoZSBtYXhpbXVtIHRvIFVMT05HX01BWAp3aGVyZSB0aGUgQUJJIG9ubHkg c3VwcG9ydHMgVTMyX01BWCBpcyBkYW5nZXJvdXMuIFVubGVzcyB5b3UgZG8gdGhlCmFuYWx5c2lz IG90aGVyd2lzZSwgeW91IGhhdmUgdG8gcmVwbGFjZSBhbGwgdGhlIGVuZD0wIHdpdGggZW5kPUlO VF9NQVgKdG8gbWFpbnRhaW4gZXhpc3RpbmcgYmVoYXZpb3VyLgotQ2hyaXMKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QK YXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Date: Wed, 16 Aug 2017 10:19:53 +0100 Subject: [Cluster-devel] [patch net-next 0/3] net/sched: Improve getting objects by indexes In-Reply-To: <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> References: <1502849538-14284-1-git-send-email-chrism@mellanox.com> <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> Message-ID: <150287519355.15499.3124883464555211520@mail.alporthouse.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Quoting Christian K?nig (2017-08-16 08:49:07) > Am 16.08.2017 um 04:12 schrieb Chris Mi: > > Using current TC code, it is very slow to insert a lot of rules. > > > > In order to improve the rules update rate in TC, > > we introduced the following two changes: > > 1) changed cls_flower to use IDR to manage the filters. > > 2) changed all act_xxx modules to use IDR instead of > > a small hash table > > > > But IDR has a limitation that it uses int. TC handle uses u32. > > To make sure there is no regression, we also changed IDR to use > > unsigned long. All clients of IDR are changed to use new IDR API. > > WOW, wait a second. The idr change is touching a lot of drivers and to > be honest doesn't looks correct at all. > > Just look at the first chunk of your modification: > > @@ -998,8 +999,9 @@ int bsg_register_queue(struct request_queue *q, struct device *parent, > > > > mutex_lock(&bsg_mutex); > > > > - ret = idr_alloc(&bsg_minor_idr, bcd, 0, BSG_MAX_DEVS, GFP_KERNEL); > > - if (ret < 0) { > > + ret = idr_alloc(&bsg_minor_idr, bcd, &idr_index, 0, BSG_MAX_DEVS, > > + GFP_KERNEL); > > + if (ret) { > > if (ret == -ENOSPC) { > > printk(KERN_ERR "bsg: too many bsg devices\n"); > > ret = -EINVAL; > The condition "if (ret)" will now always be true after the first > allocation and so we always run into the error handling after that. ret is now purely the error code, so it doesn't look that suspicious. > I've never read the bsg code before, but that's certainly not correct. > And that incorrect pattern repeats over and over again in this code. > > Apart from that why the heck do you want to allocate more than 1<<31 > handles? And more to the point, arbitrarily changing the maximum to ULONG_MAX where the ABI only supports U32_MAX is dangerous. Unless you do the analysis otherwise, you have to replace all the end=0 with end=INT_MAX to maintain existing behaviour. -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [patch net-next 0/3] net/sched: Improve getting objects by indexes Date: Wed, 16 Aug 2017 10:19:53 +0100 Message-ID: <150287519355.15499.3124883464555211520@mail.alporthouse.com> References: <1502849538-14284-1-git-send-email-chrism@mellanox.com> <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Subject:Message-ID:References: In-Reply-To:From:To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/oliS/wCWrNy4p0EASKEeU+NjFSnQoOEjrJHoXhmptQ=; b=GNYhVJFoREEmdr MshJZRVaYVaRFlUvdB7jzjHPnqqz7MGMcSw7fAPcu6xapXiqZS9J+9A+5CgAuRZZ7BQQYqtJ8b1t4 m+MDsaXGufWWovc8TnVzgQRrMquv9HNs0KFBROg5LxTWF7lWSI5J+u3GBxE7O6ePryk4NdezXQIzn W0Zv9xhT+fE1WHUAHmCXOEDrVPIzcW4GPWu4zo0vcPFzL4fZpalUlLN3d12K0FnY2QkT0paTVRDCy yj09GQJtljh8VESpIvUeNTcKaWpadiuAa00JrtWxMWnVRgCdm3maTBERn/IgfTc7hxPx3SFP2ahH+ NnhlDk3tMXNdFROyoyaQ==; In-Reply-To: <144b87a3-bbe4-a194-ed83-e54840d7c7c2@amd.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+gldad-ath10k=m.gmane.org@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" To: =?utf-8?q?Christian_K=C3=B6nig?= , Chris Mi , netdev@vger.kernel.org Cc: lucho@ionkov.net, sergey.senozhatsky.work@gmail.com, snitzer@redhat.com, wsa@the-dreams.de, markb@mellanox.com, tom.leiming@gmail.com, stefanr@s5r6.in-berlin.de, zhi.a.wang@intel.com, nsekhar@ti.com, dri-devel@lists.freedesktop.org, bfields@fieldses.org, linux-sctp@vger.kernel.org, paulus@samba.org, jinpu.wang@profitbricks.com, pshelar@ovn.org, sumit.semwal@linaro.org, AlexBin.Xie@amd.com, david1.zhou@amd.com, linux-samsung-soc@vger.kernel.org, maximlevitsky@gmail.com, sudarsana.kalluru@qlogic.com, marek.vasut@gmail.com, linux-atm-general@lists.sourceforge.net, dtwlin@gmail.com, michel.daenzer@amd.com, dledford@redhat.com, tpmdd-devel@lists.sourceforge.net, stern@rowland.harvard.edu, longman@redhat.com, niranjana.vishwanathapura@intel.com, philipp.reisner@linbit.com, shli@kernel.org, linux@roeck-us.net, ohad@wizery.com, pmladek@suse.com, dick.kennedy@broadcom.com, linux- UXVvdGluZyBDaHJpc3RpYW4gS8O2bmlnICgyMDE3LTA4LTE2IDA4OjQ5OjA3KQo+IEFtIDE2LjA4 LjIwMTcgdW0gMDQ6MTIgc2NocmllYiBDaHJpcyBNaToKPiA+IFVzaW5nIGN1cnJlbnQgVEMgY29k ZSwgaXQgaXMgdmVyeSBzbG93IHRvIGluc2VydCBhIGxvdCBvZiBydWxlcy4KPiA+Cj4gPiBJbiBv cmRlciB0byBpbXByb3ZlIHRoZSBydWxlcyB1cGRhdGUgcmF0ZSBpbiBUQywKPiA+IHdlIGludHJv ZHVjZWQgdGhlIGZvbGxvd2luZyB0d28gY2hhbmdlczoKPiA+ICAgICAgICAgIDEpIGNoYW5nZWQg Y2xzX2Zsb3dlciB0byB1c2UgSURSIHRvIG1hbmFnZSB0aGUgZmlsdGVycy4KPiA+ICAgICAgICAg IDIpIGNoYW5nZWQgYWxsIGFjdF94eHggbW9kdWxlcyB0byB1c2UgSURSIGluc3RlYWQgb2YKPiA+ ICAgICAgICAgICAgIGEgc21hbGwgaGFzaCB0YWJsZQo+ID4KPiA+IEJ1dCBJRFIgaGFzIGEgbGlt aXRhdGlvbiB0aGF0IGl0IHVzZXMgaW50LiBUQyBoYW5kbGUgdXNlcyB1MzIuCj4gPiBUbyBtYWtl IHN1cmUgdGhlcmUgaXMgbm8gcmVncmVzc2lvbiwgd2UgYWxzbyBjaGFuZ2VkIElEUiB0byB1c2UK PiA+IHVuc2lnbmVkIGxvbmcuIEFsbCBjbGllbnRzIG9mIElEUiBhcmUgY2hhbmdlZCB0byB1c2Ug bmV3IElEUiBBUEkuCj4gCj4gV09XLCB3YWl0IGEgc2Vjb25kLiBUaGUgaWRyIGNoYW5nZSBpcyB0 b3VjaGluZyBhIGxvdCBvZiBkcml2ZXJzIGFuZCB0byAKPiBiZSBob25lc3QgZG9lc24ndCBsb29r cyBjb3JyZWN0IGF0IGFsbC4KPiAKPiBKdXN0IGxvb2sgYXQgdGhlIGZpcnN0IGNodW5rIG9mIHlv dXIgbW9kaWZpY2F0aW9uOgo+ID4gQEAgLTk5OCw4ICs5OTksOSBAQCBpbnQgYnNnX3JlZ2lzdGVy X3F1ZXVlKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxLCBzdHJ1Y3QgZGV2aWNlICpwYXJlbnQsCj4g PiAgIAo+ID4gICAgICAgbXV0ZXhfbG9jaygmYnNnX211dGV4KTsKPiA+ICAgCj4gPiAtICAgICBy ZXQgPSBpZHJfYWxsb2MoJmJzZ19taW5vcl9pZHIsIGJjZCwgMCwgQlNHX01BWF9ERVZTLCBHRlBf S0VSTkVMKTsKPiA+IC0gICAgIGlmIChyZXQgPCAwKSB7Cj4gPiArICAgICByZXQgPSBpZHJfYWxs b2MoJmJzZ19taW5vcl9pZHIsIGJjZCwgJmlkcl9pbmRleCwgMCwgQlNHX01BWF9ERVZTLAo+ID4g KyAgICAgICAgICAgICAgICAgICAgIEdGUF9LRVJORUwpOwo+ID4gKyAgICAgaWYgKHJldCkgewo+ ID4gICAgICAgICAgICAgICBpZiAocmV0ID09IC1FTk9TUEMpIHsKPiA+ICAgICAgICAgICAgICAg ICAgICAgICBwcmludGsoS0VSTl9FUlIgImJzZzogdG9vIG1hbnkgYnNnIGRldmljZXNcbiIpOwo+ ID4gICAgICAgICAgICAgICAgICAgICAgIHJldCA9IC1FSU5WQUw7Cj4gVGhlIGNvbmRpdGlvbiAi aWYgKHJldCkiIHdpbGwgbm93IGFsd2F5cyBiZSB0cnVlIGFmdGVyIHRoZSBmaXJzdCAKPiBhbGxv Y2F0aW9uIGFuZCBzbyB3ZSBhbHdheXMgcnVuIGludG8gdGhlIGVycm9yIGhhbmRsaW5nIGFmdGVy IHRoYXQuCgpyZXQgaXMgbm93IHB1cmVseSB0aGUgZXJyb3IgY29kZSwgc28gaXQgZG9lc24ndCBs b29rIHRoYXQgc3VzcGljaW91cy4KCj4gSSd2ZSBuZXZlciByZWFkIHRoZSBic2cgY29kZSBiZWZv cmUsIGJ1dCB0aGF0J3MgY2VydGFpbmx5IG5vdCBjb3JyZWN0LiAKPiBBbmQgdGhhdCBpbmNvcnJl Y3QgcGF0dGVybiByZXBlYXRzIG92ZXIgYW5kIG92ZXIgYWdhaW4gaW4gdGhpcyBjb2RlLgo+IAo+ IEFwYXJ0IGZyb20gdGhhdCB3aHkgdGhlIGhlY2sgZG8geW91IHdhbnQgdG8gYWxsb2NhdGUgbW9y ZSB0aGFuIDE8PDMxIAo+IGhhbmRsZXM/CgpBbmQgbW9yZSB0byB0aGUgcG9pbnQsIGFyYml0cmFy aWx5IGNoYW5naW5nIHRoZSBtYXhpbXVtIHRvIFVMT05HX01BWAp3aGVyZSB0aGUgQUJJIG9ubHkg c3VwcG9ydHMgVTMyX01BWCBpcyBkYW5nZXJvdXMuIFVubGVzcyB5b3UgZG8gdGhlCmFuYWx5c2lz IG90aGVyd2lzZSwgeW91IGhhdmUgdG8gcmVwbGFjZSBhbGwgdGhlIGVuZD0wIHdpdGggZW5kPUlO VF9NQVgKdG8gbWFpbnRhaW4gZXhpc3RpbmcgYmVoYXZpb3VyLgotQ2hyaXMKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QK YXRoMTBrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9hdGgxMGsK