From: no-reply@patchew.org
To: pbonzini@redhat.com
Cc: famz@redhat.com, qemu-devel@nongnu.orgfamz@redhat.com,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 00/10] scsi, block: introduce persistent reservation managers
Date: Tue, 22 Aug 2017 06:51:21 -0700 (PDT) [thread overview]
Message-ID: <150340988061.30.13345498380514219197@205a2245145f> (raw)
In-Reply-To: <20170822131832.20191-1-pbonzini@redhat.com>
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20170822131832.20191-1-pbonzini@redhat.com
Subject: [Qemu-devel] [RFC PATCH 00/10] scsi, block: introduce persistent reservation managers
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e72ec38399 scsi: add persistent reservation manager using qemu-pr-helper
284895f2ab scsi: add multipath support to qemu-pr-helper
a946f484ca scsi: build qemu-pr-helper
05fe9d89ec io: add qio_channel_read/write_all
773bd4b8d7 scsi, file-posix: add support for persistent reservation management
2dd394b769 scsi: move block/scsi.h to include/scsi/constants.h
216ab8692e scsi: introduce sg_io_sense_from_errno
6a5a1d0624 scsi: introduce scsi_build_sense
7fa71258fa scsi: move non-emulation specific code to scsi/
4381f3f50d scsi: rename scsi_convert_sense
=== OUTPUT BEGIN ===
Checking PATCH 1/10: scsi: rename scsi_convert_sense...
Checking PATCH 2/10: scsi: move non-emulation specific code to scsi/...
ERROR: space prohibited after that open square bracket '['
#1042: FILE: scsi/utils.c:282:
+ [ TEST_UNIT_READY ] = "TEST_UNIT_READY",
ERROR: space prohibited before that close square bracket ']'
#1042: FILE: scsi/utils.c:282:
+ [ TEST_UNIT_READY ] = "TEST_UNIT_READY",
ERROR: space prohibited after that open square bracket '['
#1043: FILE: scsi/utils.c:283:
+ [ REWIND ] = "REWIND",
ERROR: space prohibited before that close square bracket ']'
#1043: FILE: scsi/utils.c:283:
+ [ REWIND ] = "REWIND",
ERROR: space prohibited after that open square bracket '['
#1044: FILE: scsi/utils.c:284:
+ [ REQUEST_SENSE ] = "REQUEST_SENSE",
ERROR: space prohibited before that close square bracket ']'
#1044: FILE: scsi/utils.c:284:
+ [ REQUEST_SENSE ] = "REQUEST_SENSE",
ERROR: space prohibited after that open square bracket '['
#1045: FILE: scsi/utils.c:285:
+ [ FORMAT_UNIT ] = "FORMAT_UNIT",
ERROR: space prohibited before that close square bracket ']'
#1045: FILE: scsi/utils.c:285:
+ [ FORMAT_UNIT ] = "FORMAT_UNIT",
ERROR: space prohibited after that open square bracket '['
#1046: FILE: scsi/utils.c:286:
+ [ READ_BLOCK_LIMITS ] = "READ_BLOCK_LIMITS",
ERROR: space prohibited before that close square bracket ']'
#1046: FILE: scsi/utils.c:286:
+ [ READ_BLOCK_LIMITS ] = "READ_BLOCK_LIMITS",
WARNING: line over 80 characters
#1047: FILE: scsi/utils.c:287:
+ [ REASSIGN_BLOCKS ] = "REASSIGN_BLOCKS/INITIALIZE ELEMENT STATUS",
ERROR: space prohibited after that open square bracket '['
#1047: FILE: scsi/utils.c:287:
+ [ REASSIGN_BLOCKS ] = "REASSIGN_BLOCKS/INITIALIZE ELEMENT STATUS",
ERROR: space prohibited before that close square bracket ']'
#1047: FILE: scsi/utils.c:287:
+ [ REASSIGN_BLOCKS ] = "REASSIGN_BLOCKS/INITIALIZE ELEMENT STATUS",
WARNING: line over 80 characters
#1048: FILE: scsi/utils.c:288:
+ /* LOAD_UNLOAD and INITIALIZE_ELEMENT_STATUS use the same operation code */
ERROR: space prohibited after that open square bracket '['
#1049: FILE: scsi/utils.c:289:
+ [ READ_6 ] = "READ_6",
ERROR: space prohibited before that close square bracket ']'
#1049: FILE: scsi/utils.c:289:
+ [ READ_6 ] = "READ_6",
ERROR: space prohibited after that open square bracket '['
#1050: FILE: scsi/utils.c:290:
+ [ WRITE_6 ] = "WRITE_6",
ERROR: space prohibited before that close square bracket ']'
#1050: FILE: scsi/utils.c:290:
+ [ WRITE_6 ] = "WRITE_6",
ERROR: space prohibited after that open square bracket '['
#1051: FILE: scsi/utils.c:291:
+ [ SET_CAPACITY ] = "SET_CAPACITY",
ERROR: space prohibited before that close square bracket ']'
#1051: FILE: scsi/utils.c:291:
+ [ SET_CAPACITY ] = "SET_CAPACITY",
ERROR: space prohibited after that open square bracket '['
#1052: FILE: scsi/utils.c:292:
+ [ READ_REVERSE ] = "READ_REVERSE",
ERROR: space prohibited before that close square bracket ']'
#1052: FILE: scsi/utils.c:292:
+ [ READ_REVERSE ] = "READ_REVERSE",
ERROR: space prohibited after that open square bracket '['
#1053: FILE: scsi/utils.c:293:
+ [ WRITE_FILEMARKS ] = "WRITE_FILEMARKS",
ERROR: space prohibited before that close square bracket ']'
#1053: FILE: scsi/utils.c:293:
+ [ WRITE_FILEMARKS ] = "WRITE_FILEMARKS",
ERROR: space prohibited after that open square bracket '['
#1054: FILE: scsi/utils.c:294:
+ [ SPACE ] = "SPACE",
ERROR: space prohibited before that close square bracket ']'
#1054: FILE: scsi/utils.c:294:
+ [ SPACE ] = "SPACE",
ERROR: space prohibited after that open square bracket '['
#1055: FILE: scsi/utils.c:295:
+ [ INQUIRY ] = "INQUIRY",
ERROR: space prohibited before that close square bracket ']'
#1055: FILE: scsi/utils.c:295:
+ [ INQUIRY ] = "INQUIRY",
ERROR: space prohibited after that open square bracket '['
#1056: FILE: scsi/utils.c:296:
+ [ RECOVER_BUFFERED_DATA ] = "RECOVER_BUFFERED_DATA",
ERROR: space prohibited before that close square bracket ']'
#1056: FILE: scsi/utils.c:296:
+ [ RECOVER_BUFFERED_DATA ] = "RECOVER_BUFFERED_DATA",
ERROR: space prohibited after that open square bracket '['
#1057: FILE: scsi/utils.c:297:
+ [ MAINTENANCE_IN ] = "MAINTENANCE_IN",
ERROR: space prohibited before that close square bracket ']'
#1057: FILE: scsi/utils.c:297:
+ [ MAINTENANCE_IN ] = "MAINTENANCE_IN",
ERROR: space prohibited after that open square bracket '['
#1058: FILE: scsi/utils.c:298:
+ [ MAINTENANCE_OUT ] = "MAINTENANCE_OUT",
ERROR: space prohibited before that close square bracket ']'
#1058: FILE: scsi/utils.c:298:
+ [ MAINTENANCE_OUT ] = "MAINTENANCE_OUT",
ERROR: space prohibited after that open square bracket '['
#1059: FILE: scsi/utils.c:299:
+ [ MODE_SELECT ] = "MODE_SELECT",
ERROR: space prohibited before that close square bracket ']'
#1059: FILE: scsi/utils.c:299:
+ [ MODE_SELECT ] = "MODE_SELECT",
ERROR: space prohibited after that open square bracket '['
#1060: FILE: scsi/utils.c:300:
+ [ RESERVE ] = "RESERVE",
ERROR: space prohibited before that close square bracket ']'
#1060: FILE: scsi/utils.c:300:
+ [ RESERVE ] = "RESERVE",
ERROR: space prohibited after that open square bracket '['
#1061: FILE: scsi/utils.c:301:
+ [ RELEASE ] = "RELEASE",
ERROR: space prohibited before that close square bracket ']'
#1061: FILE: scsi/utils.c:301:
+ [ RELEASE ] = "RELEASE",
ERROR: space prohibited after that open square bracket '['
#1062: FILE: scsi/utils.c:302:
+ [ COPY ] = "COPY",
ERROR: space prohibited before that close square bracket ']'
#1062: FILE: scsi/utils.c:302:
+ [ COPY ] = "COPY",
ERROR: space prohibited after that open square bracket '['
#1063: FILE: scsi/utils.c:303:
+ [ ERASE ] = "ERASE",
ERROR: space prohibited before that close square bracket ']'
#1063: FILE: scsi/utils.c:303:
+ [ ERASE ] = "ERASE",
ERROR: space prohibited after that open square bracket '['
#1064: FILE: scsi/utils.c:304:
+ [ MODE_SENSE ] = "MODE_SENSE",
ERROR: space prohibited before that close square bracket ']'
#1064: FILE: scsi/utils.c:304:
+ [ MODE_SENSE ] = "MODE_SENSE",
ERROR: space prohibited after that open square bracket '['
#1065: FILE: scsi/utils.c:305:
+ [ START_STOP ] = "START_STOP/LOAD_UNLOAD",
ERROR: space prohibited before that close square bracket ']'
#1065: FILE: scsi/utils.c:305:
+ [ START_STOP ] = "START_STOP/LOAD_UNLOAD",
ERROR: space prohibited after that open square bracket '['
#1067: FILE: scsi/utils.c:307:
+ [ RECEIVE_DIAGNOSTIC ] = "RECEIVE_DIAGNOSTIC",
ERROR: space prohibited before that close square bracket ']'
#1067: FILE: scsi/utils.c:307:
+ [ RECEIVE_DIAGNOSTIC ] = "RECEIVE_DIAGNOSTIC",
ERROR: space prohibited after that open square bracket '['
#1068: FILE: scsi/utils.c:308:
+ [ SEND_DIAGNOSTIC ] = "SEND_DIAGNOSTIC",
ERROR: space prohibited before that close square bracket ']'
#1068: FILE: scsi/utils.c:308:
+ [ SEND_DIAGNOSTIC ] = "SEND_DIAGNOSTIC",
ERROR: space prohibited after that open square bracket '['
#1069: FILE: scsi/utils.c:309:
+ [ ALLOW_MEDIUM_REMOVAL ] = "ALLOW_MEDIUM_REMOVAL",
ERROR: space prohibited before that close square bracket ']'
#1069: FILE: scsi/utils.c:309:
+ [ ALLOW_MEDIUM_REMOVAL ] = "ALLOW_MEDIUM_REMOVAL",
ERROR: space prohibited after that open square bracket '['
#1070: FILE: scsi/utils.c:310:
+ [ READ_CAPACITY_10 ] = "READ_CAPACITY_10",
ERROR: space prohibited before that close square bracket ']'
#1070: FILE: scsi/utils.c:310:
+ [ READ_CAPACITY_10 ] = "READ_CAPACITY_10",
ERROR: space prohibited after that open square bracket '['
#1071: FILE: scsi/utils.c:311:
+ [ READ_10 ] = "READ_10",
ERROR: space prohibited before that close square bracket ']'
#1071: FILE: scsi/utils.c:311:
+ [ READ_10 ] = "READ_10",
ERROR: space prohibited after that open square bracket '['
#1072: FILE: scsi/utils.c:312:
+ [ WRITE_10 ] = "WRITE_10",
ERROR: space prohibited before that close square bracket ']'
#1072: FILE: scsi/utils.c:312:
+ [ WRITE_10 ] = "WRITE_10",
ERROR: space prohibited after that open square bracket '['
#1073: FILE: scsi/utils.c:313:
+ [ SEEK_10 ] = "SEEK_10/POSITION_TO_ELEMENT",
ERROR: space prohibited before that close square bracket ']'
#1073: FILE: scsi/utils.c:313:
+ [ SEEK_10 ] = "SEEK_10/POSITION_TO_ELEMENT",
ERROR: space prohibited after that open square bracket '['
#1075: FILE: scsi/utils.c:315:
+ [ WRITE_VERIFY_10 ] = "WRITE_VERIFY_10",
ERROR: space prohibited before that close square bracket ']'
#1075: FILE: scsi/utils.c:315:
+ [ WRITE_VERIFY_10 ] = "WRITE_VERIFY_10",
ERROR: space prohibited after that open square bracket '['
#1076: FILE: scsi/utils.c:316:
+ [ VERIFY_10 ] = "VERIFY_10",
ERROR: space prohibited before that close square bracket ']'
#1076: FILE: scsi/utils.c:316:
+ [ VERIFY_10 ] = "VERIFY_10",
ERROR: space prohibited after that open square bracket '['
#1077: FILE: scsi/utils.c:317:
+ [ SEARCH_HIGH ] = "SEARCH_HIGH",
ERROR: space prohibited before that close square bracket ']'
#1077: FILE: scsi/utils.c:317:
+ [ SEARCH_HIGH ] = "SEARCH_HIGH",
ERROR: space prohibited after that open square bracket '['
#1078: FILE: scsi/utils.c:318:
+ [ SEARCH_EQUAL ] = "SEARCH_EQUAL",
ERROR: space prohibited before that close square bracket ']'
#1078: FILE: scsi/utils.c:318:
+ [ SEARCH_EQUAL ] = "SEARCH_EQUAL",
ERROR: space prohibited after that open square bracket '['
#1079: FILE: scsi/utils.c:319:
+ [ SEARCH_LOW ] = "SEARCH_LOW",
ERROR: space prohibited before that close square bracket ']'
#1079: FILE: scsi/utils.c:319:
+ [ SEARCH_LOW ] = "SEARCH_LOW",
ERROR: space prohibited after that open square bracket '['
#1080: FILE: scsi/utils.c:320:
+ [ SET_LIMITS ] = "SET_LIMITS",
ERROR: space prohibited before that close square bracket ']'
#1080: FILE: scsi/utils.c:320:
+ [ SET_LIMITS ] = "SET_LIMITS",
ERROR: space prohibited after that open square bracket '['
#1081: FILE: scsi/utils.c:321:
+ [ PRE_FETCH ] = "PRE_FETCH/READ_POSITION",
ERROR: space prohibited before that close square bracket ']'
#1081: FILE: scsi/utils.c:321:
+ [ PRE_FETCH ] = "PRE_FETCH/READ_POSITION",
ERROR: space prohibited after that open square bracket '['
#1083: FILE: scsi/utils.c:323:
+ [ SYNCHRONIZE_CACHE ] = "SYNCHRONIZE_CACHE",
ERROR: space prohibited before that close square bracket ']'
#1083: FILE: scsi/utils.c:323:
+ [ SYNCHRONIZE_CACHE ] = "SYNCHRONIZE_CACHE",
ERROR: space prohibited after that open square bracket '['
#1084: FILE: scsi/utils.c:324:
+ [ LOCK_UNLOCK_CACHE ] = "LOCK_UNLOCK_CACHE",
ERROR: space prohibited before that close square bracket ']'
#1084: FILE: scsi/utils.c:324:
+ [ LOCK_UNLOCK_CACHE ] = "LOCK_UNLOCK_CACHE",
ERROR: line over 90 characters
#1085: FILE: scsi/utils.c:325:
+ [ READ_DEFECT_DATA ] = "READ_DEFECT_DATA/INITIALIZE_ELEMENT_STATUS_WITH_RANGE",
ERROR: space prohibited after that open square bracket '['
#1085: FILE: scsi/utils.c:325:
+ [ READ_DEFECT_DATA ] = "READ_DEFECT_DATA/INITIALIZE_ELEMENT_STATUS_WITH_RANGE",
ERROR: space prohibited before that close square bracket ']'
#1085: FILE: scsi/utils.c:325:
+ [ READ_DEFECT_DATA ] = "READ_DEFECT_DATA/INITIALIZE_ELEMENT_STATUS_WITH_RANGE",
ERROR: line over 90 characters
#1086: FILE: scsi/utils.c:326:
+ /* READ_DEFECT_DATA and INITIALIZE_ELEMENT_STATUS_WITH_RANGE use the same operation code */
ERROR: space prohibited after that open square bracket '['
#1087: FILE: scsi/utils.c:327:
+ [ MEDIUM_SCAN ] = "MEDIUM_SCAN",
ERROR: space prohibited before that close square bracket ']'
#1087: FILE: scsi/utils.c:327:
+ [ MEDIUM_SCAN ] = "MEDIUM_SCAN",
ERROR: space prohibited after that open square bracket '['
#1088: FILE: scsi/utils.c:328:
+ [ COMPARE ] = "COMPARE",
ERROR: space prohibited before that close square bracket ']'
#1088: FILE: scsi/utils.c:328:
+ [ COMPARE ] = "COMPARE",
ERROR: space prohibited after that open square bracket '['
#1089: FILE: scsi/utils.c:329:
+ [ COPY_VERIFY ] = "COPY_VERIFY",
ERROR: space prohibited before that close square bracket ']'
#1089: FILE: scsi/utils.c:329:
+ [ COPY_VERIFY ] = "COPY_VERIFY",
ERROR: space prohibited after that open square bracket '['
#1090: FILE: scsi/utils.c:330:
+ [ WRITE_BUFFER ] = "WRITE_BUFFER",
ERROR: space prohibited before that close square bracket ']'
#1090: FILE: scsi/utils.c:330:
+ [ WRITE_BUFFER ] = "WRITE_BUFFER",
ERROR: space prohibited after that open square bracket '['
#1091: FILE: scsi/utils.c:331:
+ [ READ_BUFFER ] = "READ_BUFFER",
ERROR: space prohibited before that close square bracket ']'
#1091: FILE: scsi/utils.c:331:
+ [ READ_BUFFER ] = "READ_BUFFER",
ERROR: space prohibited after that open square bracket '['
#1092: FILE: scsi/utils.c:332:
+ [ UPDATE_BLOCK ] = "UPDATE_BLOCK",
ERROR: space prohibited before that close square bracket ']'
#1092: FILE: scsi/utils.c:332:
+ [ UPDATE_BLOCK ] = "UPDATE_BLOCK",
ERROR: space prohibited after that open square bracket '['
#1093: FILE: scsi/utils.c:333:
+ [ READ_LONG_10 ] = "READ_LONG_10",
ERROR: space prohibited before that close square bracket ']'
#1093: FILE: scsi/utils.c:333:
+ [ READ_LONG_10 ] = "READ_LONG_10",
ERROR: space prohibited after that open square bracket '['
#1094: FILE: scsi/utils.c:334:
+ [ WRITE_LONG_10 ] = "WRITE_LONG_10",
ERROR: space prohibited before that close square bracket ']'
#1094: FILE: scsi/utils.c:334:
+ [ WRITE_LONG_10 ] = "WRITE_LONG_10",
ERROR: space prohibited after that open square bracket '['
#1095: FILE: scsi/utils.c:335:
+ [ CHANGE_DEFINITION ] = "CHANGE_DEFINITION",
ERROR: space prohibited before that close square bracket ']'
#1095: FILE: scsi/utils.c:335:
+ [ CHANGE_DEFINITION ] = "CHANGE_DEFINITION",
ERROR: space prohibited after that open square bracket '['
#1096: FILE: scsi/utils.c:336:
+ [ WRITE_SAME_10 ] = "WRITE_SAME_10",
ERROR: space prohibited before that close square bracket ']'
#1096: FILE: scsi/utils.c:336:
+ [ WRITE_SAME_10 ] = "WRITE_SAME_10",
ERROR: space prohibited after that open square bracket '['
#1097: FILE: scsi/utils.c:337:
+ [ UNMAP ] = "UNMAP",
ERROR: space prohibited before that close square bracket ']'
#1097: FILE: scsi/utils.c:337:
+ [ UNMAP ] = "UNMAP",
ERROR: space prohibited after that open square bracket '['
#1098: FILE: scsi/utils.c:338:
+ [ READ_TOC ] = "READ_TOC",
ERROR: space prohibited before that close square bracket ']'
#1098: FILE: scsi/utils.c:338:
+ [ READ_TOC ] = "READ_TOC",
ERROR: space prohibited after that open square bracket '['
#1099: FILE: scsi/utils.c:339:
+ [ REPORT_DENSITY_SUPPORT ] = "REPORT_DENSITY_SUPPORT",
ERROR: space prohibited before that close square bracket ']'
#1099: FILE: scsi/utils.c:339:
+ [ REPORT_DENSITY_SUPPORT ] = "REPORT_DENSITY_SUPPORT",
ERROR: space prohibited after that open square bracket '['
#1100: FILE: scsi/utils.c:340:
+ [ SANITIZE ] = "SANITIZE",
ERROR: space prohibited before that close square bracket ']'
#1100: FILE: scsi/utils.c:340:
+ [ SANITIZE ] = "SANITIZE",
ERROR: space prohibited after that open square bracket '['
#1101: FILE: scsi/utils.c:341:
+ [ GET_CONFIGURATION ] = "GET_CONFIGURATION",
ERROR: space prohibited before that close square bracket ']'
#1101: FILE: scsi/utils.c:341:
+ [ GET_CONFIGURATION ] = "GET_CONFIGURATION",
ERROR: space prohibited after that open square bracket '['
#1102: FILE: scsi/utils.c:342:
+ [ LOG_SELECT ] = "LOG_SELECT",
ERROR: space prohibited before that close square bracket ']'
#1102: FILE: scsi/utils.c:342:
+ [ LOG_SELECT ] = "LOG_SELECT",
ERROR: space prohibited after that open square bracket '['
#1103: FILE: scsi/utils.c:343:
+ [ LOG_SENSE ] = "LOG_SENSE",
ERROR: space prohibited before that close square bracket ']'
#1103: FILE: scsi/utils.c:343:
+ [ LOG_SENSE ] = "LOG_SENSE",
ERROR: space prohibited after that open square bracket '['
#1104: FILE: scsi/utils.c:344:
+ [ MODE_SELECT_10 ] = "MODE_SELECT_10",
ERROR: space prohibited before that close square bracket ']'
#1104: FILE: scsi/utils.c:344:
+ [ MODE_SELECT_10 ] = "MODE_SELECT_10",
ERROR: space prohibited after that open square bracket '['
#1105: FILE: scsi/utils.c:345:
+ [ RESERVE_10 ] = "RESERVE_10",
ERROR: space prohibited before that close square bracket ']'
#1105: FILE: scsi/utils.c:345:
+ [ RESERVE_10 ] = "RESERVE_10",
ERROR: space prohibited after that open square bracket '['
#1106: FILE: scsi/utils.c:346:
+ [ RELEASE_10 ] = "RELEASE_10",
ERROR: space prohibited before that close square bracket ']'
#1106: FILE: scsi/utils.c:346:
+ [ RELEASE_10 ] = "RELEASE_10",
ERROR: space prohibited after that open square bracket '['
#1107: FILE: scsi/utils.c:347:
+ [ MODE_SENSE_10 ] = "MODE_SENSE_10",
ERROR: space prohibited before that close square bracket ']'
#1107: FILE: scsi/utils.c:347:
+ [ MODE_SENSE_10 ] = "MODE_SENSE_10",
ERROR: space prohibited after that open square bracket '['
#1108: FILE: scsi/utils.c:348:
+ [ PERSISTENT_RESERVE_IN ] = "PERSISTENT_RESERVE_IN",
ERROR: space prohibited before that close square bracket ']'
#1108: FILE: scsi/utils.c:348:
+ [ PERSISTENT_RESERVE_IN ] = "PERSISTENT_RESERVE_IN",
ERROR: space prohibited after that open square bracket '['
#1109: FILE: scsi/utils.c:349:
+ [ PERSISTENT_RESERVE_OUT ] = "PERSISTENT_RESERVE_OUT",
ERROR: space prohibited before that close square bracket ']'
#1109: FILE: scsi/utils.c:349:
+ [ PERSISTENT_RESERVE_OUT ] = "PERSISTENT_RESERVE_OUT",
ERROR: space prohibited after that open square bracket '['
#1110: FILE: scsi/utils.c:350:
+ [ WRITE_FILEMARKS_16 ] = "WRITE_FILEMARKS_16",
ERROR: space prohibited before that close square bracket ']'
#1110: FILE: scsi/utils.c:350:
+ [ WRITE_FILEMARKS_16 ] = "WRITE_FILEMARKS_16",
ERROR: space prohibited after that open square bracket '['
#1111: FILE: scsi/utils.c:351:
+ [ EXTENDED_COPY ] = "EXTENDED_COPY",
ERROR: space prohibited before that close square bracket ']'
#1111: FILE: scsi/utils.c:351:
+ [ EXTENDED_COPY ] = "EXTENDED_COPY",
ERROR: space prohibited after that open square bracket '['
#1112: FILE: scsi/utils.c:352:
+ [ ATA_PASSTHROUGH_16 ] = "ATA_PASSTHROUGH_16",
ERROR: space prohibited before that close square bracket ']'
#1112: FILE: scsi/utils.c:352:
+ [ ATA_PASSTHROUGH_16 ] = "ATA_PASSTHROUGH_16",
ERROR: space prohibited after that open square bracket '['
#1113: FILE: scsi/utils.c:353:
+ [ ACCESS_CONTROL_IN ] = "ACCESS_CONTROL_IN",
ERROR: space prohibited before that close square bracket ']'
#1113: FILE: scsi/utils.c:353:
+ [ ACCESS_CONTROL_IN ] = "ACCESS_CONTROL_IN",
ERROR: space prohibited after that open square bracket '['
#1114: FILE: scsi/utils.c:354:
+ [ ACCESS_CONTROL_OUT ] = "ACCESS_CONTROL_OUT",
ERROR: space prohibited before that close square bracket ']'
#1114: FILE: scsi/utils.c:354:
+ [ ACCESS_CONTROL_OUT ] = "ACCESS_CONTROL_OUT",
ERROR: space prohibited after that open square bracket '['
#1115: FILE: scsi/utils.c:355:
+ [ READ_16 ] = "READ_16",
ERROR: space prohibited before that close square bracket ']'
#1115: FILE: scsi/utils.c:355:
+ [ READ_16 ] = "READ_16",
ERROR: space prohibited after that open square bracket '['
#1116: FILE: scsi/utils.c:356:
+ [ COMPARE_AND_WRITE ] = "COMPARE_AND_WRITE",
ERROR: space prohibited before that close square bracket ']'
#1116: FILE: scsi/utils.c:356:
+ [ COMPARE_AND_WRITE ] = "COMPARE_AND_WRITE",
ERROR: space prohibited after that open square bracket '['
#1117: FILE: scsi/utils.c:357:
+ [ WRITE_16 ] = "WRITE_16",
ERROR: space prohibited before that close square bracket ']'
#1117: FILE: scsi/utils.c:357:
+ [ WRITE_16 ] = "WRITE_16",
ERROR: space prohibited after that open square bracket '['
#1118: FILE: scsi/utils.c:358:
+ [ WRITE_VERIFY_16 ] = "WRITE_VERIFY_16",
ERROR: space prohibited before that close square bracket ']'
#1118: FILE: scsi/utils.c:358:
+ [ WRITE_VERIFY_16 ] = "WRITE_VERIFY_16",
ERROR: space prohibited after that open square bracket '['
#1119: FILE: scsi/utils.c:359:
+ [ VERIFY_16 ] = "VERIFY_16",
ERROR: space prohibited before that close square bracket ']'
#1119: FILE: scsi/utils.c:359:
+ [ VERIFY_16 ] = "VERIFY_16",
ERROR: space prohibited after that open square bracket '['
#1120: FILE: scsi/utils.c:360:
+ [ PRE_FETCH_16 ] = "PRE_FETCH_16",
ERROR: space prohibited before that close square bracket ']'
#1120: FILE: scsi/utils.c:360:
+ [ PRE_FETCH_16 ] = "PRE_FETCH_16",
ERROR: space prohibited after that open square bracket '['
#1121: FILE: scsi/utils.c:361:
+ [ SYNCHRONIZE_CACHE_16 ] = "SPACE_16/SYNCHRONIZE_CACHE_16",
ERROR: space prohibited before that close square bracket ']'
#1121: FILE: scsi/utils.c:361:
+ [ SYNCHRONIZE_CACHE_16 ] = "SPACE_16/SYNCHRONIZE_CACHE_16",
ERROR: space prohibited after that open square bracket '['
#1123: FILE: scsi/utils.c:363:
+ [ LOCATE_16 ] = "LOCATE_16",
ERROR: space prohibited before that close square bracket ']'
#1123: FILE: scsi/utils.c:363:
+ [ LOCATE_16 ] = "LOCATE_16",
ERROR: space prohibited after that open square bracket '['
#1124: FILE: scsi/utils.c:364:
+ [ WRITE_SAME_16 ] = "ERASE_16/WRITE_SAME_16",
ERROR: space prohibited before that close square bracket ']'
#1124: FILE: scsi/utils.c:364:
+ [ WRITE_SAME_16 ] = "ERASE_16/WRITE_SAME_16",
ERROR: space prohibited after that open square bracket '['
#1126: FILE: scsi/utils.c:366:
+ [ SERVICE_ACTION_IN_16 ] = "SERVICE_ACTION_IN_16",
ERROR: space prohibited before that close square bracket ']'
#1126: FILE: scsi/utils.c:366:
+ [ SERVICE_ACTION_IN_16 ] = "SERVICE_ACTION_IN_16",
ERROR: space prohibited after that open square bracket '['
#1127: FILE: scsi/utils.c:367:
+ [ WRITE_LONG_16 ] = "WRITE_LONG_16",
ERROR: space prohibited before that close square bracket ']'
#1127: FILE: scsi/utils.c:367:
+ [ WRITE_LONG_16 ] = "WRITE_LONG_16",
ERROR: space prohibited after that open square bracket '['
#1128: FILE: scsi/utils.c:368:
+ [ REPORT_LUNS ] = "REPORT_LUNS",
ERROR: space prohibited before that close square bracket ']'
#1128: FILE: scsi/utils.c:368:
+ [ REPORT_LUNS ] = "REPORT_LUNS",
ERROR: space prohibited after that open square bracket '['
#1129: FILE: scsi/utils.c:369:
+ [ ATA_PASSTHROUGH_12 ] = "BLANK/ATA_PASSTHROUGH_12",
ERROR: space prohibited before that close square bracket ']'
#1129: FILE: scsi/utils.c:369:
+ [ ATA_PASSTHROUGH_12 ] = "BLANK/ATA_PASSTHROUGH_12",
ERROR: space prohibited after that open square bracket '['
#1130: FILE: scsi/utils.c:370:
+ [ MOVE_MEDIUM ] = "MOVE_MEDIUM",
ERROR: space prohibited before that close square bracket ']'
#1130: FILE: scsi/utils.c:370:
+ [ MOVE_MEDIUM ] = "MOVE_MEDIUM",
ERROR: space prohibited after that open square bracket '['
#1131: FILE: scsi/utils.c:371:
+ [ EXCHANGE_MEDIUM ] = "EXCHANGE MEDIUM",
ERROR: space prohibited before that close square bracket ']'
#1131: FILE: scsi/utils.c:371:
+ [ EXCHANGE_MEDIUM ] = "EXCHANGE MEDIUM",
ERROR: space prohibited after that open square bracket '['
#1132: FILE: scsi/utils.c:372:
+ [ READ_12 ] = "READ_12",
ERROR: space prohibited before that close square bracket ']'
#1132: FILE: scsi/utils.c:372:
+ [ READ_12 ] = "READ_12",
ERROR: space prohibited after that open square bracket '['
#1133: FILE: scsi/utils.c:373:
+ [ WRITE_12 ] = "WRITE_12",
ERROR: space prohibited before that close square bracket ']'
#1133: FILE: scsi/utils.c:373:
+ [ WRITE_12 ] = "WRITE_12",
ERROR: space prohibited after that open square bracket '['
#1134: FILE: scsi/utils.c:374:
+ [ ERASE_12 ] = "ERASE_12/GET_PERFORMANCE",
ERROR: space prohibited before that close square bracket ']'
#1134: FILE: scsi/utils.c:374:
+ [ ERASE_12 ] = "ERASE_12/GET_PERFORMANCE",
ERROR: space prohibited after that open square bracket '['
#1136: FILE: scsi/utils.c:376:
+ [ SERVICE_ACTION_IN_12 ] = "SERVICE_ACTION_IN_12",
ERROR: space prohibited before that close square bracket ']'
#1136: FILE: scsi/utils.c:376:
+ [ SERVICE_ACTION_IN_12 ] = "SERVICE_ACTION_IN_12",
ERROR: space prohibited after that open square bracket '['
#1137: FILE: scsi/utils.c:377:
+ [ WRITE_VERIFY_12 ] = "WRITE_VERIFY_12",
ERROR: space prohibited before that close square bracket ']'
#1137: FILE: scsi/utils.c:377:
+ [ WRITE_VERIFY_12 ] = "WRITE_VERIFY_12",
ERROR: space prohibited after that open square bracket '['
#1138: FILE: scsi/utils.c:378:
+ [ VERIFY_12 ] = "VERIFY_12",
ERROR: space prohibited before that close square bracket ']'
#1138: FILE: scsi/utils.c:378:
+ [ VERIFY_12 ] = "VERIFY_12",
ERROR: space prohibited after that open square bracket '['
#1139: FILE: scsi/utils.c:379:
+ [ SEARCH_HIGH_12 ] = "SEARCH_HIGH_12",
ERROR: space prohibited before that close square bracket ']'
#1139: FILE: scsi/utils.c:379:
+ [ SEARCH_HIGH_12 ] = "SEARCH_HIGH_12",
ERROR: space prohibited after that open square bracket '['
#1140: FILE: scsi/utils.c:380:
+ [ SEARCH_EQUAL_12 ] = "SEARCH_EQUAL_12",
ERROR: space prohibited before that close square bracket ']'
#1140: FILE: scsi/utils.c:380:
+ [ SEARCH_EQUAL_12 ] = "SEARCH_EQUAL_12",
ERROR: space prohibited after that open square bracket '['
#1141: FILE: scsi/utils.c:381:
+ [ SEARCH_LOW_12 ] = "SEARCH_LOW_12",
ERROR: space prohibited before that close square bracket ']'
#1141: FILE: scsi/utils.c:381:
+ [ SEARCH_LOW_12 ] = "SEARCH_LOW_12",
ERROR: space prohibited after that open square bracket '['
#1142: FILE: scsi/utils.c:382:
+ [ READ_ELEMENT_STATUS ] = "READ_ELEMENT_STATUS",
ERROR: space prohibited before that close square bracket ']'
#1142: FILE: scsi/utils.c:382:
+ [ READ_ELEMENT_STATUS ] = "READ_ELEMENT_STATUS",
ERROR: space prohibited after that open square bracket '['
#1143: FILE: scsi/utils.c:383:
+ [ SEND_VOLUME_TAG ] = "SEND_VOLUME_TAG/SET_STREAMING",
ERROR: space prohibited before that close square bracket ']'
#1143: FILE: scsi/utils.c:383:
+ [ SEND_VOLUME_TAG ] = "SEND_VOLUME_TAG/SET_STREAMING",
ERROR: space prohibited after that open square bracket '['
#1145: FILE: scsi/utils.c:385:
+ [ READ_CD ] = "READ_CD",
ERROR: space prohibited before that close square bracket ']'
#1145: FILE: scsi/utils.c:385:
+ [ READ_CD ] = "READ_CD",
ERROR: space prohibited after that open square bracket '['
#1146: FILE: scsi/utils.c:386:
+ [ READ_DEFECT_DATA_12 ] = "READ_DEFECT_DATA_12",
ERROR: space prohibited before that close square bracket ']'
#1146: FILE: scsi/utils.c:386:
+ [ READ_DEFECT_DATA_12 ] = "READ_DEFECT_DATA_12",
ERROR: space prohibited after that open square bracket '['
#1147: FILE: scsi/utils.c:387:
+ [ READ_DVD_STRUCTURE ] = "READ_DVD_STRUCTURE",
ERROR: space prohibited before that close square bracket ']'
#1147: FILE: scsi/utils.c:387:
+ [ READ_DVD_STRUCTURE ] = "READ_DVD_STRUCTURE",
ERROR: space prohibited after that open square bracket '['
#1148: FILE: scsi/utils.c:388:
+ [ RESERVE_TRACK ] = "RESERVE_TRACK",
ERROR: space prohibited before that close square bracket ']'
#1148: FILE: scsi/utils.c:388:
+ [ RESERVE_TRACK ] = "RESERVE_TRACK",
ERROR: space prohibited after that open square bracket '['
#1149: FILE: scsi/utils.c:389:
+ [ SEND_CUE_SHEET ] = "SEND_CUE_SHEET",
ERROR: space prohibited before that close square bracket ']'
#1149: FILE: scsi/utils.c:389:
+ [ SEND_CUE_SHEET ] = "SEND_CUE_SHEET",
ERROR: space prohibited after that open square bracket '['
#1150: FILE: scsi/utils.c:390:
+ [ SEND_DVD_STRUCTURE ] = "SEND_DVD_STRUCTURE",
ERROR: space prohibited before that close square bracket ']'
#1150: FILE: scsi/utils.c:390:
+ [ SEND_DVD_STRUCTURE ] = "SEND_DVD_STRUCTURE",
ERROR: space prohibited after that open square bracket '['
#1151: FILE: scsi/utils.c:391:
+ [ SET_CD_SPEED ] = "SET_CD_SPEED",
ERROR: space prohibited before that close square bracket ']'
#1151: FILE: scsi/utils.c:391:
+ [ SET_CD_SPEED ] = "SET_CD_SPEED",
ERROR: space prohibited after that open square bracket '['
#1152: FILE: scsi/utils.c:392:
+ [ SET_READ_AHEAD ] = "SET_READ_AHEAD",
ERROR: space prohibited before that close square bracket ']'
#1152: FILE: scsi/utils.c:392:
+ [ SET_READ_AHEAD ] = "SET_READ_AHEAD",
ERROR: space prohibited after that open square bracket '['
#1153: FILE: scsi/utils.c:393:
+ [ ALLOW_OVERWRITE ] = "ALLOW_OVERWRITE",
ERROR: space prohibited before that close square bracket ']'
#1153: FILE: scsi/utils.c:393:
+ [ ALLOW_OVERWRITE ] = "ALLOW_OVERWRITE",
ERROR: space prohibited after that open square bracket '['
#1154: FILE: scsi/utils.c:394:
+ [ MECHANISM_STATUS ] = "MECHANISM_STATUS",
ERROR: space prohibited before that close square bracket ']'
#1154: FILE: scsi/utils.c:394:
+ [ MECHANISM_STATUS ] = "MECHANISM_STATUS",
ERROR: space prohibited after that open square bracket '['
#1155: FILE: scsi/utils.c:395:
+ [ GET_EVENT_STATUS_NOTIFICATION ] = "GET_EVENT_STATUS_NOTIFICATION",
ERROR: space prohibited before that close square bracket ']'
#1155: FILE: scsi/utils.c:395:
+ [ GET_EVENT_STATUS_NOTIFICATION ] = "GET_EVENT_STATUS_NOTIFICATION",
ERROR: space prohibited after that open square bracket '['
#1156: FILE: scsi/utils.c:396:
+ [ READ_DISC_INFORMATION ] = "READ_DISC_INFORMATION",
ERROR: space prohibited before that close square bracket ']'
#1156: FILE: scsi/utils.c:396:
+ [ READ_DISC_INFORMATION ] = "READ_DISC_INFORMATION",
total: 214 errors, 2 warnings, 1097 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/10: scsi: introduce scsi_build_sense...
Checking PATCH 4/10: scsi: introduce sg_io_sense_from_errno...
Checking PATCH 5/10: scsi: move block/scsi.h to include/scsi/constants.h...
Checking PATCH 6/10: scsi, file-posix: add support for persistent reservation management...
WARNING: line over 80 characters
#91: FILE: block/file-posix.c:414:
+ .help = "id of persistent reservation manager object (default: none)",
total: 0 errors, 1 warnings, 318 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/10: io: add qio_channel_read/write_all...
Checking PATCH 8/10: scsi: build qemu-pr-helper...
WARNING: line over 80 characters
#614: FILE: scsi/qemu-pr-helper.c:382:
+static gboolean accept_client(QIOChannel *ioc, GIOCondition cond, gpointer opaque)
WARNING: line over 80 characters
#680: FILE: scsi/qemu-pr-helper.c:448:
+ /* Change user/group id, retaining the capabilities. Because file descriptors
WARNING: line over 80 characters
#825: FILE: scsi/qemu-pr-helper.c:593:
+ if (qio_channel_socket_listen_sync(server_ioc, &saddr, &local_err) < 0) {
WARNING: line over 80 characters
#841: FILE: scsi/qemu-pr-helper.c:609:
+ error_report("%s does not support socket activation with LISTEN_FDS > 1",
total: 0 errors, 4 warnings, 831 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/10: scsi: add multipath support to qemu-pr-helper...
WARNING: line over 80 characters
#414: FILE: scsi/qemu-pr-helper.c:337:
+ memcpy(&data[8], out->key_list, MIN(out->additional_length, sz - 8));
total: 0 errors, 1 warnings, 580 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/10: scsi: add persistent reservation manager using qemu-pr-helper...
WARNING: line over 80 characters
#171: FILE: scsi/pr-manager-helper.c:146:
+ (cdb[0] == PERSISTENT_RESERVE_OUT ? SG_DXFER_TO_DEV : SG_DXFER_FROM_DEV);
total: 0 errors, 1 warnings, 292 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
prev parent reply other threads:[~2017-08-22 13:51 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 13:18 [Qemu-devel] [RFC PATCH 00/10] scsi, block: introduce persistent reservation managers Paolo Bonzini
2017-08-22 13:18 ` [Qemu-devel] [PATCH 01/10] scsi: rename scsi_convert_sense Paolo Bonzini
2017-08-22 13:38 ` Philippe Mathieu-Daudé
2017-08-22 13:18 ` [Qemu-devel] [PATCH 02/10] scsi: move non-emulation specific code to scsi/ Paolo Bonzini
2017-08-22 13:34 ` Philippe Mathieu-Daudé
2017-08-22 13:18 ` [Qemu-devel] [PATCH 03/10] scsi: introduce scsi_build_sense Paolo Bonzini
2017-08-22 13:35 ` Philippe Mathieu-Daudé
2017-08-30 13:39 ` Stefan Hajnoczi
2017-08-22 13:18 ` [Qemu-devel] [PATCH 04/10] scsi: introduce sg_io_sense_from_errno Paolo Bonzini
2017-08-22 13:45 ` Philippe Mathieu-Daudé
2017-08-22 13:53 ` Paolo Bonzini
2017-08-30 13:41 ` Stefan Hajnoczi
2017-08-22 13:18 ` [Qemu-devel] [PATCH 05/10] scsi: move block/scsi.h to include/scsi/constants.h Paolo Bonzini
2017-08-22 13:37 ` Philippe Mathieu-Daudé
2017-08-30 13:41 ` Stefan Hajnoczi
2017-08-22 13:18 ` [Qemu-devel] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management Paolo Bonzini
2017-08-23 4:13 ` Fam Zheng
2017-08-23 6:56 ` Paolo Bonzini
2017-08-24 15:37 ` Eric Blake
2017-08-24 15:47 ` Paolo Bonzini
2017-08-30 12:59 ` Daniel P. Berrange
2017-08-30 14:26 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-22 13:18 ` [Qemu-devel] [PATCH 07/10] io: add qio_channel_read/write_all Paolo Bonzini
2017-08-23 5:08 ` Fam Zheng
2017-08-23 6:54 ` Paolo Bonzini
2017-08-30 12:52 ` Daniel P. Berrange
2017-08-30 14:33 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-22 13:18 ` [Qemu-devel] [PATCH 08/10] scsi: build qemu-pr-helper Paolo Bonzini
2017-08-22 14:34 ` Marc-André Lureau
2017-08-22 16:04 ` Paolo Bonzini
2017-08-24 15:45 ` Eric Blake
2017-08-30 15:44 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-30 16:06 ` Stefan Hajnoczi
2017-08-22 13:18 ` [Qemu-devel] [PATCH 09/10] scsi: add multipath support to qemu-pr-helper Paolo Bonzini
2017-08-23 5:01 ` Fam Zheng
2017-08-23 6:50 ` Paolo Bonzini
2017-08-30 16:06 ` Stefan Hajnoczi
2017-08-30 16:37 ` Stefan Hajnoczi
2017-09-11 9:14 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2017-08-22 13:18 ` [Qemu-devel] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper Paolo Bonzini
2017-08-23 4:49 ` Fam Zheng
2017-08-23 6:55 ` Paolo Bonzini
2017-08-23 7:48 ` Paolo Bonzini
2017-08-30 16:58 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-08-22 13:48 ` [Qemu-devel] [RFC PATCH 00/10] scsi, block: introduce persistent reservation managers no-reply
2017-08-22 13:50 ` no-reply
2017-08-22 13:50 ` no-reply
2017-08-22 13:51 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150340988061.30.13345498380514219197@205a2245145f \
--to=no-reply@patchew.org \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-devel@nongnu.orgfamz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.