From: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: borntraeger@de.ibm.com, pasic@linux.vnet.ibm.com,
pmorel@linux.vnet.ibm.com, cohuck@redhat.com, agraf@suse.de,
richard.henderson@linaro.org, zyimin@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()
Date: Mon, 28 Aug 2017 10:04:44 +0200 [thread overview]
Message-ID: <1503907487-2764-2-git-send-email-zyimin@linux.vnet.ibm.com> (raw)
In-Reply-To: <1503907487-2764-1-git-send-email-zyimin@linux.vnet.ibm.com>
The function trap_msix() is to check if pcistg instruction would access
msix table entries. The correct boundary condition should be
[table_offset, table_offset+entries*entry_size). But the current
condition calculated misses the last entry. So let's fixup it.
Acked-by: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
Signed-off-by: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
---
hw/s390x/s390-pci-inst.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index b7beb8c36a..eba9ffb5f2 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -440,8 +440,8 @@ static int trap_msix(S390PCIBusDevice *pbdev, uint64_t offset, uint8_t pcias)
{
if (pbdev->msix.available && pbdev->msix.table_bar == pcias &&
offset >= pbdev->msix.table_offset &&
- offset <= pbdev->msix.table_offset +
- (pbdev->msix.entries - 1) * PCI_MSIX_ENTRY_SIZE) {
+ offset < (pbdev->msix.table_offset +
+ pbdev->msix.entries * PCI_MSIX_ENTRY_SIZE)) {
return 1;
} else {
return 0;
--
2.11.0 (Apple Git-81)
next prev parent reply other threads:[~2017-08-28 8:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 8:04 [Qemu-devel] [PATCH 0/4] four zpci patches Yi Min Zhao
2017-08-28 8:04 ` Yi Min Zhao [this message]
2017-08-28 14:51 ` [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix() Cornelia Huck
2017-08-29 4:32 ` Yi Min Zhao
2017-08-29 8:00 ` Cornelia Huck
2017-08-29 8:05 ` Yi Min Zhao
2017-08-29 8:12 ` Yi Min Zhao
2017-08-29 8:22 ` Cornelia Huck
2017-08-29 8:33 ` Yi Min Zhao
2017-08-29 8:58 ` Cornelia Huck
2017-08-30 9:47 ` Cornelia Huck
2017-08-28 8:04 ` [Qemu-devel] [PATCH 2/4] s390x/pci: remove idx from msix msg data Yi Min Zhao
2017-08-28 15:04 ` Cornelia Huck
2017-08-29 4:33 ` Yi Min Zhao
2017-08-28 8:04 ` [Qemu-devel] [PATCH 3/4] s390x/pci: fixup ind_offset of msix routing entry Yi Min Zhao
2017-08-28 15:33 ` Cornelia Huck
2017-08-29 4:39 ` Yi Min Zhao
2017-08-28 8:04 ` [Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback Yi Min Zhao
2017-08-28 15:57 ` Cornelia Huck
2017-08-29 4:46 ` Yi Min Zhao
2017-08-29 8:07 ` Cornelia Huck
2017-08-29 8:26 ` Yi Min Zhao
2017-08-29 9:33 ` Cornelia Huck
2017-08-29 9:49 ` Cornelia Huck
2017-08-29 9:53 ` Yi Min Zhao
2017-08-29 9:51 ` Yi Min Zhao
2017-08-29 9:57 ` Cornelia Huck
2017-08-29 10:00 ` Yi Min Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503907487-2764-2-git-send-email-zyimin@linux.vnet.ibm.com \
--to=zyimin@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.