All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: David Buchanan <d@vidbuchanan.co.uk>, qemu-devel@nongnu.org
Cc: P J P <ppandit@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] vga: stop passing pointers to vga_draw_line* functions
Date: Mon, 09 Oct 2017 14:56:28 +0200	[thread overview]
Message-ID: <1507553788.32088.12.camel@redhat.com> (raw)
In-Reply-To: <e64a628c-3377-f3f5-0646-079a2a175354@vidbuchanan.co.uk>

On Mon, 2017-10-09 at 12:55 +0100, David Buchanan wrote:
> I might be mistaken, but I don't think this patch actually fixes
> CVE-2017-13672. I tested the latest git repo (last commit 530049bc1d)
> against my initial reproducer, and QEMU still segfaults.

Hmm, no segfault here.  Tried gtk, sdl, vnc, spice.  How do you start
qemu?  Which user interface?

> I think this is because the actual OOB read occurs inside pixman,
> which
> of course is not affected by this patch. Perhaps bounds checks need
> to
> be applied to the arguments passed into pixman?

Hmm, 24bpp modes are typically not handled by pixman (at least not in a
way that qemu creates a pixman image backed by vga memory).

Have you seen a stacktrace with pixman in there?  Care to share it?

thanks,
  Gerd

  reply	other threads:[~2017-10-09 12:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 12:29 [Qemu-devel] [PATCH v2] vga: stop passing pointers to vga_draw_line* functions Gerd Hoffmann
2017-10-09 11:55 ` David Buchanan
2017-10-09 12:56   ` Gerd Hoffmann [this message]
2017-10-09 13:09     ` David Buchanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507553788.32088.12.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=d@vidbuchanan.co.uk \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.