From: Chris Wilson <chris@chris-wilson.co.uk>
To: Michel Thierry <michel.thierry@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/lrc: Clear context restore/save inhibit flags for new contexts
Date: Thu, 25 Jan 2018 18:03:06 +0000 [thread overview]
Message-ID: <151690338635.674.2603677120854006165@mail.alporthouse.com> (raw)
In-Reply-To: <4a278ba6-cdf6-a420-1d96-b3b5a26d50bb@intel.com>
Quoting Michel Thierry (2018-01-25 17:49:49)
> On 1/25/2018 3:24 AM, Chris Wilson wrote:
> > CTX_CONTEXT_CONTROL (CTX_SR_CTL) operates as a masked register and so
> > will only apply the bits that are selected by the upper half. In the
> > case of selectively enabling sr inhibit, this may mean the context keeps
> > the current setting (so forgetting to save the context later, eventually
> > leading to a very upset GPU!).
>
> Oops, true no one would clear Context Save Inhibit once it's set.
>
> >
> > Fixes: d2b4b97933f5 ("drm/i915: Record the default hw state after reset upon load")
> Does it really fixes this one ^^^?
Actually, having added the BUG_ON, I had better not recommend back
porting to the earlier fixes.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-25 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 11:24 [PATCH 1/2] drm/i915/lrc: Clear context restore/save inhibit flags for new contexts Chris Wilson
2018-01-25 11:24 ` [PATCH 2/2] drm/i915/execlists: Remove the ring advancement under preemption Chris Wilson
2018-01-25 18:30 ` Michel Thierry
2018-01-25 11:47 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/lrc: Clear context restore/save inhibit flags for new contexts Patchwork
2018-01-25 13:52 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-01-25 17:49 ` [PATCH 1/2] " Michel Thierry
2018-01-25 17:52 ` Chris Wilson
2018-01-25 18:03 ` Chris Wilson [this message]
2018-01-25 18:23 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151690338635.674.2603677120854006165@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel.thierry@intel.com \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.