All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Kevin Easton <kevin@guarana.org>,
	Jason Wang <jasowang@redhat.com>,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: [PATCH] vhost: make msg padding explicit
Date: Fri, 27 Apr 2018 19:02:05 +0300	[thread overview]
Message-ID: <1524844881-178524-1-git-send-email-mst@redhat.com> (raw)

There's a 32 bit hole just after type. It's best to
give it a name, this way compiler is forced to initialize
it with rest of the structure.

Reported-by: Kevin Easton <kevin@guarana.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/uapi/linux/vhost.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index c51f8e5..5a8ad06 100644
--- a/include/uapi/linux/vhost.h
+++ b/include/uapi/linux/vhost.h
@@ -68,6 +68,7 @@ struct vhost_iotlb_msg {
 
 struct vhost_msg {
 	int type;
+	int padding0;
 	union {
 		struct vhost_iotlb_msg iotlb;
 		__u8 padding[64];
-- 
MST

             reply	other threads:[~2018-04-27 16:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 16:02 Michael S. Tsirkin [this message]
2018-04-30  1:34 ` [PATCH] vhost: make msg padding explicit David Miller
2018-04-30  1:34 ` David Miller
2018-05-01 15:28 ` David Miller
2018-05-01 17:19   ` Michael S. Tsirkin
2018-05-01 17:19   ` Michael S. Tsirkin
2018-05-01 18:05     ` David Miller
2018-05-01 18:05     ` David Miller
2018-05-02  6:28       ` Kevin Easton
2018-05-02 13:36         ` Michael S. Tsirkin
2018-05-02 13:36         ` Michael S. Tsirkin
2018-05-02 14:04           ` David Miller
2018-05-02 14:04             ` David Miller
2018-05-02 14:19             ` Michael S. Tsirkin
2018-05-02 14:19               ` Michael S. Tsirkin
2018-05-02 14:40               ` Kevin Easton
2018-05-01 15:28 ` David Miller
2018-04-27 16:02 Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524844881-178524-1-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kevin@guarana.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.