All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ppaalanen@gmail.com
Subject: [PATCH v13 05/10] video/hdmi: Reject illegal picture aspect ratios
Date: Wed,  2 May 2018 12:20:17 +0530	[thread overview]
Message-ID: <1525243822-19308-6-git-send-email-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <1525243822-19308-1-git-send-email-ankit.k.nautiyal@intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

AVI infoframe can only carry none, 4:3, or 16:9 picture aspect
ratios. Return an error if the user asked for something different.

Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: "Lin, Jia" <lin.a.jia@intel.com>
Cc: Akashdeep Sharma <akashdeep.sharma@intel.com>
Cc: Jim Bride <jim.bride@linux.intel.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: linux-media@vger.kernel.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jose Abreu <joabreu@synopsys.com>
---
 drivers/video/hdmi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
index 111a0ab..38716eb5 100644
--- a/drivers/video/hdmi.c
+++ b/drivers/video/hdmi.c
@@ -93,6 +93,9 @@ ssize_t hdmi_avi_infoframe_pack(struct hdmi_avi_infoframe *frame, void *buffer,
 	if (size < length)
 		return -ENOSPC;
 
+	if (frame->picture_aspect > HDMI_PICTURE_ASPECT_16_9)
+		return -EINVAL;
+
 	memset(buffer, 0, size);
 
 	ptr[0] = frame->type;
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-05-02  6:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  6:50 [PATCH v13 00/10] Aspect ratio support in DRM layer Nautiyal, Ankit K
2018-05-02  6:50 ` [PATCH v13 01/10] drm/modes: Introduce drm_mode_match() Nautiyal, Ankit K
2018-05-02  6:50 ` [PATCH v13 02/10] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy Nautiyal, Ankit K
2018-05-02  6:50 ` [PATCH v13 03/10] drm/edid: Fix cea mode aspect ratio handling Nautiyal, Ankit K
2018-05-02  6:50 ` [PATCH v13 04/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes Nautiyal, Ankit K
2018-05-02  6:50 ` Nautiyal, Ankit K [this message]
2018-05-02  6:50 ` [PATCH v13 06/10] drm: Add DRM client cap for aspect-ratio Nautiyal, Ankit K
2018-05-02  7:52   ` [Intel-gfx] " Daniel Vetter
2018-05-02  6:50 ` [PATCH v13 07/10] drm: Handle aspect ratio info in legacy modeset path Nautiyal, Ankit K
2018-05-02  7:56   ` [Intel-gfx] " Daniel Vetter
2018-05-02  6:50 ` [PATCH v13 08/10] drm: Expose modes with aspect ratio, only if requested Nautiyal, Ankit K
2018-05-03  6:26   ` Daniel Vetter
2018-05-04 20:19     ` Ville Syrjälä
2018-05-07  5:04       ` Nautiyal, Ankit K
2018-05-07 12:28         ` Ville Syrjälä
2018-05-07 12:52           ` Nautiyal, Ankit K
2018-05-07 13:36       ` Daniel Vetter
2018-05-02  6:50 ` [PATCH v13 09/10] drm: Add aspect ratio parsing in DRM layer Nautiyal, Ankit K
2018-05-02  6:50 ` [PATCH v13 10/10] drm: Add and handle new aspect ratios " Nautiyal, Ankit K
2018-05-02 10:00 ` ✗ Fi.CI.CHECKPATCH: warning for Aspect ratio support " Patchwork
2018-05-02 10:15 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-02 12:44 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525243822-19308-6-git-send-email-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ppaalanen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.