From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 10/24] drm/i915/icl: add icelake_get_ddi_pll() Date: Wed, 13 Jun 2018 16:51:57 -0700 Message-ID: <1528933917.2793.7.camel@intel.com> References: <20180522002558.29262-1-paulo.r.zanoni@intel.com> <20180522002558.29262-11-paulo.r.zanoni@intel.com> <20180613231443.GC17137@ldmartin-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id A44F46E1C9 for ; Wed, 13 Jun 2018 23:52:13 +0000 (UTC) In-Reply-To: <20180613231443.GC17137@ldmartin-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org RW0gUXVhLCAyMDE4LTA2LTEzIMOgcyAxNjoxNSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hpIGVzY3Jl dmV1Ogo+IE9uIE1vbiwgTWF5IDIxLCAyMDE4IGF0IDA1OjI1OjQ0UE0gLTA3MDAsIFBhdWxvIFph bm9uaSB3cm90ZToKPiA+IEltcGxlbWVudCB0aGUgaGFyZHdhcmUgc3RhdGUgcmVhZG91dCBjb2Rl Lgo+ID4gCj4gPiBUaGFua3MgdG8gQW5pbWVzaCBNYW5uYSBmb3Igc3BvdHRpbmcgdGhpcyBwcm9i bGVtLgo+ID4gCj4gPiBDYzogQW5pbWVzaCBNYW5uYSA8YW5pbWVzaC5tYW5uYUBpbnRlbC5jb20+ Cj4gPiBDcmVkaXRzLXRvOiBBbmltZXNoIE1hbm5hIDxhbmltZXNoLm1hbm5hQGludGVsLmNvbT4K PiA+IFNpZ25lZC1vZmYtYnk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29t Pgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNDIK PiA+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gIDEgZmlsZSBjaGFu Z2VkLCA0MSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCA2NDU5M2IwZmJlYmQuLmQ1YTE5YzFi M2IyMCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAt OTE0Niw2ICs5MTQ2LDQ0IEBAIHN0YXRpYyB2b2lkIGNhbm5vbmxha2VfZ2V0X2RkaV9wbGwoc3Ry dWN0Cj4gPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJcGlwZV9jb25maWctPnNo YXJlZF9kcGxsID0KPiA+IGludGVsX2dldF9zaGFyZWRfZHBsbF9ieV9pZChkZXZfcHJpdiwgaWQp Owo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgdm9pZCBpY2VsYWtlX2dldF9kZGlfcGxsKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICsJCQkJZW51bSBwb3J0IHBvcnQsCj4g PiArCQkJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlCj4gPiAqcGlwZV9jb25maWcpCj4gPiArewo+ ID4gKwllbnVtIGludGVsX2RwbGxfaWQgaWQ7Cj4gPiArCXUzMiB0ZW1wOwo+ID4gKwo+ID4gKwkv KiBUT0RPOiBUQlQgcGxsIG5vdCBpbXBsZW1lbnRlZC4gKi8KPiA+ICsJc3dpdGNoIChwb3J0KSB7 Cj4gPiArCWNhc2UgUE9SVF9BOgo+ID4gKwljYXNlIFBPUlRfQjoKPiA+ICsJCXRlbXAgPSBJOTE1 X1JFQUQoRFBDTEtBX0NGR0NSMF9JQ0wpICYKPiA+ICsJCSAgICAgICBEUENMS0FfQ0ZHQ1IwX0RE SV9DTEtfU0VMX01BU0socG9ydCk7Cj4gPiArCQlpZCA9IHRlbXAgPj4KPiA+IERQQ0xLQV9DRkdD UjBfRERJX0NMS19TRUxfU0hJRlQocG9ydCk7Cj4gCj4gVGhpcyBjb3VsZCBiZSBzaW1wbGVyOgo+ IAo+IAl0ZW1wID0gSTkxNV9SRUFEKERQQ0xLQV9DRkdDUjBfSUNMKSA+Pgo+IERQQ0xLQV9DRkdD UjBfRERJX0NMS19TRUxfU0hJRlQocG9ydCk7Cj4gCWlkID0gdGVtcCAmIERQQ0xLQV9DRkdDUjBf RERJX0NMS19TRUxfTUFTSygwKTsKCkkgZmFpbCB0byB1bmRlcnN0YW5kIHdoeSB0aGlzIGlzIHNp bXBsZXIuLi4gVGhlIHNhbWUgb3BlcmF0aW9ucywganVzdApvbiBhIGRpZmZlcmVudCBvcmRlci4K Cgo+IAo+IEJ1dCB0aGlzIHNoaXAgaGFzIHNhaWxlZCwgYWthIE1BU0sgYWJvdmUgcmVxdWlyZXMg dGhlIHBvcnQgYW5kCj4gaGFyZGNvZGluZyAwIGRvZXNuJ3QgbWFrZSBpdCBiZXR0ZXIgSU1PLgo+ IAo+IAo+IFJldmlld2VkLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVs LmNvbT4KPiAKClRoYW5rcyEKCj4gCj4gTHVjYXMgRGUgTWFyY2hpCj4gCj4gPiArCj4gPiArCQlp ZiAoV0FSTl9PTihpZCAhPSBEUExMX0lEX0lDTF9EUExMMCAmJiBpZCAhPQo+ID4gRFBMTF9JRF9J Q0xfRFBMTDEpKQo+ID4gKwkJCXJldHVybjsKPiA+ICsJCWJyZWFrOwo+ID4gKwljYXNlIFBPUlRf QzoKPiA+ICsJCWlkID0gRFBMTF9JRF9JQ0xfTUdQTEwxOwo+ID4gKwkJYnJlYWs7Cj4gPiArCWNh c2UgUE9SVF9EOgo+ID4gKwkJaWQgPSBEUExMX0lEX0lDTF9NR1BMTDI7Cj4gPiArCQlicmVhazsK PiA+ICsJY2FzZSBQT1JUX0U6Cj4gPiArCQlpZCA9IERQTExfSURfSUNMX01HUExMMzsKPiA+ICsJ CWJyZWFrOwo+ID4gKwljYXNlIFBPUlRfRjoKPiA+ICsJCWlkID0gRFBMTF9JRF9JQ0xfTUdQTEw0 Owo+ID4gKwkJYnJlYWs7Cj4gPiArCWRlZmF1bHQ6Cj4gPiArCQlNSVNTSU5HX0NBU0UocG9ydCk7 Cj4gPiArCQlyZXR1cm47Cj4gPiArCX0KPiA+ICsKPiA+ICsJcGlwZV9jb25maWctPnNoYXJlZF9k cGxsID0KPiA+IGludGVsX2dldF9zaGFyZWRfZHBsbF9ieV9pZChkZXZfcHJpdiwgaWQpOwo+ID4g K30KPiA+ICsKPiA+ICBzdGF0aWMgdm9pZCBieHRfZ2V0X2RkaV9wbGwoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAkJCQllbnVtIHBvcnQgcG9ydCwKPiA+ICAJCQkJc3Ry dWN0IGludGVsX2NydGNfc3RhdGUKPiA+ICpwaXBlX2NvbmZpZykKPiA+IEBAIC05MzMzLDcgKzkz NzEsOSBAQCBzdGF0aWMgdm9pZCBoYXN3ZWxsX2dldF9kZGlfcG9ydF9zdGF0ZShzdHJ1Y3QKPiA+ IGludGVsX2NydGMgKmNydGMsCj4gPiAgCj4gPiAgCXBvcnQgPSAodG1wICYgVFJBTlNfRERJX1BP UlRfTUFTSykgPj4KPiA+IFRSQU5TX0RESV9QT1JUX1NISUZUOwo+ID4gIAo+ID4gLQlpZiAoSVNf Q0FOTk9OTEFLRShkZXZfcHJpdikpCj4gPiArCWlmIChJU19JQ0VMQUtFKGRldl9wcml2KSkKPiA+ ICsJCWljZWxha2VfZ2V0X2RkaV9wbGwoZGV2X3ByaXYsIHBvcnQsIHBpcGVfY29uZmlnKTsKPiA+ ICsJZWxzZSBpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpCj4gPiAgCQljYW5ub25sYWtlX2dl dF9kZGlfcGxsKGRldl9wcml2LCBwb3J0LAo+ID4gcGlwZV9jb25maWcpOwo+ID4gIAllbHNlIGlm IChJU19HRU45X0JDKGRldl9wcml2KSkKPiA+ICAJCXNreWxha2VfZ2V0X2RkaV9wbGwoZGV2X3By aXYsIHBvcnQsIHBpcGVfY29uZmlnKTsKPiA+IC0tIAo+ID4gMi4xNC4zCj4gPiAKPiA+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK