From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 18/24] drm/i915/icl: implement icl_digital_port_connected() Date: Wed, 20 Jun 2018 14:01:07 -0700 Message-ID: <1529528467.27176.2.camel@intel.com> References: <20180522002558.29262-1-paulo.r.zanoni@intel.com> <20180522002558.29262-19-paulo.r.zanoni@intel.com> <20180619222845.GA32266@ldmartin-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFB4E89F97 for ; Wed, 20 Jun 2018 21:01:07 +0000 (UTC) In-Reply-To: <20180619222845.GA32266@ldmartin-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org RW0gVGVyLCAyMDE4LTA2LTE5IMOgcyAxNToyOCAtMDcwMCwgTHVjYXMgRGUgTWFyY2hpIGVzY3Jl dmV1Ogo+IE9uIE1vbiwgTWF5IDIxLCAyMDE4IGF0IDA1OjI1OjUyUE0gLTA3MDAsIFBhdWxvIFph bm9uaSB3cm90ZToKPiA+IERvIGxpa2UgdGhlIG90aGVyIGZ1bmN0aW9ucyBhbmQgY2hlY2sgZm9y IHRoZSBJU1IgYml0cy4gV2UgaGF2ZQo+ID4gcGxhbnMKPiA+IHRvIGFkZCBhIGZldyBtb3JlIGNo ZWNrcyBpbiB0aGlzIGNvZGUgaW4gdGhlIG5leHQgcGF0Y2hlcywgdGhhdCdzCj4gPiB3aHkKPiA+ IGl0J3MgYSBsaXR0bGUgbW9yZSB2ZXJib3NlIHRoYW4gaXQgY291bGQgYmUuCj4gPiAKPiA+IENj OiBBbmltZXNoIE1hbm5hIDxhbmltZXNoLm1hbm5hQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYt Ynk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9m Zi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCB8ICA1ICsrKysKPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgNTcKPiA+ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA2MiBpbnNlcnRpb25zKCspCj4g PiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPiBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+IGluZGV4IDQ5YTcyMzIwZTc5NC4u MjQzMDhkNDQzNWY1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9y ZWcuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gQEAgLTcw NTUsNiArNzA1NSw3IEBAIGVudW0gewo+ID4gICNkZWZpbmUgIEdFTjExX1RDM19IT1RQTFVHCQkJ KDEgPDwgMTgpCj4gPiAgI2RlZmluZSAgR0VOMTFfVEMyX0hPVFBMVUcJCQkoMSA8PCAxNykKPiA+ ICAjZGVmaW5lICBHRU4xMV9UQzFfSE9UUExVRwkJCSgxIDw8IDE2KQo+ID4gKyNkZWZpbmUgIEdF TjExX1RDX0hPVFBMVUcodGNfcG9ydCkJCSgxIDw8ICgodGNfcG9ydCkKPiA+ICsgMTYpKQo+ID4g ICNkZWZpbmUgIEdFTjExX0RFX1RDX0hPVFBMVUdfTUFTSwkJKEdFTjExX1RDNF9IT1RQTFUKPiA+ IEcgfCBcCj4gPiAgCQkJCQkJIEdFTjExX1RDM19IT1RQTFVHCj4gPiB8IFwKPiA+ICAJCQkJCQkg R0VOMTFfVEMyX0hPVFBMVUcKPiA+IHwgXAo+ID4gQEAgLTcwNjMsNiArNzA2NCw3IEBAIGVudW0g ewo+ID4gICNkZWZpbmUgIEdFTjExX1RCVDNfSE9UUExVRwkJCSgxIDw8IDIpCj4gPiAgI2RlZmlu ZSAgR0VOMTFfVEJUMl9IT1RQTFVHCQkJKDEgPDwgMSkKPiA+ICAjZGVmaW5lICBHRU4xMV9UQlQx X0hPVFBMVUcJCQkoMSA8PCAwKQo+ID4gKyNkZWZpbmUgIEdFTjExX1RCVF9IT1RQTFVHKHRjX3Bv cnQpCQkoMSA8PAo+ID4gKHRjX3BvcnQpKQo+ID4gICNkZWZpbmUgIEdFTjExX0RFX1RCVF9IT1RQ TFVHX01BU0sJCShHRU4xMV9UQlQ0X0hPVFAKPiA+IExVRyB8IFwKPiA+ICAJCQkJCQkgR0VOMTFf VEJUM19IT1RQTFUKPiA+IEcgfCBcCj4gPiAgCQkJCQkJIEdFTjExX1RCVDJfSE9UUExVCj4gPiBH IHwgXAo+ID4gQEAgLTc0ODYsNiArNzQ4OCw5IEBAIGVudW0gewo+ID4gICNkZWZpbmUgICBJQ1Bf R01CVVMJCQkoMSA8PCAyMykKPiA+ICAjZGVmaW5lICAgSUNQX0RESUJfSE9UUExVRwkJKDEgPDwg MTcpCj4gPiAgI2RlZmluZSAgIElDUF9ERElBX0hPVFBMVUcJCSgxIDw8IDE2KQo+ID4gKyNkZWZp bmUgSUNQX1RDX0hPVFBMVUcodGNfcG9ydCkJCSgxIDw8ICgodGNfcG9ydCkgKwo+ID4gMjQpKQo+ ID4gKyNkZWZpbmUgSUNQX0RESV9IT1RQTFVHKHBvcnQpCQkoMSA8PCAoKHBvcnQpICsgMTYpKQo+ ID4gKwo+ID4gIAo+ID4gICNkZWZpbmUgSUNQX1NERV9ERElfTUFTSwkJKElDUF9ERElCX0hPVFBM VUcgfAkKPiA+IFwKPiA+ICAJCQkJCSBJQ1BfRERJQV9IT1RQTFVHKQo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYwo+ID4gaW5kZXggMTAyMDcwOTQwMDk1Li5iNDc3MTI0NzE3ZTcgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBAQCAtNDcyMiw2ICs0NzIyLDYxIEBAIHN0 YXRpYyBib29sCj4gPiBieHRfZGlnaXRhbF9wb3J0X2Nvbm5lY3RlZChzdHJ1Y3QgaW50ZWxfZW5j b2RlciAqZW5jb2RlcikKPiA+ICAJcmV0dXJuIEk5MTVfUkVBRChHRU44X0RFX1BPUlRfSVNSKSAm IGJpdDsKPiA+ICB9Cj4gPiAgCj4gPiArc3RhdGljIGJvb2wgaWNsX2NvbWJvX3BvcnRfY29ubmVj dGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gPiAqZGV2X3ByaXYsCj4gPiArCQkJCSAgICAg c3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydAo+ID4gKmludGVsX2RpZ19wb3J0KQo+ID4gK3sKPiA+ ICsJZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5wb3J0Owo+ID4gKwo+ID4g KwlyZXR1cm4gSTkxNV9SRUFEKElDUF9TREVfSVNSKSAmIElDUF9ERElfSE9UUExVRyhwb3J0KTsK PiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGJvb2wgaWNsX3RjX3BvcnRfY29ubmVjdGVkKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlCj4gPiAqZGV2X3ByaXYsCj4gPiArCQkJCSAgc3RydWN0IGludGVs X2RpZ2l0YWxfcG9ydAo+ID4gKmludGVsX2RpZ19wb3J0KQo+ID4gK3sKPiA+ICsJZW51bSBwb3J0 IHBvcnQgPSBpbnRlbF9kaWdfcG9ydC0+YmFzZS5wb3J0Owo+ID4gKwllbnVtIHRjX3BvcnQgdGNf cG9ydCA9IGludGVsX3BvcnRfdG9fdGMoZGV2X3ByaXYsIHBvcnQpOwo+ID4gKwl1MzIgbGVnYWN5 X2JpdCA9IElDUF9UQ19IT1RQTFVHKHRjX3BvcnQpOwo+ID4gKwl1MzIgdHlwZWNfYml0ID0gR0VO MTFfVENfSE9UUExVRyh0Y19wb3J0KTsKPiA+ICsJdTMyIHRidF9iaXQgPSBHRU4xMV9UQlRfSE9U UExVRyh0Y19wb3J0KTsKPiA+ICsJYm9vbCBpc19sZWdhY3kgPSBmYWxzZSwgaXNfdHlwZWMgPSBm YWxzZSwgaXNfdGJ0ID0gZmFsc2U7Cj4gPiArCXUzMiBjcHVfaXNyOwo+IAo+IHdoeSAqY3B1Kl9p c3I/IGhwZF9pc3IsIGlzciBvciB2YWwgd291bGQgYmUgYmV0dGVyIElNTwoKQmVjYXVzZSB3ZSBo YXZlIDIgSVNSIHJlZ2lzdGVycyB3ZSBjaGVjaywgb25lIGlzIG9uIHRoZSBDUFUgYW5kIHRoZQpv dGhlciBpcyBvbiB0aGUgUENILiBXZSBqdXN0IGRvbid0IGhhdmUgYSB2YXJpYWJsZSBmb3IgcGNo X2lzciBiZWNhdXNlCndlIGRvbid0IG5lZWQuIEp1c2MgYWxsaW5nIGl0ICJpc3IiIG9yICJocGRf aXNyIiB3b3VsZCBiZSBtaXNsZWFkaW5nLgoKPiAKPiA+ICsKPiA+ICsJaWYgKEk5MTVfUkVBRChJ Q1BfU0RFX0lTUikgJiBsZWdhY3lfYml0KQo+ID4gKwkJaXNfbGVnYWN5ID0gdHJ1ZTsKPiA+ICsK PiA+ICsJY3B1X2lzciA9IEk5MTVfUkVBRChHRU4xMV9ERV9IUERfSVNSKTsKPiA+ICsJaWYgKGNw dV9pc3IgJiB0eXBlY19iaXQpCj4gPiArCQlpc190eXBlYyA9IHRydWU7Cj4gPiArCWlmIChjcHVf aXNyICYgdGJ0X2JpdCkKPiA+ICsJCWlzX3RidCA9IHRydWU7Cj4gPiArCj4gPiArCVdBUk5fT04o aXNfbGVnYWN5ICsgaXNfdHlwZWMgKyBpc190YnQgPiAxKTsKPiA+ICsJaWYgKCFpc19sZWdhY3kg JiYgIWlzX3R5cGVjICYmICFpc190YnQpCj4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiArCj4gPiAr CXJldHVybiB0cnVlOwo+IAo+IHlvdSBrbm93IHlvdSBjb3VsZCAicmV0dXJuIGlzX2xlZ2FjeSAr IGlzX3R5cGVjICsgaXNfdGJ0OyIsIHJpZ2h0Pwo+IHlvdQo+IGFyZSBhbHJlYWR5IGRvaW5nIGl0 IGFib3ZlLCBpdCBtYXkgbWFrZSBzZW5zZSB0byByZW1vdmUgdGhlIGV4dHJhCj4gYnJhbmNoLiBP ciBub3QuCgpCZWNhdXNlIHRoZSBuZXh0IHBhdGNoIGFkZHMgY29kZSBiZXR3ZWVuIHRoZSAicmV0 dXJuIGZhbHNlIiBhbmQgdGhlCmxhc3QgcmV0dXJuLCBzbyBJJ2QgaGF2ZSB0byBjaGFuZ2UgaXQg dGhlcmUuCgoKPiAKPiBGZWVsIGZyZWUgdG8gZGlzYWdyZWUgYW5kIHB1c2guCj4gCj4gCj4gUmV2 aWV3ZWQtYnk6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29tPgoKVGhh bmtzLApQYXVsbwoKPiAKPiAKPiBMdWNhcyBEZSBNYXJjaGkKPiAKPiA+ICt9Cj4gPiArCj4gPiAr c3RhdGljIGJvb2wgaWNsX2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoc3RydWN0IGludGVsX2VuY29k ZXIKPiA+ICplbmNvZGVyKQo+ID4gK3sKPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gdG9faTkxNShlbmNvZGVyLQo+ID4gPmJhc2UuZGV2KTsKPiA+ICsJc3RydWN0IGlu dGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPQo+ID4gZW5jX3RvX2RpZ19wb3J0KCZlbmNvZGVy LT5iYXNlKTsKPiA+ICsKPiA+ICsJc3dpdGNoIChlbmNvZGVyLT5ocGRfcGluKSB7Cj4gPiArCWNh c2UgSFBEX1BPUlRfQToKPiA+ICsJY2FzZSBIUERfUE9SVF9COgo+ID4gKwkJcmV0dXJuIGljbF9j b21ib19wb3J0X2Nvbm5lY3RlZChkZXZfcHJpdiwKPiA+IGRpZ19wb3J0KTsKPiA+ICsJY2FzZSBI UERfUE9SVF9DOgo+ID4gKwljYXNlIEhQRF9QT1JUX0Q6Cj4gPiArCWNhc2UgSFBEX1BPUlRfRToK PiA+ICsJY2FzZSBIUERfUE9SVF9GOgo+ID4gKwkJcmV0dXJuIGljbF90Y19wb3J0X2Nvbm5lY3Rl ZChkZXZfcHJpdiwgZGlnX3BvcnQpOwo+ID4gKwlkZWZhdWx0Ogo+ID4gKwkJTUlTU0lOR19DQVNF KGVuY29kZXItPmhwZF9waW4pOwo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gKwl9Cj4gPiArfQo+ ID4gKwo+ID4gIC8qCj4gPiAgICogaW50ZWxfZGlnaXRhbF9wb3J0X2Nvbm5lY3RlZCAtIGlzIHRo ZSBzcGVjaWZpZWQgcG9ydCBjb25uZWN0ZWQ/Cj4gPiAgICogQGVuY29kZXI6IGludGVsX2VuY29k ZXIKPiA+IEBAIC00NzQ5LDYgKzQ4MDQsOCBAQCBib29sIGludGVsX2RpZ2l0YWxfcG9ydF9jb25u ZWN0ZWQoc3RydWN0Cj4gPiBpbnRlbF9lbmNvZGVyICplbmNvZGVyKQo+ID4gIAkJcmV0dXJuIGJk d19kaWdpdGFsX3BvcnRfY29ubmVjdGVkKGVuY29kZXIpOwo+ID4gIAllbHNlIGlmIChJU19HRU45 X0xQKGRldl9wcml2KSkKPiA+ICAJCXJldHVybiBieHRfZGlnaXRhbF9wb3J0X2Nvbm5lY3RlZChl bmNvZGVyKTsKPiA+ICsJZWxzZSBpZiAoSVNfSUNFTEFLRShkZXZfcHJpdikpCj4gPiArCQlyZXR1 cm4gaWNsX2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoZW5jb2Rlcik7Cj4gPiAgCWVsc2UKPiA+ICAJ CXJldHVybiBzcHRfZGlnaXRhbF9wb3J0X2Nvbm5lY3RlZChlbmNvZGVyKTsKPiA+ICB9Cj4gPiAt LSAKPiA+IDIuMTQuMwo+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==