From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: david@fromorbit.com, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
sandeen@redhat.com
Subject: [PATCH 07/15] vfs: skip zero-length dedupe requests
Date: Thu, 04 Oct 2018 17:45:21 -0700 [thread overview]
Message-ID: <153870032167.29072.11158511021942868400.stgit@magnolia> (raw)
In-Reply-To: <153870027422.29072.7433543674436957232.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
Don't bother calling the filesystem for a zero-length dedupe request;
we can return zero and exit.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/read_write.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/read_write.c b/fs/read_write.c
index 973d3da78c09..99b2f809180c 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1966,6 +1966,11 @@ int vfs_dedupe_file_range_one(struct file *src_file, loff_t src_pos,
if (!dst_file->f_op->dedupe_file_range)
goto out_drop_write;
+ if (len == 0) {
+ ret = 0;
+ goto out_drop_write;
+ }
+
ret = dst_file->f_op->dedupe_file_range(src_file, src_pos,
dst_file, dst_pos, len);
out_drop_write:
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: david@fromorbit.com, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
sandeen@redhat.com
Subject: [Ocfs2-devel] [PATCH 07/15] vfs: skip zero-length dedupe requests
Date: Thu, 04 Oct 2018 17:45:21 -0700 [thread overview]
Message-ID: <153870032167.29072.11158511021942868400.stgit@magnolia> (raw)
In-Reply-To: <153870027422.29072.7433543674436957232.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
Don't bother calling the filesystem for a zero-length dedupe request;
we can return zero and exit.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/read_write.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/read_write.c b/fs/read_write.c
index 973d3da78c09..99b2f809180c 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1966,6 +1966,11 @@ int vfs_dedupe_file_range_one(struct file *src_file, loff_t src_pos,
if (!dst_file->f_op->dedupe_file_range)
goto out_drop_write;
+ if (len == 0) {
+ ret = 0;
+ goto out_drop_write;
+ }
+
ret = dst_file->f_op->dedupe_file_range(src_file, src_pos,
dst_file, dst_pos, len);
out_drop_write:
next prev parent reply other threads:[~2018-10-05 0:45 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 0:44 [PATCH 00/15] fs: fixes for serious clone/dedupe problems Darrick J. Wong
2018-10-05 0:44 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 0:44 ` [PATCH 01/15] xfs: add a per-xfs trace_printk macro Darrick J. Wong
2018-10-05 0:44 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 0:44 ` [PATCH 02/15] xfs: refactor clonerange preparation into a separate helper Darrick J. Wong
2018-10-05 0:44 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 5:28 ` Dave Chinner
2018-10-05 5:28 ` [Ocfs2-devel] " Dave Chinner
2018-10-05 17:06 ` Darrick J. Wong
2018-10-05 17:06 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-06 10:30 ` Christoph Hellwig
2018-10-06 10:30 ` [Ocfs2-devel] " Christoph Hellwig
2018-10-05 7:02 ` Dave Chinner
2018-10-05 7:02 ` [Ocfs2-devel] " Dave Chinner
2018-10-05 9:02 ` Dave Chinner
2018-10-05 9:02 ` [Ocfs2-devel] " Dave Chinner
2018-10-05 17:21 ` Darrick J. Wong
2018-10-05 17:21 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 23:42 ` Dave Chinner
2018-10-05 23:42 ` [Ocfs2-devel] " Dave Chinner
2018-10-05 0:44 ` [PATCH 03/15] xfs: zero posteof blocks when cloning above eof Darrick J. Wong
2018-10-05 0:44 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 5:28 ` Dave Chinner
2018-10-05 5:28 ` [Ocfs2-devel] " Dave Chinner
2018-10-06 10:34 ` Christoph Hellwig
2018-10-06 10:34 ` [Ocfs2-devel] " Christoph Hellwig
2018-10-05 0:45 ` [PATCH 04/15] xfs: update ctime and remove suid before cloning files Darrick J. Wong
2018-10-05 0:45 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 5:30 ` Dave Chinner
2018-10-05 5:30 ` [Ocfs2-devel] " Dave Chinner
2018-10-06 10:35 ` Christoph Hellwig
2018-10-06 10:35 ` [Ocfs2-devel] " Christoph Hellwig
2018-10-05 0:45 ` [PATCH 05/15] vfs: check file ranges " Darrick J. Wong
2018-10-05 0:45 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-06 10:38 ` Christoph Hellwig
2018-10-06 10:38 ` [Ocfs2-devel] " Christoph Hellwig
2018-10-05 0:45 ` [PATCH 06/15] vfs: strengthen checking of file range inputs to clone/dedupe range Darrick J. Wong
2018-10-05 0:45 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 6:10 ` Amir Goldstein
2018-10-05 17:36 ` Darrick J. Wong
2018-10-05 17:36 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 0:45 ` Darrick J. Wong [this message]
2018-10-05 0:45 ` [Ocfs2-devel] [PATCH 07/15] vfs: skip zero-length dedupe requests Darrick J. Wong
2018-10-05 8:39 ` Amir Goldstein
2018-10-06 10:39 ` Christoph Hellwig
2018-10-06 10:39 ` [Ocfs2-devel] " Christoph Hellwig
2018-10-05 0:45 ` [PATCH 08/15] vfs: change clone and dedupe range function pointers to return bytes completed Darrick J. Wong
2018-10-05 0:45 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 8:06 ` Amir Goldstein
2018-10-05 21:47 ` Darrick J. Wong
2018-10-05 21:47 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-06 10:41 ` Christoph Hellwig
2018-10-06 10:41 ` [Ocfs2-devel] " Christoph Hellwig
2018-10-08 18:59 ` Darrick J. Wong
2018-10-08 18:59 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 0:45 ` [PATCH 09/15] vfs: pass operation flags to {clone, dedupe}_file_range implementations Darrick J. Wong
2018-10-05 0:45 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 7:07 ` Amir Goldstein
2018-10-05 17:50 ` Darrick J. Wong
2018-10-05 17:50 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-06 10:44 ` Christoph Hellwig
2018-10-06 10:44 ` [Ocfs2-devel] " Christoph Hellwig
2018-10-05 0:45 ` [PATCH 10/15] vfs: make cloning to source file eof more explicit Darrick J. Wong
2018-10-05 0:45 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 6:47 ` Amir Goldstein
2018-10-05 0:45 ` [PATCH 11/15] vfs: allow short clone and dedupe operations Darrick J. Wong
2018-10-05 0:45 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 0:46 ` [PATCH 12/15] vfs: implement opportunistic short dedupe Darrick J. Wong
2018-10-05 0:46 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 6:40 ` Amir Goldstein
2018-10-05 17:42 ` Darrick J. Wong
2018-10-05 17:42 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 0:46 ` [PATCH 13/15] ocfs2: truncate page cache for clone destination file before remapping Darrick J. Wong
2018-10-05 0:46 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 0:46 ` [PATCH 14/15] ocfs2: support partial clone range and dedupe range Darrick J. Wong
2018-10-05 0:46 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 0:46 ` [PATCH 15/15] xfs: support returning partial reflink results Darrick J. Wong
2018-10-05 0:46 ` [Ocfs2-devel] " Darrick J. Wong
2018-10-05 1:17 ` [PATCH 00/15] fs: fixes for serious clone/dedupe problems Dave Chinner
2018-10-05 1:17 ` [Ocfs2-devel] " Dave Chinner
2018-10-05 1:24 ` Darrick J. Wong
2018-10-05 1:24 ` [Ocfs2-devel] " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153870032167.29072.11158511021942868400.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.