All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Gong <yibin.gong@nxp.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: [PATCH v1 0/3] Correct wml setting for spi-imx in dma mode
Date: Wed, 10 Oct 2018 10:32:39 +0000	[thread overview]
Message-ID: <1539196453-8704-1-git-send-email-yibin.gong@nxp.com> (raw)


Current dynamic burst length is based on the whole transfer length,
that's ok if there is only one sg, but is not right in case multi sgs
in one transfer,because the tail data should be based on the last sg
length instead of the whole transfer length. Othwise, the last dma
done interrupt will never be triggered. It could be caught in
mtd_stresstest case without this patchset as below:

insmod mtd_stresstest.ko dev=0
=================================================
mtd_stresstest: MTD device: 0
mtd_stresstest: not NAND flash, assume page size is 512 bytes.
mtd_stresstest: MTD device size 4194304, eraseblock size 65536, page size 512, count of eraseblocks 64, pa0
mtd_stresstest: doing operations
mtd_stresstest: 0 operations done
mtd_test: mtd_read from 1ff532, size 880
mtd_test: mtd_read from 20c267, size 64998
spi_master spi0: I/O Error in DMA RX
m25p80 spi0.0: SPI transfer failed: -110
spi_master spi0: failed to transfer one message from queue
mtd_test: error: read failed at 0x20c267
mtd_stresstest: error -110 occurred
=================================================
insmod: ERROR: could not insert module mtd_stresstest.ko: Connection timed out

Robin Gong (3):
  spi: imx: move wml setting to later than setup_transfer
  spi: imx: correct wml as the last sg length
  spi: imx: use PIO mode if size is small

 drivers/spi/spi-imx.c | 53 ++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 35 insertions(+), 18 deletions(-)

-- 
2.7.4


             reply	other threads:[~2018-10-10 10:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 10:32 Robin Gong [this message]
2018-10-10 10:32 ` [PATCH v1 1/3] spi: imx: move wml setting to later than setup_transfer Robin Gong
2018-10-12 17:01   ` Applied "spi: imx: move wml setting to later than setup_transfer" to the spi tree Mark Brown
2018-10-12 17:01     ` Mark Brown
2018-10-10 10:32 ` [PATCH v1 2/3] spi: imx: correct wml as the last sg length Robin Gong
2018-10-10 10:32 ` [PATCH v1 3/3] spi: imx: use PIO mode if size is small Robin Gong
2018-10-12 17:01   ` Applied "spi: imx: use PIO mode if size is small" to the spi tree Mark Brown
2018-10-12 17:01     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539196453-8704-1-git-send-email-yibin.gong@nxp.com \
    --to=yibin.gong@nxp.com \
    --cc=broonie@kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.