All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: thierry.reding@gmail.com
Cc: linux-pwm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: [PATCH 3/5] pwm: rcar: Use "atomic" API on rcar_pwm_resume()
Date: Fri,  7 Dec 2018 17:29:31 +0900	[thread overview]
Message-ID: <1544171373-29618-4-git-send-email-yoshihiro.shimoda.uh@renesas.com> (raw)
In-Reply-To: <1544171373-29618-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>

To remove legacy API related functions in the future, this patch
uses "atomic" related function instead. No change in behavior.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 drivers/pwm/pwm-rcar.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/pwm/pwm-rcar.c b/drivers/pwm/pwm-rcar.c
index a5ea0f3..1bcb662 100644
--- a/drivers/pwm/pwm-rcar.c
+++ b/drivers/pwm/pwm-rcar.c
@@ -319,18 +319,16 @@ static int rcar_pwm_suspend(struct device *dev)
 static int rcar_pwm_resume(struct device *dev)
 {
 	struct pwm_device *pwm = rcar_pwm_dev_to_pwm_dev(dev);
+	struct pwm_state state;
 
 	if (!test_bit(PWMF_REQUESTED, &pwm->flags))
 		return 0;
 
 	pm_runtime_get_sync(dev);
 
-	rcar_pwm_config(pwm->chip, pwm, pwm->state.duty_cycle,
-			pwm->state.period);
-	if (pwm_is_enabled(pwm))
-		rcar_pwm_enable(pwm->chip, pwm);
+	pwm_get_state(pwm, &state);
 
-	return 0;
+	return rcar_pwm_apply(pwm->chip, pwm, &state);
 }
 #endif /* CONFIG_PM_SLEEP */
 static SIMPLE_DEV_PM_OPS(rcar_pwm_pm_ops, rcar_pwm_suspend, rcar_pwm_resume);
-- 
1.9.1

  parent reply	other threads:[~2018-12-07  8:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07  8:29 [PATCH 0/5] pwm: rcar: Add support "atomic" API and workaround Yoshihiro Shimoda
2018-12-07  8:29 ` [PATCH 1/5] pwm: rcar: add rcar_pwm_calc_counter() to calculate PWMCNT value only Yoshihiro Shimoda
2018-12-07  9:00   ` Uwe Kleine-König
2018-12-07  9:00     ` Uwe Kleine-König
2018-12-07  8:29 ` [PATCH 2/5] pwm: rcar: Add support "atomic" API Yoshihiro Shimoda
2018-12-07  9:07   ` Uwe Kleine-König
2018-12-07  9:07     ` Uwe Kleine-König
2018-12-07  9:57     ` Geert Uytterhoeven
2018-12-07 10:45       ` Uwe Kleine-König
2018-12-07 10:45         ` Uwe Kleine-König
2018-12-10  4:58         ` Yoshihiro Shimoda
2018-12-07  8:29 ` Yoshihiro Shimoda [this message]
2018-12-07  8:29 ` [PATCH 4/5] pwm: rcar: remove legacy APIs Yoshihiro Shimoda
2018-12-07  8:29 ` [PATCH 5/5] pwm: rcar: add workaround to output "pseudo" low level Yoshihiro Shimoda
2018-12-07  9:13   ` Uwe Kleine-König
2018-12-07  9:13     ` Uwe Kleine-König
2018-12-10  4:49     ` Yoshihiro Shimoda
2018-12-10  8:11       ` Uwe Kleine-König
2018-12-10  8:11         ` Uwe Kleine-König
2018-12-12  3:19         ` Yoshihiro Shimoda
2018-12-12  3:19           ` Yoshihiro Shimoda
2018-12-12  7:37           ` Uwe Kleine-König
2018-12-12  7:37             ` Uwe Kleine-König
2018-12-12 10:49             ` Yoshihiro Shimoda
2018-12-12 10:49               ` Yoshihiro Shimoda
2018-12-13  9:47     ` Yoshihiro Shimoda
2018-12-13  9:47       ` Yoshihiro Shimoda
2018-12-13  9:52       ` Uwe Kleine-König
2018-12-13  9:52         ` Uwe Kleine-König
2018-12-13 10:53         ` Yoshihiro Shimoda
2018-12-13 10:53           ` Yoshihiro Shimoda
2018-12-07 21:49 ` pwm: rcar: improve calculation of divider Uwe Kleine-König
2018-12-07 21:49   ` Uwe Kleine-König
2018-12-09 20:55   ` Laurent Pinchart
2018-12-10  5:09     ` Yoshihiro Shimoda
2018-12-10  8:04       ` Uwe Kleine-König
2018-12-10  8:04         ` Uwe Kleine-König
2018-12-12  3:13         ` Yoshihiro Shimoda
2018-12-12  3:13           ` Yoshihiro Shimoda
2018-12-09 22:48 ` [PATCH 0/5] pwm: rcar: Add support "atomic" API and workaround Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1544171373-29618-4-git-send-email-yoshihiro.shimoda.uh@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.