Re: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190218125615.18970-1-armbru@redhat.com
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190218125615.18970-1-armbru@redhat.com -> patchew/20190218125615.18970-1-armbru@redhat.com
 t [tag update]            patchew/20190219060719.8211-1-richardw.yang@linux.intel.com -> patchew/20190219060719.8211-1-richardw.yang@linux.intel.com
 * [new tag]               patchew/20190219124257.3001-1-kraxel@redhat.com -> patchew/20190219124257.3001-1-kraxel@redhat.com
Switched to a new branch 'test'
eadbdde93b hw/arm hw/xtensa: De-duplicate pflash creation code some
66b962dbf3 pflash: Clean up after commit 368a354f02b part 2
5284500a74 pflash: Clean up after commit 368a354f02b part 1
09d2c4a708 mips_malta: Clean up definition of flash memory size somewhat
370f0b5929 r2d: Flash memory creation is confused about size, mark FIXME
a44365fece ppc405_boards: Don't size flash memory to match backing image
e6dcc28b89 sam460ex: Don't size flash memory to match backing image
b554480ef5 hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
d750905bcc pflash: Macro PFLASH_BUG() is used just once, expand
ec3e8745cd pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02

=== OUTPUT BEGIN ===
1/10 Checking commit ec3e8745cdd8 (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#128: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,

ERROR: space prohibited between function name and open parenthesis '('
#340: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,

ERROR: space prohibited between function name and open parenthesis '('
#358: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,

total: 3 errors, 0 warnings, 483 lines checked

Patch 1/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/10 Checking commit d750905bcc59 (pflash: Macro PFLASH_BUG() is used just once, expand)
3/10 Checking commit b554480ef5e6 (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit e6dcc28b8994 (sam460ex: Don't size flash memory to match backing image)
5/10 Checking commit a44365fece7c (ppc405_boards: Don't size flash memory to match backing image)
6/10 Checking commit 370f0b59294b (r2d: Flash memory creation is confused about size, mark FIXME)
7/10 Checking commit 09d2c4a70817 (mips_malta: Clean up definition of flash memory size somewhat)
8/10 Checking commit 5284500a7468 (pflash: Clean up after commit 368a354f02b part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#90: FILE: hw/arm/musicpal.c:1639:
+        pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
                                             ^

ERROR: spaces required around that '-' (ctx:VxV)
#98: FILE: hw/arm/musicpal.c:1646:
+        pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
                                             ^

total: 2 errors, 0 warnings, 248 lines checked

Patch 8/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/10 Checking commit 66b962dbf392 (pflash: Clean up after commit 368a354f02b part 2)
10/10 Checking commit eadbdde93b39 (hw/arm hw/xtensa: De-duplicate pflash creation code some)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190218125615.18970-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com