From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98228C43381 for ; Thu, 7 Mar 2019 02:03:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55C6820661 for ; Thu, 7 Mar 2019 02:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbfCGCDG (ORCPT ); Wed, 6 Mar 2019 21:03:06 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:9425 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726387AbfCGCDG (ORCPT ); Wed, 6 Mar 2019 21:03:06 -0500 X-UUID: 7a844161cced4d65b600355225dfcc5f-20190307 X-UUID: 7a844161cced4d65b600355225dfcc5f-20190307 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1841580134; Thu, 07 Mar 2019 10:02:58 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 7 Mar 2019 10:02:57 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 7 Mar 2019 10:02:56 +0800 Message-ID: <1551924176.2210.104.camel@mhfsdcap03> Subject: Re: [PATCH v2 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue From: Chunfeng Yun To: Neil Armstrong CC: , , , , , , , Date: Thu, 7 Mar 2019 10:02:56 +0800 In-Reply-To: <20190304103846.2060-9-narmstrong@baylibre.com> References: <20190304103846.2060-1-narmstrong@baylibre.com> <20190304103846.2060-9-narmstrong@baylibre.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, 2019-03-04 at 11:38 +0100, Neil Armstrong wrote: > Adds support for Amlogic G12A USB Control Glue HW. > > The Amlogic G12A SoC Family embeds 2 USB Controllers : > - a DWC3 IP configured as Host for USB2 and USB3 > - a DWC2 IP configured as Peripheral USB2 Only > > A glue connects these both controllers to 2 USB2 PHYs, and optionnally > to an USB3+PCIE Combo PHY shared with the PCIE controller. > > The Glue configures the UTMI 8bit interfaces for the USB2 PHYs, including > routing of the OTG PHY between the DWC3 and DWC2 controllers, and > setups the on-chip OTG mode selection for this PHY. > > This drivers supports the on-probe setup of the OTG mode, and manually > via a debugfs interface. The IRQ mode change detect is yet to be added > in a future patchset, mainly due to lack of hardware to validate on. > > Signed-off-by: Neil Armstrong > --- > drivers/usb/dwc3/Kconfig | 10 + > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-meson-g12a.c | 601 +++++++++++++++++++++++++++++ > 3 files changed, 612 insertions(+) > create mode 100644 drivers/usb/dwc3/dwc3-meson-g12a.c > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 1a0404fda596..21ce7368d325 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -93,6 +93,16 @@ config USB_DWC3_KEYSTONE > Support of USB2/3 functionality in TI Keystone2 platforms. > Say 'Y' or 'M' here if you have one such device > > +config USB_DWC3_MESON_G12A > + tristate "Amlogic Meson G12A Platforms" > + depends on OF && COMMON_CLK > + depends on ARCH_MESON || COMPILE_TEST > + default USB_DWC3 > + select USB_ROLE_SWITCH > + help > + Support USB2/3 functionality in Amlogic G12A platforms. > + Say 'Y' or 'M' if you have one such device. > + > config USB_DWC3_OF_SIMPLE > tristate "Generic OF Simple Glue Layer" > depends on OF && COMMON_CLK > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile > index 6e3ef6144e5d..ae86da0dc5bd 100644 > --- a/drivers/usb/dwc3/Makefile > +++ b/drivers/usb/dwc3/Makefile > @@ -47,6 +47,7 @@ obj-$(CONFIG_USB_DWC3_EXYNOS) += dwc3-exynos.o > obj-$(CONFIG_USB_DWC3_PCI) += dwc3-pci.o > obj-$(CONFIG_USB_DWC3_HAPS) += dwc3-haps.o > obj-$(CONFIG_USB_DWC3_KEYSTONE) += dwc3-keystone.o > +obj-$(CONFIG_USB_DWC3_MESON_G12A) += dwc3-meson-g12a.o > obj-$(CONFIG_USB_DWC3_OF_SIMPLE) += dwc3-of-simple.o > obj-$(CONFIG_USB_DWC3_ST) += dwc3-st.o > obj-$(CONFIG_USB_DWC3_QCOM) += dwc3-qcom.o > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c > new file mode 100644 > index 000000000000..75942614a034 > --- /dev/null > +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c > @@ -0,0 +1,601 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * USB Glue for Amlogic G12A SoCs > + * > + * Copyright (c) 2019 BayLibre, SAS > + * Author: Neil Armstrong > + */ > + > +/* > + * The USB is organized with a glue around the DWC3 Controller IP as : > + * - Control registers for each USB2 Ports > + * - Control registers for the USB PHY layer > + * - SuperSpeed PHY can be enabled only if port is used > + * > + * TOFIX: > + * - Add dynamic OTG switching with ID change interrupt > + */ > + [...] > + > +static int dwc3_meson_g12a_probe(struct platform_device *pdev) > +{ > + struct dwc3_meson_g12a *priv; > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + void __iomem *base; > + struct resource *res; > + enum phy_mode otg_id; > + int ret, i; > + > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + base = devm_ioremap_resource(dev, res); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + > + priv->regmap = devm_regmap_init_mmio(dev, base, > + &phy_meson_g12a_usb3_regmap_conf); > + if (IS_ERR(priv->regmap)) > + return PTR_ERR(priv->regmap); > + > + priv->vbus = devm_regulator_get_optional(dev, "vbus"); > + if (IS_ERR(priv->vbus)) { > + if (PTR_ERR(priv->vbus) == -EPROBE_DEFER) > + return PTR_ERR(priv->vbus); > + priv->vbus = NULL; > + } > + > + priv->clk = devm_clk_get(dev, NULL); > + if (IS_ERR(priv->clk)) > + return PTR_ERR(priv->clk); > + > + ret = clk_prepare_enable(priv->clk); > + if (ret) > + return ret; > + > + platform_set_drvdata(pdev, priv); > + priv->dev = dev; > + > + priv->reset = devm_reset_control_get(dev, NULL); > + if (IS_ERR(priv->reset)) { > + ret = PTR_ERR(priv->reset); > + dev_err(dev, "failed to get device reset, err=%d\n", ret); > + return ret; > + } > + > + ret = reset_control_reset(priv->reset); > + if (ret) > + return ret; > + > + ret = dwc3_meson_g12a_get_phys(priv); > + if (ret) > + return ret; > + > + ret = regulator_enable(priv->vbus); > + if (ret) > + return ret; > + > + /* Get dr_mode */ > + priv->otg_mode = usb_get_dr_mode(dev); > + > + dwc3_meson_g12a_usb_init(priv); > + > + /* Set PHY Power */ > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + ret = phy_power_on(priv->phys[i]); > + if (ret) > + goto err_phys_put; > + } > + > + /* Init PHYs */ > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + ret = phy_init(priv->phys[i]); > + if (ret) > + goto err_phys_power; > + } usually phy_init() first > + > + ret = of_platform_populate(np, NULL, NULL, dev); > + if (ret) { > + clk_disable_unprepare(priv->clk); > + clk_put(priv->clk); > + > + goto err_phys_exit; > + } > + > + /* Setup OTG mode corresponding to the ID pin */ > + if (priv->otg_mode == USB_DR_MODE_OTG) { > + /* TOFIX Handle ID mode toggling via IRQ */ > + otg_id = dwc3_meson_g12a_get_id(priv); > + if (otg_id != priv->otg_phy_mode) { > + if (dwc3_meson_g12a_otg_mode_set(priv, otg_id)) > + dev_warn(dev, "Failed to switch OTG mode\n"); > + } > + } > + > + /* Setup role switcher */ > + priv->switch_desc.usb2_port = dwc3_meson_g12_find_child(dev, > + "snps,dwc3"); > + priv->switch_desc.udc = dwc3_meson_g12_find_child(dev, "snps,dwc2"); > + priv->switch_desc.allow_userspace_control = true; > + priv->switch_desc.set = dwc3_meson_g12a_role_set; > + priv->switch_desc.get = dwc3_meson_g12a_role_get; to me, use a local variable for switch_desc > + > + priv->role_switch = usb_role_switch_register(dev, &priv->switch_desc); > + if (IS_ERR(priv->role_switch)) > + dev_warn(dev, "Unable to register Role Switch\n"); > + > + pm_runtime_set_active(dev); > + pm_runtime_enable(dev); > + pm_runtime_get_sync(dev); > + > + return 0; > + > +err_phys_exit: > + for (i = 0 ; i < PHY_COUNT ; ++i) > + phy_exit(priv->phys[i]); > + > +err_phys_power: > + for (i = 0 ; i < PHY_COUNT ; ++i) > + phy_power_off(priv->phys[i]); > + > +err_phys_put: > + for (i = 0 ; i < PHY_COUNT ; ++i) > + phy_put(priv->phys[i]); > + The phys are got by devm_phy_optional_get(), no need call phy_put() > + return ret; > +} > + > +static int dwc3_meson_g12a_remove(struct platform_device *pdev) > +{ > + struct dwc3_meson_g12a *priv = platform_get_drvdata(pdev); > + struct device *dev = &pdev->dev; > + int i; > + > + usb_role_switch_unregister(priv->role_switch); > + > + of_platform_depopulate(dev); > + > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + phy_power_off(priv->phys[i]); > + phy_exit(priv->phys[i]); > + phy_put(priv->phys[i]); ditto > + } > + > + clk_disable_unprepare(priv->clk); > + clk_put(priv->clk); > + > + pm_runtime_disable(dev); > + pm_runtime_put_noidle(dev); > + pm_runtime_set_suspended(dev); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_meson_g12a_runtime_suspend(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + > + clk_disable(priv->clk); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_meson_g12a_runtime_resume(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + > + return clk_enable(priv->clk); > +} > + > +static int __maybe_unused dwc3_meson_g12a_suspend(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + int i; > + > + for (i = 0 ; i < PHY_COUNT ; ++i) > + if (priv->phys[i]) > + phy_exit(priv->phys[i]); > + > + reset_control_assert(priv->reset); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_meson_g12a_resume(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + int i, ret; > + > + reset_control_deassert(priv->reset); > + > + dwc3_meson_g12a_usb_init(priv); > + > + /* Init PHYs */ > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + if (priv->phys[i]) { > + ret = phy_init(priv->phys[i]); > + if (ret) > + return ret; > + } > + } > + > + return 0; > +} > + > +static const struct dev_pm_ops dwc3_meson_g12a_dev_pm_ops = { > + SET_SYSTEM_SLEEP_PM_OPS(dwc3_meson_g12a_suspend, dwc3_meson_g12a_resume) > + SET_RUNTIME_PM_OPS(dwc3_meson_g12a_runtime_suspend, > + dwc3_meson_g12a_runtime_resume, NULL) > +}; > + > +static const struct of_device_id dwc3_meson_g12a_match[] = { > + { .compatible = "amlogic,meson-g12a-usb-ctrl" }, > + { /* Sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, dwc3_meson_g12a_match); > + > +static struct platform_driver dwc3_meson_g12a_driver = { > + .probe = dwc3_meson_g12a_probe, > + .remove = dwc3_meson_g12a_remove, > + .driver = { > + .name = "dwc3-meson-g12a", > + .of_match_table = dwc3_meson_g12a_match, > + .pm = &dwc3_meson_g12a_dev_pm_ops, > + }, > +}; > + > +module_platform_driver(dwc3_meson_g12a_driver); > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("Amlogic Meson G12A USB Glue Layer"); > +MODULE_AUTHOR("Neil Armstrong "); From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,8/8] usb: dwc3: Add Amlogic G12A DWC3 glue From: Chunfeng Yun Message-Id: <1551924176.2210.104.camel@mhfsdcap03> Date: Thu, 7 Mar 2019 10:02:56 +0800 To: Neil Armstrong Cc: gregkh@linuxfoundation.org, hminas@synopsys.com, balbi@kernel.org, kishon@ti.com, linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: SGksCk9uIE1vbiwgMjAxOS0wMy0wNCBhdCAxMTozOCArMDEwMCwgTmVpbCBBcm1zdHJvbmcgd3Jv dGU6Cj4gQWRkcyBzdXBwb3J0IGZvciBBbWxvZ2ljIEcxMkEgVVNCIENvbnRyb2wgR2x1ZSBIVy4K PiAKPiBUaGUgQW1sb2dpYyBHMTJBIFNvQyBGYW1pbHkgZW1iZWRzIDIgVVNCIENvbnRyb2xsZXJz IDoKPiAtIGEgRFdDMyBJUCBjb25maWd1cmVkIGFzIEhvc3QgZm9yIFVTQjIgYW5kIFVTQjMKPiAt IGEgRFdDMiBJUCBjb25maWd1cmVkIGFzIFBlcmlwaGVyYWwgVVNCMiBPbmx5Cj4gCj4gQSBnbHVl IGNvbm5lY3RzIHRoZXNlIGJvdGggY29udHJvbGxlcnMgdG8gMiBVU0IyIFBIWXMsIGFuZCBvcHRp b25uYWxseQo+IHRvIGFuIFVTQjMrUENJRSBDb21ibyBQSFkgc2hhcmVkIHdpdGggdGhlIFBDSUUg Y29udHJvbGxlci4KPiAKPiBUaGUgR2x1ZSBjb25maWd1cmVzIHRoZSBVVE1JIDhiaXQgaW50ZXJm YWNlcyBmb3IgdGhlIFVTQjIgUEhZcywgaW5jbHVkaW5nCj4gcm91dGluZyBvZiB0aGUgT1RHIFBI WSBiZXR3ZWVuIHRoZSBEV0MzIGFuZCBEV0MyIGNvbnRyb2xsZXJzLCBhbmQKPiBzZXR1cHMgdGhl IG9uLWNoaXAgT1RHIG1vZGUgc2VsZWN0aW9uIGZvciB0aGlzIFBIWS4KPiAKPiBUaGlzIGRyaXZl cnMgc3VwcG9ydHMgdGhlIG9uLXByb2JlIHNldHVwIG9mIHRoZSBPVEcgbW9kZSwgYW5kIG1hbnVh bGx5Cj4gdmlhIGEgZGVidWdmcyBpbnRlcmZhY2UuIFRoZSBJUlEgbW9kZSBjaGFuZ2UgZGV0ZWN0 IGlzIHlldCB0byBiZSBhZGRlZAo+IGluIGEgZnV0dXJlIHBhdGNoc2V0LCBtYWlubHkgZHVlIHRv IGxhY2sgb2YgaGFyZHdhcmUgdG8gdmFsaWRhdGUgb24uCj4gCj4gU2lnbmVkLW9mZi1ieTogTmVp bCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3Vz Yi9kd2MzL0tjb25maWcgICAgICAgICAgIHwgIDEwICsKPiAgZHJpdmVycy91c2IvZHdjMy9NYWtl ZmlsZSAgICAgICAgICB8ICAgMSArCj4gIGRyaXZlcnMvdXNiL2R3YzMvZHdjMy1tZXNvbi1nMTJh LmMgfCA2MDEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMyBmaWxlcyBjaGFuZ2Vk LCA2MTIgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy91c2IvZHdj My9kd2MzLW1lc29uLWcxMmEuYwo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9kd2MzL0tj b25maWcgYi9kcml2ZXJzL3VzYi9kd2MzL0tjb25maWcKPiBpbmRleCAxYTA0MDRmZGE1OTYuLjIx Y2U3MzY4ZDMyNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi9kd2MzL0tjb25maWcKPiArKysg Yi9kcml2ZXJzL3VzYi9kd2MzL0tjb25maWcKPiBAQCAtOTMsNiArOTMsMTYgQEAgY29uZmlnIFVT Ql9EV0MzX0tFWVNUT05FCj4gIAkgIFN1cHBvcnQgb2YgVVNCMi8zIGZ1bmN0aW9uYWxpdHkgaW4g VEkgS2V5c3RvbmUyIHBsYXRmb3Jtcy4KPiAgCSAgU2F5ICdZJyBvciAnTScgaGVyZSBpZiB5b3Ug aGF2ZSBvbmUgc3VjaCBkZXZpY2UKPiAgCj4gK2NvbmZpZyBVU0JfRFdDM19NRVNPTl9HMTJBCj4g KyAgICAgICB0cmlzdGF0ZSAiQW1sb2dpYyBNZXNvbiBHMTJBIFBsYXRmb3JtcyIKPiArICAgICAg IGRlcGVuZHMgb24gT0YgJiYgQ09NTU9OX0NMSwo+ICsgICAgICAgZGVwZW5kcyBvbiBBUkNIX01F U09OIHx8IENPTVBJTEVfVEVTVAo+ICsgICAgICAgZGVmYXVsdCBVU0JfRFdDMwo+ICsgICAgICAg c2VsZWN0IFVTQl9ST0xFX1NXSVRDSAo+ICsgICAgICAgaGVscAo+ICsgICAgICAgICBTdXBwb3J0 IFVTQjIvMyBmdW5jdGlvbmFsaXR5IGluIEFtbG9naWMgRzEyQSBwbGF0Zm9ybXMuCj4gKwkgU2F5 ICdZJyBvciAnTScgaWYgeW91IGhhdmUgb25lIHN1Y2ggZGV2aWNlLgo+ICsKPiAgY29uZmlnIFVT Ql9EV0MzX09GX1NJTVBMRQo+ICAgICAgICAgdHJpc3RhdGUgIkdlbmVyaWMgT0YgU2ltcGxlIEds dWUgTGF5ZXIiCj4gICAgICAgICBkZXBlbmRzIG9uIE9GICYmIENPTU1PTl9DTEsKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy91c2IvZHdjMy9NYWtlZmlsZSBiL2RyaXZlcnMvdXNiL2R3YzMvTWFrZWZp bGUKPiBpbmRleCA2ZTNlZjYxNDRlNWQuLmFlODZkYTBkYzViZCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL3VzYi9kd2MzL01ha2VmaWxlCj4gKysrIGIvZHJpdmVycy91c2IvZHdjMy9NYWtlZmlsZQo+ IEBAIC00Nyw2ICs0Nyw3IEBAIG9iai0kKENPTkZJR19VU0JfRFdDM19FWFlOT1MpCQkrPSBkd2Mz LWV4eW5vcy5vCj4gIG9iai0kKENPTkZJR19VU0JfRFdDM19QQ0kpCQkrPSBkd2MzLXBjaS5vCj4g IG9iai0kKENPTkZJR19VU0JfRFdDM19IQVBTKQkJKz0gZHdjMy1oYXBzLm8KPiAgb2JqLSQoQ09O RklHX1VTQl9EV0MzX0tFWVNUT05FKQkJKz0gZHdjMy1rZXlzdG9uZS5vCj4gK29iai0kKENPTkZJ R19VU0JfRFdDM19NRVNPTl9HMTJBKQkrPSBkd2MzLW1lc29uLWcxMmEubwo+ICBvYmotJChDT05G SUdfVVNCX0RXQzNfT0ZfU0lNUExFKQkrPSBkd2MzLW9mLXNpbXBsZS5vCj4gIG9iai0kKENPTkZJ R19VU0JfRFdDM19TVCkJCSs9IGR3YzMtc3Qubwo+ICBvYmotJChDT05GSUdfVVNCX0RXQzNfUUNP TSkJCSs9IGR3YzMtcWNvbS5vCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2R3YzMvZHdjMy1t ZXNvbi1nMTJhLmMgYi9kcml2ZXJzL3VzYi9kd2MzL2R3YzMtbWVzb24tZzEyYS5jCj4gbmV3IGZp bGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLjc1OTQyNjE0YTAzNAo+IC0tLSAv ZGV2L251bGwKPiArKysgYi9kcml2ZXJzL3VzYi9kd2MzL2R3YzMtbWVzb24tZzEyYS5jCj4gQEAg LTAsMCArMSw2MDEgQEAKPiArLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAKPiAr LyoKPiArICogVVNCIEdsdWUgZm9yIEFtbG9naWMgRzEyQSBTb0NzCj4gKyAqCj4gKyAqIENvcHly aWdodCAoYykgMjAxOSBCYXlMaWJyZSwgU0FTCj4gKyAqIEF1dGhvcjogTmVpbCBBcm1zdHJvbmcg PG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPgo+ICsgKi8KPiArCj4gKy8qCj4gKyAqIFRoZSBVU0Ig aXMgb3JnYW5pemVkIHdpdGggYSBnbHVlIGFyb3VuZCB0aGUgRFdDMyBDb250cm9sbGVyIElQIGFz IDoKPiArICogLSBDb250cm9sIHJlZ2lzdGVycyBmb3IgZWFjaCBVU0IyIFBvcnRzCj4gKyAqIC0g Q29udHJvbCByZWdpc3RlcnMgZm9yIHRoZSBVU0IgUEhZIGxheWVyCj4gKyAqIC0gU3VwZXJTcGVl ZCBQSFkgY2FuIGJlIGVuYWJsZWQgb25seSBpZiBwb3J0IGlzIHVzZWQKPiArICoKPiArICogVE9G SVg6Cj4gKyAqIC0gQWRkIGR5bmFtaWMgT1RHIHN3aXRjaGluZyB3aXRoIElEIGNoYW5nZSBpbnRl cnJ1cHQKPiArICovCj4gKwpbLi4uXQo+ICsKPiArc3RhdGljIGludCBkd2MzX21lc29uX2cxMmFf cHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiArewo+ICsJc3RydWN0IGR3YzNf bWVzb25fZzEyYQkqcHJpdjsKPiArCXN0cnVjdCBkZXZpY2UJCSpkZXYgPSAmcGRldi0+ZGV2Owo+ ICsJc3RydWN0IGRldmljZV9ub2RlCSpucCA9IGRldi0+b2Zfbm9kZTsKPiArCXZvaWQgX19pb21l bSAqYmFzZTsKPiArCXN0cnVjdCByZXNvdXJjZSAqcmVzOwo+ICsJZW51bSBwaHlfbW9kZSBvdGdf aWQ7Cj4gKwlpbnQgcmV0LCBpOwo+ICsKPiArCXByaXYgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXpl b2YoKnByaXYpLCBHRlBfS0VSTkVMKTsKPiArCWlmICghcHJpdikKPiArCQlyZXR1cm4gLUVOT01F TTsKPiArCj4gKwlyZXMgPSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UocGRldiwgSU9SRVNPVVJDRV9N RU0sIDApOwo+ICsJYmFzZSA9IGRldm1faW9yZW1hcF9yZXNvdXJjZShkZXYsIHJlcyk7Cj4gKwlp ZiAoSVNfRVJSKGJhc2UpKQo+ICsJCXJldHVybiBQVFJfRVJSKGJhc2UpOwo+ICsKPiArCXByaXYt PnJlZ21hcCA9IGRldm1fcmVnbWFwX2luaXRfbW1pbyhkZXYsIGJhc2UsCj4gKwkJCQkJICAgICAm cGh5X21lc29uX2cxMmFfdXNiM19yZWdtYXBfY29uZik7Cj4gKwlpZiAoSVNfRVJSKHByaXYtPnJl Z21hcCkpCj4gKwkJcmV0dXJuIFBUUl9FUlIocHJpdi0+cmVnbWFwKTsKPiArCj4gKwlwcml2LT52 YnVzID0gZGV2bV9yZWd1bGF0b3JfZ2V0X29wdGlvbmFsKGRldiwgInZidXMiKTsKPiArCWlmIChJ U19FUlIocHJpdi0+dmJ1cykpIHsKPiArCQlpZiAoUFRSX0VSUihwcml2LT52YnVzKSA9PSAtRVBS T0JFX0RFRkVSKQo+ICsJCQlyZXR1cm4gUFRSX0VSUihwcml2LT52YnVzKTsKPiArCQlwcml2LT52 YnVzID0gTlVMTDsKPiArCX0KPiArCj4gKwlwcml2LT5jbGsgPSBkZXZtX2Nsa19nZXQoZGV2LCBO VUxMKTsKPiArCWlmIChJU19FUlIocHJpdi0+Y2xrKSkKPiArCQlyZXR1cm4gUFRSX0VSUihwcml2 LT5jbGspOwo+ICsKPiArCXJldCA9IGNsa19wcmVwYXJlX2VuYWJsZShwcml2LT5jbGspOwo+ICsJ aWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBk ZXYsIHByaXYpOwo+ICsJcHJpdi0+ZGV2ID0gZGV2Owo+ICsKPiArCXByaXYtPnJlc2V0ID0gZGV2 bV9yZXNldF9jb250cm9sX2dldChkZXYsIE5VTEwpOwo+ICsJaWYgKElTX0VSUihwcml2LT5yZXNl dCkpIHsKPiArCQlyZXQgPSBQVFJfRVJSKHByaXYtPnJlc2V0KTsKPiArCQlkZXZfZXJyKGRldiwg ImZhaWxlZCB0byBnZXQgZGV2aWNlIHJlc2V0LCBlcnI9JWRcbiIsIHJldCk7Cj4gKwkJcmV0dXJu IHJldDsKPiArCX0KPiArCj4gKwlyZXQgPSByZXNldF9jb250cm9sX3Jlc2V0KHByaXYtPnJlc2V0 KTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwlyZXQgPSBkd2MzX21lc29u X2cxMmFfZ2V0X3BoeXMocHJpdik7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ ICsJcmV0ID0gcmVndWxhdG9yX2VuYWJsZShwcml2LT52YnVzKTsKPiArCWlmIChyZXQpCj4gKwkJ cmV0dXJuIHJldDsKPiArCj4gKwkvKiBHZXQgZHJfbW9kZSAqLwo+ICsJcHJpdi0+b3RnX21vZGUg PSB1c2JfZ2V0X2RyX21vZGUoZGV2KTsKPiArCj4gKwlkd2MzX21lc29uX2cxMmFfdXNiX2luaXQo cHJpdik7Cj4gKwo+ICsJLyogU2V0IFBIWSBQb3dlciAqLwo+ICsJZm9yIChpID0gMCA7IGkgPCBQ SFlfQ09VTlQgOyArK2kpIHsKPiArCQlyZXQgPSBwaHlfcG93ZXJfb24ocHJpdi0+cGh5c1tpXSk7 Cj4gKwkJaWYgKHJldCkKPiArCQkJZ290byBlcnJfcGh5c19wdXQ7Cj4gKwl9Cj4gKwo+ICsJLyog SW5pdCBQSFlzICovCj4gKwlmb3IgKGkgPSAwIDsgaSA8IFBIWV9DT1VOVCA7ICsraSkgewo+ICsJ CXJldCA9IHBoeV9pbml0KHByaXYtPnBoeXNbaV0pOwo+ICsJCWlmIChyZXQpCj4gKwkJCWdvdG8g ZXJyX3BoeXNfcG93ZXI7Cj4gKwl9CnVzdWFsbHkgcGh5X2luaXQoKSBmaXJzdAoKPiArCj4gKwly ZXQgPSBvZl9wbGF0Zm9ybV9wb3B1bGF0ZShucCwgTlVMTCwgTlVMTCwgZGV2KTsKPiArCWlmIChy ZXQpIHsKPiArCQljbGtfZGlzYWJsZV91bnByZXBhcmUocHJpdi0+Y2xrKTsKPiArCQljbGtfcHV0 KHByaXYtPmNsayk7Cj4gKwo+ICsJCWdvdG8gZXJyX3BoeXNfZXhpdDsKPiArCX0KPiArCj4gKwkv KiBTZXR1cCBPVEcgbW9kZSBjb3JyZXNwb25kaW5nIHRvIHRoZSBJRCBwaW4gKi8KPiArCWlmIChw cml2LT5vdGdfbW9kZSA9PSBVU0JfRFJfTU9ERV9PVEcpIHsKPiArCQkvKiBUT0ZJWCBIYW5kbGUg SUQgbW9kZSB0b2dnbGluZyB2aWEgSVJRICovCj4gKwkJb3RnX2lkID0gZHdjM19tZXNvbl9nMTJh X2dldF9pZChwcml2KTsKPiArCQlpZiAob3RnX2lkICE9IHByaXYtPm90Z19waHlfbW9kZSkgewo+ ICsJCQlpZiAoZHdjM19tZXNvbl9nMTJhX290Z19tb2RlX3NldChwcml2LCBvdGdfaWQpKQo+ICsJ CQkJZGV2X3dhcm4oZGV2LCAiRmFpbGVkIHRvIHN3aXRjaCBPVEcgbW9kZVxuIik7Cj4gKwkJfQo+ ICsJfQo+ICsKPiArCS8qIFNldHVwIHJvbGUgc3dpdGNoZXIgKi8KPiArCXByaXYtPnN3aXRjaF9k ZXNjLnVzYjJfcG9ydCA9IGR3YzNfbWVzb25fZzEyX2ZpbmRfY2hpbGQoZGV2LAo+ICsJCQkJCQkJ CSJzbnBzLGR3YzMiKTsKPiArCXByaXYtPnN3aXRjaF9kZXNjLnVkYyA9IGR3YzNfbWVzb25fZzEy X2ZpbmRfY2hpbGQoZGV2LCAic25wcyxkd2MyIik7Cj4gKwlwcml2LT5zd2l0Y2hfZGVzYy5hbGxv d191c2Vyc3BhY2VfY29udHJvbCA9IHRydWU7Cj4gKwlwcml2LT5zd2l0Y2hfZGVzYy5zZXQgPSBk d2MzX21lc29uX2cxMmFfcm9sZV9zZXQ7Cj4gKwlwcml2LT5zd2l0Y2hfZGVzYy5nZXQgPSBkd2Mz X21lc29uX2cxMmFfcm9sZV9nZXQ7CnRvIG1lLCB1c2UgYSBsb2NhbCB2YXJpYWJsZSBmb3Igc3dp dGNoX2Rlc2MKCj4gKwo+ICsJcHJpdi0+cm9sZV9zd2l0Y2ggPSB1c2Jfcm9sZV9zd2l0Y2hfcmVn aXN0ZXIoZGV2LCAmcHJpdi0+c3dpdGNoX2Rlc2MpOwo+ICsJaWYgKElTX0VSUihwcml2LT5yb2xl X3N3aXRjaCkpCj4gKwkJZGV2X3dhcm4oZGV2LCAiVW5hYmxlIHRvIHJlZ2lzdGVyIFJvbGUgU3dp dGNoXG4iKTsKPiArCj4gKwlwbV9ydW50aW1lX3NldF9hY3RpdmUoZGV2KTsKPiArCXBtX3J1bnRp bWVfZW5hYmxlKGRldik7Cj4gKwlwbV9ydW50aW1lX2dldF9zeW5jKGRldik7Cj4gKwo+ICsJcmV0 dXJuIDA7Cj4gKwo+ICtlcnJfcGh5c19leGl0Ogo+ICsJZm9yIChpID0gMCA7IGkgPCBQSFlfQ09V TlQgOyArK2kpCj4gKwkJcGh5X2V4aXQocHJpdi0+cGh5c1tpXSk7Cj4gKwo+ICtlcnJfcGh5c19w b3dlcjoKPiArCWZvciAoaSA9IDAgOyBpIDwgUEhZX0NPVU5UIDsgKytpKQo+ICsJCXBoeV9wb3dl cl9vZmYocHJpdi0+cGh5c1tpXSk7Cj4gKwo+ICtlcnJfcGh5c19wdXQ6Cj4gKwlmb3IgKGkgPSAw IDsgaSA8IFBIWV9DT1VOVCA7ICsraSkKPiArCQlwaHlfcHV0KHByaXYtPnBoeXNbaV0pOwo+ICsK VGhlIHBoeXMgYXJlIGdvdCBieSBkZXZtX3BoeV9vcHRpb25hbF9nZXQoKSwgbm8gbmVlZCBjYWxs IHBoeV9wdXQoKQo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsKPiArc3RhdGljIGludCBkd2MzX21l c29uX2cxMmFfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gK3sKPiArCXN0 cnVjdCBkd2MzX21lc29uX2cxMmEgKnByaXYgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsK PiArCXN0cnVjdCBkZXZpY2UgKmRldiA9ICZwZGV2LT5kZXY7Cj4gKwlpbnQgaTsKPiArCj4gKwl1 c2Jfcm9sZV9zd2l0Y2hfdW5yZWdpc3Rlcihwcml2LT5yb2xlX3N3aXRjaCk7Cj4gKwo+ICsJb2Zf cGxhdGZvcm1fZGVwb3B1bGF0ZShkZXYpOwo+ICsKPiArCWZvciAoaSA9IDAgOyBpIDwgUEhZX0NP VU5UIDsgKytpKSB7Cj4gKwkJcGh5X3Bvd2VyX29mZihwcml2LT5waHlzW2ldKTsKPiArCQlwaHlf ZXhpdChwcml2LT5waHlzW2ldKTsKPiArCQlwaHlfcHV0KHByaXYtPnBoeXNbaV0pOwpkaXR0bwo+ ICsJfQo+ICsKPiArCWNsa19kaXNhYmxlX3VucHJlcGFyZShwcml2LT5jbGspOwo+ICsJY2xrX3B1 dChwcml2LT5jbGspOwo+ICsKPiArCXBtX3J1bnRpbWVfZGlzYWJsZShkZXYpOwo+ICsJcG1fcnVu dGltZV9wdXRfbm9pZGxlKGRldik7Cj4gKwlwbV9ydW50aW1lX3NldF9zdXNwZW5kZWQoZGV2KTsK PiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIGludCBfX21heWJlX3VudXNlZCBk d2MzX21lc29uX2cxMmFfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikKPiArewo+ ICsJc3RydWN0IGR3YzNfbWVzb25fZzEyYQkqcHJpdiA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ ICsKPiArCWNsa19kaXNhYmxlKHByaXYtPmNsayk7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiAr Cj4gK3N0YXRpYyBpbnQgX19tYXliZV91bnVzZWQgZHdjM19tZXNvbl9nMTJhX3J1bnRpbWVfcmVz dW1lKHN0cnVjdCBkZXZpY2UgKmRldikKPiArewo+ICsJc3RydWN0IGR3YzNfbWVzb25fZzEyYQkq cHJpdiA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICsKPiArCXJldHVybiBjbGtfZW5hYmxlKHBy aXYtPmNsayk7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgX19tYXliZV91bnVzZWQgZHdjM19tZXNv bl9nMTJhX3N1c3BlbmQoc3RydWN0IGRldmljZSAqZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgZHdjM19t ZXNvbl9nMTJhICpwcml2ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwlpbnQgaTsKPiArCj4g Kwlmb3IgKGkgPSAwIDsgaSA8IFBIWV9DT1VOVCA7ICsraSkKPiArCQlpZiAocHJpdi0+cGh5c1tp XSkKPiArCQkJcGh5X2V4aXQocHJpdi0+cGh5c1tpXSk7Cj4gKwo+ICsJcmVzZXRfY29udHJvbF9h c3NlcnQocHJpdi0+cmVzZXQpOwo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICtzdGF0aWMg aW50IF9fbWF5YmVfdW51c2VkIGR3YzNfbWVzb25fZzEyYV9yZXN1bWUoc3RydWN0IGRldmljZSAq ZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgZHdjM19tZXNvbl9nMTJhICpwcml2ID0gZGV2X2dldF9kcnZk YXRhKGRldik7Cj4gKwlpbnQgaSwgcmV0Owo+ICsKPiArCXJlc2V0X2NvbnRyb2xfZGVhc3NlcnQo cHJpdi0+cmVzZXQpOwo+ICsKPiArCWR3YzNfbWVzb25fZzEyYV91c2JfaW5pdChwcml2KTsKPiAr Cj4gKwkvKiBJbml0IFBIWXMgKi8KPiArCWZvciAoaSA9IDAgOyBpIDwgUEhZX0NPVU5UIDsgKytp KSB7Cj4gKwkJaWYgKHByaXYtPnBoeXNbaV0pIHsKPiArCQkJcmV0ID0gcGh5X2luaXQocHJpdi0+ cGh5c1tpXSk7Cj4gKwkJCWlmIChyZXQpCj4gKwkJCQlyZXR1cm4gcmV0Owo+ICsJCX0KPiArCX0K PiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkZXZfcG1f b3BzIGR3YzNfbWVzb25fZzEyYV9kZXZfcG1fb3BzID0gewo+ICsJU0VUX1NZU1RFTV9TTEVFUF9Q TV9PUFMoZHdjM19tZXNvbl9nMTJhX3N1c3BlbmQsIGR3YzNfbWVzb25fZzEyYV9yZXN1bWUpCj4g KwlTRVRfUlVOVElNRV9QTV9PUFMoZHdjM19tZXNvbl9nMTJhX3J1bnRpbWVfc3VzcGVuZCwKPiAr CQkJZHdjM19tZXNvbl9nMTJhX3J1bnRpbWVfcmVzdW1lLCBOVUxMKQo+ICt9Owo+ICsKPiArc3Rh dGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgZHdjM19tZXNvbl9nMTJhX21hdGNoW10gPSB7 Cj4gKwl7IC5jb21wYXRpYmxlID0gImFtbG9naWMsbWVzb24tZzEyYS11c2ItY3RybCIgfSwKPiAr CXsgLyogU2VudGluZWwgKi8gfQo+ICt9Owo+ICtNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBkd2Mz X21lc29uX2cxMmFfbWF0Y2gpOwo+ICsKPiArc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIg ZHdjM19tZXNvbl9nMTJhX2RyaXZlciA9IHsKPiArCS5wcm9iZQkJPSBkd2MzX21lc29uX2cxMmFf cHJvYmUsCj4gKwkucmVtb3ZlCQk9IGR3YzNfbWVzb25fZzEyYV9yZW1vdmUsCj4gKwkuZHJpdmVy CQk9IHsKPiArCQkubmFtZQk9ICJkd2MzLW1lc29uLWcxMmEiLAo+ICsJCS5vZl9tYXRjaF90YWJs ZSA9IGR3YzNfbWVzb25fZzEyYV9tYXRjaCwKPiArCQkucG0JPSAmZHdjM19tZXNvbl9nMTJhX2Rl dl9wbV9vcHMsCj4gKwl9LAo+ICt9Owo+ICsKPiArbW9kdWxlX3BsYXRmb3JtX2RyaXZlcihkd2Mz X21lc29uX2cxMmFfZHJpdmVyKTsKPiArTU9EVUxFX0xJQ0VOU0UoIkdQTCB2MiIpOwo+ICtNT0RV TEVfREVTQ1JJUFRJT04oIkFtbG9naWMgTWVzb24gRzEyQSBVU0IgR2x1ZSBMYXllciIpOwo+ICtN T0RVTEVfQVVUSE9SKCJOZWlsIEFybXN0cm9uZyA8bmFybXN0cm9uZ0BiYXlsaWJyZS5jb20+Iik7 Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCDEBC10F00 for ; Thu, 7 Mar 2019 02:03:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D42B206DD for ; Thu, 7 Mar 2019 02:03:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fof+F6fP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D42B206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YIPhvR9armM2jcee+qVlrlgslA5JM2krdUdDlsVa10M=; b=fof+F6fPCFvxHu c+OdRCJA9e2EQ6VHulP1l32XgPGC5cmvMFtgwwgx6B2/Ts7Y+jnz4B+18ptCE9zw+Fih4iaFZbYo4 sut9WDJ7JqzRnjUiCQk3yuqtLATA03WXFaVLqfQebARK4P1dZhexPFrDDjZAxO2zeQPVcLELcgvXX FXRt3psWOocNCQf62bsBWzAEZBI0zhWdjktAVW2NdTnfEMvQ0EYxfUVvVFurzPaQC8fPoD59o8ag3 2WrjZ1yZ09SFkrLjVQMjg8eCLDtnNwXPZQhrHn3ytWIv7NqN7381G1rFhDxdhrOjXsHVgKqXnNT2y 79irA2jy+EbKh+Aoi9nA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1iNW-0003HR-GE; Thu, 07 Mar 2019 02:03:22 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1iNS-0003FJ-Fi; Thu, 07 Mar 2019 02:03:20 +0000 X-UUID: 9bca1713bedd4eaa95273f2f29c7d813-20190306 X-UUID: 9bca1713bedd4eaa95273f2f29c7d813-20190306 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 564006373; Wed, 06 Mar 2019 18:03:01 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Mar 2019 18:02:59 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 7 Mar 2019 10:02:57 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 7 Mar 2019 10:02:56 +0800 Message-ID: <1551924176.2210.104.camel@mhfsdcap03> Subject: Re: [PATCH v2 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue From: Chunfeng Yun To: Neil Armstrong Date: Thu, 7 Mar 2019 10:02:56 +0800 In-Reply-To: <20190304103846.2060-9-narmstrong@baylibre.com> References: <20190304103846.2060-1-narmstrong@baylibre.com> <20190304103846.2060-9-narmstrong@baylibre.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_180318_532267_98587D24 X-CRM114-Status: GOOD ( 23.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, 2019-03-04 at 11:38 +0100, Neil Armstrong wrote: > Adds support for Amlogic G12A USB Control Glue HW. > > The Amlogic G12A SoC Family embeds 2 USB Controllers : > - a DWC3 IP configured as Host for USB2 and USB3 > - a DWC2 IP configured as Peripheral USB2 Only > > A glue connects these both controllers to 2 USB2 PHYs, and optionnally > to an USB3+PCIE Combo PHY shared with the PCIE controller. > > The Glue configures the UTMI 8bit interfaces for the USB2 PHYs, including > routing of the OTG PHY between the DWC3 and DWC2 controllers, and > setups the on-chip OTG mode selection for this PHY. > > This drivers supports the on-probe setup of the OTG mode, and manually > via a debugfs interface. The IRQ mode change detect is yet to be added > in a future patchset, mainly due to lack of hardware to validate on. > > Signed-off-by: Neil Armstrong > --- > drivers/usb/dwc3/Kconfig | 10 + > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-meson-g12a.c | 601 +++++++++++++++++++++++++++++ > 3 files changed, 612 insertions(+) > create mode 100644 drivers/usb/dwc3/dwc3-meson-g12a.c > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 1a0404fda596..21ce7368d325 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -93,6 +93,16 @@ config USB_DWC3_KEYSTONE > Support of USB2/3 functionality in TI Keystone2 platforms. > Say 'Y' or 'M' here if you have one such device > > +config USB_DWC3_MESON_G12A > + tristate "Amlogic Meson G12A Platforms" > + depends on OF && COMMON_CLK > + depends on ARCH_MESON || COMPILE_TEST > + default USB_DWC3 > + select USB_ROLE_SWITCH > + help > + Support USB2/3 functionality in Amlogic G12A platforms. > + Say 'Y' or 'M' if you have one such device. > + > config USB_DWC3_OF_SIMPLE > tristate "Generic OF Simple Glue Layer" > depends on OF && COMMON_CLK > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile > index 6e3ef6144e5d..ae86da0dc5bd 100644 > --- a/drivers/usb/dwc3/Makefile > +++ b/drivers/usb/dwc3/Makefile > @@ -47,6 +47,7 @@ obj-$(CONFIG_USB_DWC3_EXYNOS) += dwc3-exynos.o > obj-$(CONFIG_USB_DWC3_PCI) += dwc3-pci.o > obj-$(CONFIG_USB_DWC3_HAPS) += dwc3-haps.o > obj-$(CONFIG_USB_DWC3_KEYSTONE) += dwc3-keystone.o > +obj-$(CONFIG_USB_DWC3_MESON_G12A) += dwc3-meson-g12a.o > obj-$(CONFIG_USB_DWC3_OF_SIMPLE) += dwc3-of-simple.o > obj-$(CONFIG_USB_DWC3_ST) += dwc3-st.o > obj-$(CONFIG_USB_DWC3_QCOM) += dwc3-qcom.o > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c > new file mode 100644 > index 000000000000..75942614a034 > --- /dev/null > +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c > @@ -0,0 +1,601 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * USB Glue for Amlogic G12A SoCs > + * > + * Copyright (c) 2019 BayLibre, SAS > + * Author: Neil Armstrong > + */ > + > +/* > + * The USB is organized with a glue around the DWC3 Controller IP as : > + * - Control registers for each USB2 Ports > + * - Control registers for the USB PHY layer > + * - SuperSpeed PHY can be enabled only if port is used > + * > + * TOFIX: > + * - Add dynamic OTG switching with ID change interrupt > + */ > + [...] > + > +static int dwc3_meson_g12a_probe(struct platform_device *pdev) > +{ > + struct dwc3_meson_g12a *priv; > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + void __iomem *base; > + struct resource *res; > + enum phy_mode otg_id; > + int ret, i; > + > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + base = devm_ioremap_resource(dev, res); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + > + priv->regmap = devm_regmap_init_mmio(dev, base, > + &phy_meson_g12a_usb3_regmap_conf); > + if (IS_ERR(priv->regmap)) > + return PTR_ERR(priv->regmap); > + > + priv->vbus = devm_regulator_get_optional(dev, "vbus"); > + if (IS_ERR(priv->vbus)) { > + if (PTR_ERR(priv->vbus) == -EPROBE_DEFER) > + return PTR_ERR(priv->vbus); > + priv->vbus = NULL; > + } > + > + priv->clk = devm_clk_get(dev, NULL); > + if (IS_ERR(priv->clk)) > + return PTR_ERR(priv->clk); > + > + ret = clk_prepare_enable(priv->clk); > + if (ret) > + return ret; > + > + platform_set_drvdata(pdev, priv); > + priv->dev = dev; > + > + priv->reset = devm_reset_control_get(dev, NULL); > + if (IS_ERR(priv->reset)) { > + ret = PTR_ERR(priv->reset); > + dev_err(dev, "failed to get device reset, err=%d\n", ret); > + return ret; > + } > + > + ret = reset_control_reset(priv->reset); > + if (ret) > + return ret; > + > + ret = dwc3_meson_g12a_get_phys(priv); > + if (ret) > + return ret; > + > + ret = regulator_enable(priv->vbus); > + if (ret) > + return ret; > + > + /* Get dr_mode */ > + priv->otg_mode = usb_get_dr_mode(dev); > + > + dwc3_meson_g12a_usb_init(priv); > + > + /* Set PHY Power */ > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + ret = phy_power_on(priv->phys[i]); > + if (ret) > + goto err_phys_put; > + } > + > + /* Init PHYs */ > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + ret = phy_init(priv->phys[i]); > + if (ret) > + goto err_phys_power; > + } usually phy_init() first > + > + ret = of_platform_populate(np, NULL, NULL, dev); > + if (ret) { > + clk_disable_unprepare(priv->clk); > + clk_put(priv->clk); > + > + goto err_phys_exit; > + } > + > + /* Setup OTG mode corresponding to the ID pin */ > + if (priv->otg_mode == USB_DR_MODE_OTG) { > + /* TOFIX Handle ID mode toggling via IRQ */ > + otg_id = dwc3_meson_g12a_get_id(priv); > + if (otg_id != priv->otg_phy_mode) { > + if (dwc3_meson_g12a_otg_mode_set(priv, otg_id)) > + dev_warn(dev, "Failed to switch OTG mode\n"); > + } > + } > + > + /* Setup role switcher */ > + priv->switch_desc.usb2_port = dwc3_meson_g12_find_child(dev, > + "snps,dwc3"); > + priv->switch_desc.udc = dwc3_meson_g12_find_child(dev, "snps,dwc2"); > + priv->switch_desc.allow_userspace_control = true; > + priv->switch_desc.set = dwc3_meson_g12a_role_set; > + priv->switch_desc.get = dwc3_meson_g12a_role_get; to me, use a local variable for switch_desc > + > + priv->role_switch = usb_role_switch_register(dev, &priv->switch_desc); > + if (IS_ERR(priv->role_switch)) > + dev_warn(dev, "Unable to register Role Switch\n"); > + > + pm_runtime_set_active(dev); > + pm_runtime_enable(dev); > + pm_runtime_get_sync(dev); > + > + return 0; > + > +err_phys_exit: > + for (i = 0 ; i < PHY_COUNT ; ++i) > + phy_exit(priv->phys[i]); > + > +err_phys_power: > + for (i = 0 ; i < PHY_COUNT ; ++i) > + phy_power_off(priv->phys[i]); > + > +err_phys_put: > + for (i = 0 ; i < PHY_COUNT ; ++i) > + phy_put(priv->phys[i]); > + The phys are got by devm_phy_optional_get(), no need call phy_put() > + return ret; > +} > + > +static int dwc3_meson_g12a_remove(struct platform_device *pdev) > +{ > + struct dwc3_meson_g12a *priv = platform_get_drvdata(pdev); > + struct device *dev = &pdev->dev; > + int i; > + > + usb_role_switch_unregister(priv->role_switch); > + > + of_platform_depopulate(dev); > + > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + phy_power_off(priv->phys[i]); > + phy_exit(priv->phys[i]); > + phy_put(priv->phys[i]); ditto > + } > + > + clk_disable_unprepare(priv->clk); > + clk_put(priv->clk); > + > + pm_runtime_disable(dev); > + pm_runtime_put_noidle(dev); > + pm_runtime_set_suspended(dev); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_meson_g12a_runtime_suspend(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + > + clk_disable(priv->clk); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_meson_g12a_runtime_resume(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + > + return clk_enable(priv->clk); > +} > + > +static int __maybe_unused dwc3_meson_g12a_suspend(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + int i; > + > + for (i = 0 ; i < PHY_COUNT ; ++i) > + if (priv->phys[i]) > + phy_exit(priv->phys[i]); > + > + reset_control_assert(priv->reset); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_meson_g12a_resume(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + int i, ret; > + > + reset_control_deassert(priv->reset); > + > + dwc3_meson_g12a_usb_init(priv); > + > + /* Init PHYs */ > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + if (priv->phys[i]) { > + ret = phy_init(priv->phys[i]); > + if (ret) > + return ret; > + } > + } > + > + return 0; > +} > + > +static const struct dev_pm_ops dwc3_meson_g12a_dev_pm_ops = { > + SET_SYSTEM_SLEEP_PM_OPS(dwc3_meson_g12a_suspend, dwc3_meson_g12a_resume) > + SET_RUNTIME_PM_OPS(dwc3_meson_g12a_runtime_suspend, > + dwc3_meson_g12a_runtime_resume, NULL) > +}; > + > +static const struct of_device_id dwc3_meson_g12a_match[] = { > + { .compatible = "amlogic,meson-g12a-usb-ctrl" }, > + { /* Sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, dwc3_meson_g12a_match); > + > +static struct platform_driver dwc3_meson_g12a_driver = { > + .probe = dwc3_meson_g12a_probe, > + .remove = dwc3_meson_g12a_remove, > + .driver = { > + .name = "dwc3-meson-g12a", > + .of_match_table = dwc3_meson_g12a_match, > + .pm = &dwc3_meson_g12a_dev_pm_ops, > + }, > +}; > + > +module_platform_driver(dwc3_meson_g12a_driver); > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("Amlogic Meson G12A USB Glue Layer"); > +MODULE_AUTHOR("Neil Armstrong "); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 726F7C43381 for ; Thu, 7 Mar 2019 02:03:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41D8920661 for ; Thu, 7 Mar 2019 02:03:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EdzT/+Vn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D8920661 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OOl3F2ufGSGjopL7jw23gZfTrtbqIBhrgzOerfPptII=; b=EdzT/+VnJ18E5e 8r/x454dPvUz4NkgHNC046CXBvoMa4XV558IvbtxuVNnO1FRulUGsTZ6oep9M944YqdQBEqX+eNLF ljZzGytkmC0/eIlQvW4rnO9DPYspd9zahunVs+uMCMKbPabZSk2neYx70miepUgxQE467k7awqEwm yKj+OIEFQy0k4+X4t06GegwpsalCy39J3Z+FNje/BVXjWh5XSc6oCqUC1wA1Dnt7RPS4FGb4jMF6E ri354V8FKEl/+43eEGd4L9iH0aLoY8hG5LV4k+uuSTAPdRPRIV9GNYBZ5o5G5wAIcIbu5EqhOT0WM p6aTM3f4DtDWLrCOxp1A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1iNV-0003Gs-6d; Thu, 07 Mar 2019 02:03:21 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1iNS-0003FJ-Fi; Thu, 07 Mar 2019 02:03:20 +0000 X-UUID: 9bca1713bedd4eaa95273f2f29c7d813-20190306 X-UUID: 9bca1713bedd4eaa95273f2f29c7d813-20190306 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 564006373; Wed, 06 Mar 2019 18:03:01 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 6 Mar 2019 18:02:59 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 7 Mar 2019 10:02:57 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 7 Mar 2019 10:02:56 +0800 Message-ID: <1551924176.2210.104.camel@mhfsdcap03> Subject: Re: [PATCH v2 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue From: Chunfeng Yun To: Neil Armstrong Date: Thu, 7 Mar 2019 10:02:56 +0800 In-Reply-To: <20190304103846.2060-9-narmstrong@baylibre.com> References: <20190304103846.2060-1-narmstrong@baylibre.com> <20190304103846.2060-9-narmstrong@baylibre.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190306_180318_532267_98587D24 X-CRM114-Status: GOOD ( 23.27 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, On Mon, 2019-03-04 at 11:38 +0100, Neil Armstrong wrote: > Adds support for Amlogic G12A USB Control Glue HW. > > The Amlogic G12A SoC Family embeds 2 USB Controllers : > - a DWC3 IP configured as Host for USB2 and USB3 > - a DWC2 IP configured as Peripheral USB2 Only > > A glue connects these both controllers to 2 USB2 PHYs, and optionnally > to an USB3+PCIE Combo PHY shared with the PCIE controller. > > The Glue configures the UTMI 8bit interfaces for the USB2 PHYs, including > routing of the OTG PHY between the DWC3 and DWC2 controllers, and > setups the on-chip OTG mode selection for this PHY. > > This drivers supports the on-probe setup of the OTG mode, and manually > via a debugfs interface. The IRQ mode change detect is yet to be added > in a future patchset, mainly due to lack of hardware to validate on. > > Signed-off-by: Neil Armstrong > --- > drivers/usb/dwc3/Kconfig | 10 + > drivers/usb/dwc3/Makefile | 1 + > drivers/usb/dwc3/dwc3-meson-g12a.c | 601 +++++++++++++++++++++++++++++ > 3 files changed, 612 insertions(+) > create mode 100644 drivers/usb/dwc3/dwc3-meson-g12a.c > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index 1a0404fda596..21ce7368d325 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/drivers/usb/dwc3/Kconfig > @@ -93,6 +93,16 @@ config USB_DWC3_KEYSTONE > Support of USB2/3 functionality in TI Keystone2 platforms. > Say 'Y' or 'M' here if you have one such device > > +config USB_DWC3_MESON_G12A > + tristate "Amlogic Meson G12A Platforms" > + depends on OF && COMMON_CLK > + depends on ARCH_MESON || COMPILE_TEST > + default USB_DWC3 > + select USB_ROLE_SWITCH > + help > + Support USB2/3 functionality in Amlogic G12A platforms. > + Say 'Y' or 'M' if you have one such device. > + > config USB_DWC3_OF_SIMPLE > tristate "Generic OF Simple Glue Layer" > depends on OF && COMMON_CLK > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile > index 6e3ef6144e5d..ae86da0dc5bd 100644 > --- a/drivers/usb/dwc3/Makefile > +++ b/drivers/usb/dwc3/Makefile > @@ -47,6 +47,7 @@ obj-$(CONFIG_USB_DWC3_EXYNOS) += dwc3-exynos.o > obj-$(CONFIG_USB_DWC3_PCI) += dwc3-pci.o > obj-$(CONFIG_USB_DWC3_HAPS) += dwc3-haps.o > obj-$(CONFIG_USB_DWC3_KEYSTONE) += dwc3-keystone.o > +obj-$(CONFIG_USB_DWC3_MESON_G12A) += dwc3-meson-g12a.o > obj-$(CONFIG_USB_DWC3_OF_SIMPLE) += dwc3-of-simple.o > obj-$(CONFIG_USB_DWC3_ST) += dwc3-st.o > obj-$(CONFIG_USB_DWC3_QCOM) += dwc3-qcom.o > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c > new file mode 100644 > index 000000000000..75942614a034 > --- /dev/null > +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c > @@ -0,0 +1,601 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * USB Glue for Amlogic G12A SoCs > + * > + * Copyright (c) 2019 BayLibre, SAS > + * Author: Neil Armstrong > + */ > + > +/* > + * The USB is organized with a glue around the DWC3 Controller IP as : > + * - Control registers for each USB2 Ports > + * - Control registers for the USB PHY layer > + * - SuperSpeed PHY can be enabled only if port is used > + * > + * TOFIX: > + * - Add dynamic OTG switching with ID change interrupt > + */ > + [...] > + > +static int dwc3_meson_g12a_probe(struct platform_device *pdev) > +{ > + struct dwc3_meson_g12a *priv; > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + void __iomem *base; > + struct resource *res; > + enum phy_mode otg_id; > + int ret, i; > + > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + base = devm_ioremap_resource(dev, res); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + > + priv->regmap = devm_regmap_init_mmio(dev, base, > + &phy_meson_g12a_usb3_regmap_conf); > + if (IS_ERR(priv->regmap)) > + return PTR_ERR(priv->regmap); > + > + priv->vbus = devm_regulator_get_optional(dev, "vbus"); > + if (IS_ERR(priv->vbus)) { > + if (PTR_ERR(priv->vbus) == -EPROBE_DEFER) > + return PTR_ERR(priv->vbus); > + priv->vbus = NULL; > + } > + > + priv->clk = devm_clk_get(dev, NULL); > + if (IS_ERR(priv->clk)) > + return PTR_ERR(priv->clk); > + > + ret = clk_prepare_enable(priv->clk); > + if (ret) > + return ret; > + > + platform_set_drvdata(pdev, priv); > + priv->dev = dev; > + > + priv->reset = devm_reset_control_get(dev, NULL); > + if (IS_ERR(priv->reset)) { > + ret = PTR_ERR(priv->reset); > + dev_err(dev, "failed to get device reset, err=%d\n", ret); > + return ret; > + } > + > + ret = reset_control_reset(priv->reset); > + if (ret) > + return ret; > + > + ret = dwc3_meson_g12a_get_phys(priv); > + if (ret) > + return ret; > + > + ret = regulator_enable(priv->vbus); > + if (ret) > + return ret; > + > + /* Get dr_mode */ > + priv->otg_mode = usb_get_dr_mode(dev); > + > + dwc3_meson_g12a_usb_init(priv); > + > + /* Set PHY Power */ > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + ret = phy_power_on(priv->phys[i]); > + if (ret) > + goto err_phys_put; > + } > + > + /* Init PHYs */ > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + ret = phy_init(priv->phys[i]); > + if (ret) > + goto err_phys_power; > + } usually phy_init() first > + > + ret = of_platform_populate(np, NULL, NULL, dev); > + if (ret) { > + clk_disable_unprepare(priv->clk); > + clk_put(priv->clk); > + > + goto err_phys_exit; > + } > + > + /* Setup OTG mode corresponding to the ID pin */ > + if (priv->otg_mode == USB_DR_MODE_OTG) { > + /* TOFIX Handle ID mode toggling via IRQ */ > + otg_id = dwc3_meson_g12a_get_id(priv); > + if (otg_id != priv->otg_phy_mode) { > + if (dwc3_meson_g12a_otg_mode_set(priv, otg_id)) > + dev_warn(dev, "Failed to switch OTG mode\n"); > + } > + } > + > + /* Setup role switcher */ > + priv->switch_desc.usb2_port = dwc3_meson_g12_find_child(dev, > + "snps,dwc3"); > + priv->switch_desc.udc = dwc3_meson_g12_find_child(dev, "snps,dwc2"); > + priv->switch_desc.allow_userspace_control = true; > + priv->switch_desc.set = dwc3_meson_g12a_role_set; > + priv->switch_desc.get = dwc3_meson_g12a_role_get; to me, use a local variable for switch_desc > + > + priv->role_switch = usb_role_switch_register(dev, &priv->switch_desc); > + if (IS_ERR(priv->role_switch)) > + dev_warn(dev, "Unable to register Role Switch\n"); > + > + pm_runtime_set_active(dev); > + pm_runtime_enable(dev); > + pm_runtime_get_sync(dev); > + > + return 0; > + > +err_phys_exit: > + for (i = 0 ; i < PHY_COUNT ; ++i) > + phy_exit(priv->phys[i]); > + > +err_phys_power: > + for (i = 0 ; i < PHY_COUNT ; ++i) > + phy_power_off(priv->phys[i]); > + > +err_phys_put: > + for (i = 0 ; i < PHY_COUNT ; ++i) > + phy_put(priv->phys[i]); > + The phys are got by devm_phy_optional_get(), no need call phy_put() > + return ret; > +} > + > +static int dwc3_meson_g12a_remove(struct platform_device *pdev) > +{ > + struct dwc3_meson_g12a *priv = platform_get_drvdata(pdev); > + struct device *dev = &pdev->dev; > + int i; > + > + usb_role_switch_unregister(priv->role_switch); > + > + of_platform_depopulate(dev); > + > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + phy_power_off(priv->phys[i]); > + phy_exit(priv->phys[i]); > + phy_put(priv->phys[i]); ditto > + } > + > + clk_disable_unprepare(priv->clk); > + clk_put(priv->clk); > + > + pm_runtime_disable(dev); > + pm_runtime_put_noidle(dev); > + pm_runtime_set_suspended(dev); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_meson_g12a_runtime_suspend(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + > + clk_disable(priv->clk); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_meson_g12a_runtime_resume(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + > + return clk_enable(priv->clk); > +} > + > +static int __maybe_unused dwc3_meson_g12a_suspend(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + int i; > + > + for (i = 0 ; i < PHY_COUNT ; ++i) > + if (priv->phys[i]) > + phy_exit(priv->phys[i]); > + > + reset_control_assert(priv->reset); > + > + return 0; > +} > + > +static int __maybe_unused dwc3_meson_g12a_resume(struct device *dev) > +{ > + struct dwc3_meson_g12a *priv = dev_get_drvdata(dev); > + int i, ret; > + > + reset_control_deassert(priv->reset); > + > + dwc3_meson_g12a_usb_init(priv); > + > + /* Init PHYs */ > + for (i = 0 ; i < PHY_COUNT ; ++i) { > + if (priv->phys[i]) { > + ret = phy_init(priv->phys[i]); > + if (ret) > + return ret; > + } > + } > + > + return 0; > +} > + > +static const struct dev_pm_ops dwc3_meson_g12a_dev_pm_ops = { > + SET_SYSTEM_SLEEP_PM_OPS(dwc3_meson_g12a_suspend, dwc3_meson_g12a_resume) > + SET_RUNTIME_PM_OPS(dwc3_meson_g12a_runtime_suspend, > + dwc3_meson_g12a_runtime_resume, NULL) > +}; > + > +static const struct of_device_id dwc3_meson_g12a_match[] = { > + { .compatible = "amlogic,meson-g12a-usb-ctrl" }, > + { /* Sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, dwc3_meson_g12a_match); > + > +static struct platform_driver dwc3_meson_g12a_driver = { > + .probe = dwc3_meson_g12a_probe, > + .remove = dwc3_meson_g12a_remove, > + .driver = { > + .name = "dwc3-meson-g12a", > + .of_match_table = dwc3_meson_g12a_match, > + .pm = &dwc3_meson_g12a_dev_pm_ops, > + }, > +}; > + > +module_platform_driver(dwc3_meson_g12a_driver); > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("Amlogic Meson G12A USB Glue Layer"); > +MODULE_AUTHOR("Neil Armstrong "); _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic