From: Chris Wilson <chris@chris-wilson.co.uk>
To: Caz Yokoyama <Caz.Yokoyama@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain
Date: Thu, 21 Mar 2019 18:58:05 +0000 [thread overview]
Message-ID: <155319467993.26447.16890474404298943435@skylake-alporthouse-com> (raw)
In-Reply-To: <155319352779.26447.13930453206356439412@skylake-alporthouse-com>
Quoting Chris Wilson (2019-03-21 18:38:53)
> Quoting Caz Yokoyama (2019-03-21 18:41:10)
> > inline
> > -caz
> > On Thu, 2019-03-21 at 07:37 +0000, Chris Wilson wrote:
> > > +
> > > + rq = i915_request_alloc(engine, lo.ctx);
> > > + if (IS_ERR(rq))
> > > + goto err_wedged;
> > > + i915_request_add(rq);
> > This request add is redundant. Wait for the last rq for lo.
>
> Or not. And use a simple request as a flush and test.
The alternative would be to use igt_flush_test(). Some variance between
tests is good for serendipity.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-03-21 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 7:37 [PATCH 1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain Chris Wilson
2019-03-21 7:37 ` [PATCH 2/2] drm/i915/selftests: Mark up preemption tests for hang detection Chris Wilson
2019-03-21 8:41 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/selftests: Calculate maximum ring size for preemption chain Patchwork
2019-03-21 17:07 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-21 18:41 ` [PATCH 1/2] " Caz Yokoyama
2019-03-21 18:38 ` Chris Wilson
2019-03-21 18:42 ` Chris Wilson
2019-03-21 18:57 ` Caz Yokoyama
2019-03-21 18:58 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155319467993.26447.16890474404298943435@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=Caz.Yokoyama@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.