From: Thomas Huth <1798780@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1798780] Re: hw/usb/dev-mtp.c:1616: bad test ?
Date: Wed, 24 Apr 2019 06:07:50 -0000 [thread overview]
Message-ID: <155608607124.7327.1550547267839100641.launchpad@chaenomeles.canonical.com> (raw)
In-Reply-To: 153994006052.15678.15962440455123359491.malonedeb@gac.canonical.com
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1798780
Title:
hw/usb/dev-mtp.c:1616: bad test ?
Status in QEMU:
Fix Released
Bug description:
hw/usb/dev-mtp.c:1616:52: warning: logical ‘or’ of collectively
exhaustive tests is always true [-Wlogical-op]
Source code is
if ((ret == -1) && (errno != EINTR || errno != EAGAIN ||
errno != EWOULDBLOCK)) {
Maybe better code
if ((ret == -1) && (errno != EINTR && errno != EAGAIN &&
errno != EWOULDBLOCK)) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1798780/+subscriptions
prev parent reply other threads:[~2019-04-24 6:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 9:07 [Qemu-devel] [Bug 1798780] [NEW] hw/usb/dev-mtp.c:1616: bad test ? dcb
2019-01-18 17:18 ` Peter Maydell
2019-01-22 12:38 ` Bandan Das
2019-01-22 12:41 ` [Qemu-devel] [PATCH] usb-mtp: replace the homebrew write with qemu_write_full Bandan Das
2019-01-24 8:01 ` Gerd Hoffmann
2019-01-24 8:19 ` Bandan Das
2019-01-24 8:31 ` Gerd Hoffmann
2019-04-24 6:07 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155608607124.7327.1550547267839100641.launchpad@chaenomeles.canonical.com \
--to=1798780@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.