All of lore.kernel.org
 help / color / mirror / Atom feed
From: ben.hutchings@codethink.co.uk (Ben Hutchings)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [cip-kernel-sec 2/2] remotes: call _get_configured_remotes
Date: Tue, 18 Jun 2019 15:42:53 +0100	[thread overview]
Message-ID: <1560868973.21054.36.camel@codethink.co.uk> (raw)
In-Reply-To: <TY2PR01MB332350C9AD09DFF909EFF10BD0EB0@TY2PR01MB3323.jpnprd01.prod.outlook.com>

On Mon, 2019-06-17 at 23:48 +0000, daniel.sangorrin at toshiba.co.jp
wrote:
> > From: Ben Hutchings <ben.hutchings@codethink.co.uk>
> > 
> > On Mon, 2019-06-17 at 11:20 +0900, Daniel Sangorrin wrote:
> > > This is probably a copy&paste mistake that had no effect
> > > because the contents of _get_configured_remotes and
> > > _get_configured_branches is the same.
> > > 
> > > Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> > 
> > Maybe it would make more sense to merge the two functions instead?
> 
> I thought about that but in the future you may want to add some code
> that is specific to one of them. If you want me to consolidate them,
> what name would you use?

Actually these two functions aren't exactly the same, since the default
return value differs.  In practice that doesn't make a difference at
the moment, but logically it would be wrong to return one or the other.

So I'll apply your original patch.

Ben.

-- 
Ben Hutchings, Software Developer                ?        Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom

  reply	other threads:[~2019-06-18 14:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17  2:20 [cip-dev] [cip-kernel-sec 1/2] remotes: refer to configuration files Daniel Sangorrin
2019-06-17  2:20 ` [cip-dev] [cip-kernel-sec 2/2] remotes: call _get_configured_remotes Daniel Sangorrin
2019-06-17 20:16   ` Ben Hutchings
2019-06-17 23:48     ` daniel.sangorrin at toshiba.co.jp
2019-06-18 14:42       ` Ben Hutchings [this message]
2019-06-17 20:15 ` [cip-dev] [cip-kernel-sec 1/2] remotes: refer to configuration files Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560868973.21054.36.camel@codethink.co.uk \
    --to=ben.hutchings@codethink.co.uk \
    --cc=cip-dev@lists.cip-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.