All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Mark Brown <broonie@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
Date: Mon, 25 Sep 2017 12:31:03 -0700	[thread overview]
Message-ID: <156431d9-a518-53e7-17d9-bb1ee0f637bb@infradead.org> (raw)
In-Reply-To: <20170925192256.bmrm6gmb4idvomxb@sirena.org.uk>

On 09/25/17 12:22, Mark Brown wrote:
> On Mon, Sep 25, 2017 at 09:20:31PM +0200, Geert Uytterhoeven wrote:
> 
>> The issue is builtin drivers that depend on a modular API.  The clean way
>> is to separate API and implementation, so the API can be builtin, and the
>> implementation can be modular.
>> Hence the API should provide stubs that call into function pointers, to be
>> registered by the module providing the implementation.
> 
> In this case the problem is even more basic in that the driver does
> actually depend on having hwspinlocks for any production use.
> 

so just add:
	depends on HWSPINLOCK

Is that satisfactory to you?

-- 
~Randy

  reply	other threads:[~2017-09-25 19:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21 18:02 [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap
2017-09-22  9:26 ` Mark Brown
2017-09-22  9:26   ` Mark Brown
2017-09-23  1:46   ` Randy Dunlap
2017-09-23  1:46     ` Randy Dunlap
2017-09-25 16:12     ` Mark Brown
2017-09-25 16:12       ` Mark Brown
2017-09-25 17:19       ` Randy Dunlap
2017-09-25 17:36         ` Mark Brown
2017-09-25 17:36           ` Mark Brown
2017-09-25 19:20         ` Geert Uytterhoeven
2017-09-25 19:20           ` Geert Uytterhoeven
2017-09-25 19:22           ` Mark Brown
2017-09-25 19:31             ` Randy Dunlap [this message]
2017-09-25 19:44               ` Mark Brown
2017-09-25 19:44                 ` Mark Brown
2017-09-25 19:53                 ` Randy Dunlap
2017-09-25 19:53                   ` Randy Dunlap
2017-09-25 21:11                   ` Mark Brown
2017-09-25 21:11                     ` Mark Brown
2017-09-25 22:32                     ` Randy Dunlap
2017-09-25 22:32                       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156431d9-a518-53e7-17d9-bb1ee0f637bb@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=broonie@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.