All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: hch@infradead.org, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Damien.LeMoal@wdc.com, Christoph Hellwig <hch@lst.de>,
	agruenba@redhat.com
Subject: [PATCH 5/6] xfs: set IOMAP_F_NEW more carefully
Date: Mon, 29 Jul 2019 18:18:12 -0700	[thread overview]
Message-ID: <156444949222.2682261.18443282354059824172.stgit@magnolia> (raw)
In-Reply-To: <156444945993.2682261.3926017251626679029.stgit@magnolia>

From: Christoph Hellwig <hch@lst.de>

Don't set IOMAP_F_NEW if we COW over and existing allocated range, as
these aren't strictly new allocations.  This is required to be able to
use IOMAP_F_NEW to zero newly allocated blocks, which is required for
the iomap code to fully support file systems that don't do delayed
allocations or use unwritten extents.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_iomap.c |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)


diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index 3a4310d7cb59..434ff589f0fc 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -707,9 +707,12 @@ xfs_file_iomap_begin_delay(
 	 * Flag newly allocated delalloc blocks with IOMAP_F_NEW so we punch
 	 * them out if the write happens to fail.
 	 */
-	iomap->flags |= IOMAP_F_NEW;
-	trace_xfs_iomap_alloc(ip, offset, count, whichfork,
-			whichfork == XFS_DATA_FORK ? &imap : &cmap);
+	if (whichfork == XFS_DATA_FORK) {
+		iomap->flags |= IOMAP_F_NEW;
+		trace_xfs_iomap_alloc(ip, offset, count, whichfork, &imap);
+	} else {
+		trace_xfs_iomap_alloc(ip, offset, count, whichfork, &cmap);
+	}
 done:
 	if (whichfork == XFS_COW_FORK) {
 		if (imap.br_startoff > offset_fsb) {


  parent reply	other threads:[~2019-07-30  1:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  1:17 [PATCH v4 0/6] iomap: lift the xfs writepage code into iomap Darrick J. Wong
2019-07-30  1:17 ` [PATCH 1/6] list.h: add list_pop and list_pop_entry helpers Darrick J. Wong
2019-07-30  1:17   ` Darrick J. Wong
2019-07-30  1:17 ` [PATCH 2/6] iomap: copy the xfs writeback code to iomap.c Darrick J. Wong
2019-08-04 14:59   ` Andreas Gruenbacher
2019-08-06  5:33     ` Christoph Hellwig
2019-08-05 12:31   ` Andreas Gruenbacher
2019-08-06  5:32     ` Christoph Hellwig
2019-07-30  1:17 ` [PATCH 3/6] iomap: add tracing for the address space operations Darrick J. Wong
2019-07-30  1:18 ` [PATCH 4/6] iomap: warn on inline maps in iomap_writepage_map Darrick J. Wong
2019-07-30  1:18 ` Darrick J. Wong [this message]
2019-07-30  1:18 ` [PATCH 6/6] iomap: zero newly allocated mapped blocks Darrick J. Wong
2019-07-30 14:48 ` [PATCH v4 0/6] iomap: lift the xfs writepage code into iomap Christoph Hellwig
2019-08-05 12:34   ` Andreas Gruenbacher
2019-08-16  6:52 ` Christoph Hellwig
2019-08-17  1:46   ` Darrick J. Wong
2019-08-17  8:25     ` Andreas Gruenbacher
2019-08-17 13:15     ` Damien Le Moal
2019-08-20  7:30     ` Christoph Hellwig
2019-09-01  7:34     ` Christoph Hellwig
2019-09-01 20:44       ` Darrick J. Wong
2019-09-02 17:16         ` Christoph Hellwig
2019-09-10  7:01           ` Christoph Hellwig
2019-09-10 21:30             ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156444949222.2682261.18443282354059824172.stgit@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=agruenba@redhat.com \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.