All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: jeff.kubascik@dornerworks.com
Cc: Stewart.Hildebrand@dornerworks.com, peter.maydell@linaro.org,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org,
	Jarvis.Roach@dornerworks.com
Subject: Re: [PATCH] target/arm: adjust program counter for wfi exception in AArch32
Date: Fri, 10 Jan 2020 11:19:11 -0800 (PST)	[thread overview]
Message-ID: <157868394996.15422.12153523141237065812@37313f22b938> (raw)
In-Reply-To: <20200110180211.29025-1-jeff.kubascik@dornerworks.com>

Patchew URL: https://patchew.org/QEMU/20200110180211.29025-1-jeff.kubascik@dornerworks.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] target/arm: adjust program counter for wfi exception in AArch32
Type: series
Message-id: 20200110180211.29025-1-jeff.kubascik@dornerworks.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
800339c target/arm: adjust program counter for wfi exception in AArch32

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary for all arms of this statement
#30: FILE: target/arm/op_helper.c:298:
+        if (env->aarch64)
[...]
+        else
[...]

total: 1 errors, 0 warnings, 12 lines checked

Commit 800339c7aaeb (target/arm: adjust program counter for wfi exception in AArch32) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200110180211.29025-1-jeff.kubascik@dornerworks.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  reply	other threads:[~2020-01-10 19:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 18:02 [PATCH] target/arm: adjust program counter for wfi exception in AArch32 Jeff Kubascik
2020-01-10 19:19 ` no-reply [this message]
2020-01-14  2:41 ` Richard Henderson
2020-01-14 13:22   ` Jeff Kubascik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157868394996.15422.12153523141237065812@37313f22b938 \
    --to=no-reply@patchew.org \
    --cc=Jarvis.Roach@dornerworks.com \
    --cc=Stewart.Hildebrand@dornerworks.com \
    --cc=jeff.kubascik@dornerworks.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.