From: Thomas Monjalon <thomas@monjalon.net>
To: Lewis Donzis <lew@perftech.com>
Cc: dev@dpdk.org, "Wiles, Keith" <keith.wiles@intel.com>
Subject: Re: Change ether_addr to avoid conflict
Date: Tue, 23 Oct 2018 10:37:34 +0200 [thread overview]
Message-ID: <1590899.CaVHfE2u3J@xps> (raw)
In-Reply-To: <FD57382B-A108-4003-8E5C-A62374C66647@intel.com>
22/10/2018 17:06, Wiles, Keith:
>
> > On Oct 21, 2018, at 8:39 AM, Lewis Donzis <lew@perftech.com> wrote:
> >
> > Please consider changing “struct ether_addr” in rte_ether.h to “struct rte_ether_addr”, in order to avoid conflicts with the same structure name /usr/include/net/ethernet.h.
> >
> > This is kind of a pain for us since we would like to include ethernet.h in order to get some other definitions, but we can’t because it conflicts with the same structure name in rte_ether.h.
>
> I agree, but it will require a deprecation notice as a lot of code uses it.
Yes, it is a very long standing issue.
During the last technical board meeting, we discussed a plan to fix it:
http://mails.dpdk.org/archives/dev/2018-October/116695.html
next prev parent reply other threads:[~2018-10-23 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 15:39 Change ether_addr to avoid conflict Lewis Donzis
2018-10-22 15:06 ` Wiles, Keith
2018-10-23 8:37 ` Thomas Monjalon [this message]
2018-10-24 12:35 Lewis Donzis
2018-10-24 16:11 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590899.CaVHfE2u3J@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=lew@perftech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.