From: Pkshih <pkshih@realtek.com>
To: "joe@perches.com" <joe@perches.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations
Date: Mon, 29 Jun 2020 02:09:24 +0000 [thread overview]
Message-ID: <1593396529.11412.6.camel@realtek.com> (raw)
In-Reply-To: <0f24268338756bb54b4e44674db4aaf90f8a9fca.camel@perches.com>
On Sun, 2020-06-28 at 03:17 -0700, Joe Perches wrote:
Use 'rtlwifi:' as subject title prefix is enough, likes
rtlwifi: Use const in swing_table declarations
> Reduce data usage about 1KB by using const.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> .../net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | 4 +-
> .../net/wireless/realtek/rtlwifi/rtl8723be/dm.c | 4 +-
> .../net/wireless/realtek/rtlwifi/rtl8821ae/dm.c | 98 ++++++++++++---------
> -
> 3 files changed, 56 insertions(+), 50 deletions(-)
>
>
[...]
>
>
> static void rtl8812ae_get_delta_swing_table(struct ieee80211_hw *hw,
> - u8 **up_a, u8 **down_a,
> - u8 **up_b, u8 **down_b)
> + const u8 **up_a,
> + const u8 **down_a,
> + const u8 **up_b,
> + const u8 **down_b)
> {
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct rtl_phy *rtlphy = &rtlpriv->phy;
>
Please remove below type casting:
@@ -1872,10 +1872,10 @@ static void rtl8821ae_get_delta_swing_table(struct
ieee80211_hw *hw,
*up_b = rtl8821ae_delta_swing_table_idx_5gb_p[2];
*down_b = rtl8821ae_delta_swing_table_idx_5gb_n[2];
} else {
- *up_a = (u8 *)rtl8818e_delta_swing_table_idx_24gb_p;
- *down_a = (u8 *)rtl8818e_delta_swing_table_idx_24gb_n;
- *up_b = (u8 *)rtl8818e_delta_swing_table_idx_24gb_p;
- *down_b = (u8 *)rtl8818e_delta_swing_table_idx_24gb_n;
+ *up_a = rtl8818e_delta_swing_table_idx_24gb_p;
+ *down_a = rtl8818e_delta_swing_table_idx_24gb_n;
+ *up_b = rtl8818e_delta_swing_table_idx_24gb_p;
+ *down_b = rtl8818e_delta_swing_table_idx_24gb_n;
}
return;
}
[...]
next prev parent reply other threads:[~2020-06-29 2:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 10:17 [PATCH] rtlwifi/*/dm.c: Use const in swing_table declarations Joe Perches
2020-06-29 2:09 ` Pkshih [this message]
2020-06-29 2:51 ` joe
2020-06-29 3:12 ` Pkshih
2020-06-29 3:34 ` Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593396529.11412.6.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.