From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>, linux-scsi@vger.kernel.org
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: sd: suppress suprious block errors when WRITE SAME is being disabled
Date: Thu, 7 Jan 2021 23:19:34 -0500 [thread overview]
Message-ID: <161007949339.9892.8564988032616099032.b4-ty@oracle.com> (raw)
In-Reply-To: <20201207221021.28243-1-emilne@redhat.com>
On Mon, 7 Dec 2020 17:10:21 -0500, Ewan D. Milne wrote:
> The block layer code will split a large zeroout request into multiple bios
> and if WRITE SAME is disabled because the storage device reports that it
> does not support it (or support the length used), we can get an error message
> from the block layer despite the setting of RQF_QUIET on the first request.
> This is because more than one request may have already been submitted.
>
> Fix this by setting RQF_QUIET when BLK_STS_TARGET is returned to fail the
> request early, we don't need to log a message because we did not actually
> submit the command to the device, and the block layer code will handle the
> error by submitting individual write bios.
Applied to 5.11/scsi-fixes, thanks!
[1/1] scsi: sd: suppress suprious block errors when WRITE SAME is being disabled
https://git.kernel.org/mkp/scsi/c/e5cc9002caaf
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-01-08 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 22:10 [PATCH] scsi: sd: suppress suprious block errors when WRITE SAME is being disabled Ewan D. Milne
2020-12-09 17:51 ` Christoph Hellwig
2021-01-08 4:19 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161007949339.9892.8564988032616099032.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.