Re: [PULL 00/10] For 6.0 patches

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210328184533.752840-1-marcandre.lureau@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210328184533.752840-1-marcandre.lureau@redhat.com
Subject: [PULL 00/10] For 6.0 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210328184533.752840-1-marcandre.lureau@redhat.com -> patchew/20210328184533.752840-1-marcandre.lureau@redhat.com
Switched to a new branch 'test'
cd52ca9 tests: Add tests for yank with the chardev-change case
442c7e4 chardev: Fix yank with the chardev-change case
fa90829 chardev/char.c: Always pass id to chardev_new
0ee1fbc chardev/char.c: Move object_property_try_add_child out of chardev_new
0bb8f82 yank: Always link full yank code
6bcc10f yank: Remove dependency on qiochannel
a15a59f docs: simplify each section title
cfd08be sphinx: adopt kernel readthedoc theme
0295885 dbus-vmstate: Increase the size of input stream buffer used during load
8e43270 util: fix use-after-free in module_load_one

=== OUTPUT BEGIN ===
1/10 Checking commit 8e43270ef1f8 (util: fix use-after-free in module_load_one)
2/10 Checking commit 029588549aba (dbus-vmstate: Increase the size of input stream buffer used during load)
3/10 Checking commit cfd08be5e0ab (sphinx: adopt kernel readthedoc theme)
Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
deleted file mode 100644

total: 0 errors, 1 warnings, 283 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/10 Checking commit a15a59f66a52 (docs: simplify each section title)
5/10 Checking commit 6bcc10f20e5a (yank: Remove dependency on qiochannel)
6/10 Checking commit 0bb8f82e839a (yank: Always link full yank code)
7/10 Checking commit 0ee1fbce3458 (chardev/char.c: Move object_property_try_add_child out of chardev_new)
8/10 Checking commit fa9082938228 (chardev/char.c: Always pass id to chardev_new)
9/10 Checking commit 442c7e4ebee8 (chardev: Fix yank with the chardev-change case)
10/10 Checking commit cd52ca9c1c1d (tests: Add tests for yank with the chardev-change case)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#231: FILE: tests/unit/test-yank.c:180:
+#define CHAR_CHANGE_TEST(name, _old_yank, _new_yank)                           \
+        g_test_add_data_func("/yank/char_change/success/" # name,              \
+                             &(CharChangeTestConfig) { .addr = &tcpaddr,       \
+                                                       .old_yank = (_old_yank),\
+                                                       .new_yank = (_new_yank),\
+                                                       .fail = false },        \
+                             char_change_test);                                \
+        g_test_add_data_func("/yank/char_change/fail/" # name,                 \
+                             &(CharChangeTestConfig) { .addr = &tcpaddr,       \
+                                                       .old_yank = (_old_yank),\
+                                                       .new_yank = (_new_yank),\
+                                                       .fail = true },         \
+                             char_change_test);

total: 1 errors, 0 warnings, 216 lines checked

Patch 10/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210328184533.752840-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com