All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: pbonzini@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3
Date: Tue, 13 Apr 2021 10:05:36 -0700 (PDT)	[thread overview]
Message-ID: <161833353579.10350.18278026278164568995@72b6d80f974b> (raw)
In-Reply-To: <20210413160850.240064-1-pbonzini@redhat.com>

Patchew URL: https://patchew.org/QEMU/20210413160850.240064-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210413160850.240064-1-pbonzini@redhat.com
Subject: [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
487722a qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code
588f61f osdep: protect qemu/osdep.h with extern "C"
5316327 osdep: include glib-compat.h before other QEMU headers

=== OUTPUT BEGIN ===
1/3 Checking commit 5316327519a7 (osdep: include glib-compat.h before other QEMU headers)
2/3 Checking commit 588f61fea9ae (osdep: protect qemu/osdep.h with extern "C")
WARNING: architecture specific defines should be avoided
#51: FILE: include/qemu/compiler.h:14:
+#ifdef __cplusplus

ERROR: storage class should be at the beginning of the declaration
#52: FILE: include/qemu/compiler.h:15:
+#define QEMU_EXTERN_C extern "C"

ERROR: storage class should be at the beginning of the declaration
#54: FILE: include/qemu/compiler.h:17:
+#define QEMU_EXTERN_C extern

WARNING: architecture specific defines should be avoided
#77: FILE: include/qemu/osdep.h:116:
+#ifdef __cplusplus

WARNING: architecture specific defines should be avoided
#88: FILE: include/qemu/osdep.h:730:
+#ifdef __cplusplus

total: 2 errors, 3 warnings, 47 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 487722a3d4ef (qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210413160850.240064-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2021-04-13 17:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 16:08 [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3 Paolo Bonzini
2021-04-13 16:08 ` [PULL v2 1/3] osdep: include glib-compat.h before other QEMU headers Paolo Bonzini
2021-04-14 16:51   ` Philippe Mathieu-Daudé
2021-04-14 17:00   ` Daniel P. Berrangé
2021-04-13 16:08 ` [PULL v2 2/3] osdep: protect qemu/osdep.h with extern "C" Paolo Bonzini
2021-04-14 17:07   ` Daniel P. Berrangé
2021-04-14 18:39     ` Peter Maydell
2021-04-14 18:50     ` Peter Maydell
2021-04-15  9:20       ` Daniel P. Berrangé
2021-04-13 16:08 ` [PULL v2 3/3] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code Paolo Bonzini
2021-04-13 17:05 ` no-reply [this message]
2021-04-13 20:15 ` [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3 Peter Maydell
2021-04-14 12:10   ` Peter Maydell
2021-04-14 18:22 ` Peter Maydell
2021-04-15  5:57   ` Markus Armbruster
2021-04-15 10:48     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161833353579.10350.18278026278164568995@72b6d80f974b \
    --to=no-reply@patchew.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.