All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiaofei Tan <tanxiaofei@huawei.com>
To: <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linuxarm@openeuler.org>,
	Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [PATCH 07/17] tty: tty_io: Add a blank line after declarations
Date: Wed, 12 May 2021 17:26:15 +0800	[thread overview]
Message-ID: <1620811585-18582-8-git-send-email-tanxiaofei@huawei.com> (raw)
In-Reply-To: <1620811585-18582-1-git-send-email-tanxiaofei@huawei.com>

Add a blank line after declarations, reported by checkpatch.pl.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
---
 drivers/tty/tty_io.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index c5b0e49..8b9430c 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -320,6 +320,7 @@ static struct tty_driver *get_tty_driver(dev_t device, int *index)
 
 	list_for_each_entry(p, &tty_drivers, tty_drivers) {
 		dev_t base = MKDEV(p->major, p->minor_start);
+
 		if (device < base || device >= base + p->num)
 			continue;
 		*index = device - base;
@@ -1033,6 +1034,7 @@ static inline ssize_t do_tty_write(
 	/* Do the write .. */
 	for (;;) {
 		size_t size = count;
+
 		if (size > chunk)
 			size = chunk;
 
@@ -1155,6 +1157,7 @@ ssize_t redirected_tty_write(struct kiocb *iocb, struct iov_iter *iter)
 	 */
 	if (p) {
 		ssize_t res;
+
 		res = file_tty_write(p, iocb, iter);
 		fput(p);
 		return res;
@@ -1942,6 +1945,7 @@ static struct tty_driver *tty_lookup_driver(dev_t device, struct file *filp,
 #ifdef CONFIG_VT
 	case MKDEV(TTY_MAJOR, 0): {
 		extern struct tty_driver *console_driver;
+
 		driver = tty_driver_kref_get(console_driver);
 		*index = fg_console;
 		break;
@@ -1949,6 +1953,7 @@ static struct tty_driver *tty_lookup_driver(dev_t device, struct file *filp,
 #endif
 	case MKDEV(TTYAUX_MAJOR, 1): {
 		struct tty_driver *console_driver = console_device(index);
+
 		if (console_driver) {
 			driver = tty_driver_kref_get(console_driver);
 			if (driver && filp) {
@@ -2388,6 +2393,7 @@ EXPORT_SYMBOL(tty_do_resize);
 static int tiocswinsz(struct tty_struct *tty, struct winsize __user *arg)
 {
 	struct winsize tmp_ws;
+
 	if (copy_from_user(&tmp_ws, arg, sizeof(*arg)))
 		return -EFAULT;
 
@@ -2412,6 +2418,7 @@ static int tioccons(struct file *file)
 		return -EPERM;
 	if (file->f_op->write_iter == redirected_tty_write) {
 		struct file *f;
+
 		spin_lock(&redirect_lock);
 		f = redirect;
 		redirect = NULL;
@@ -2734,6 +2741,7 @@ long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	case TIOCGEXCL:
 	{
 		int excl = test_bit(TTY_EXCLUSIVE, &tty->flags);
+
 		return put_user(excl, (int __user *)p);
 	}
 	case TIOCGETD:
@@ -2748,6 +2756,7 @@ long tty_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 	case TIOCGDEV:
 	{
 		unsigned int ret = new_encode_dev(tty_devnum(real_tty));
+
 		return put_user(ret, (unsigned int __user *)p);
 	}
 	/*
@@ -3103,6 +3112,7 @@ EXPORT_SYMBOL(do_SAK);
 static struct device *tty_get_device(struct tty_struct *tty)
 {
 	dev_t devt = tty_devnum(tty);
+
 	return class_find_device_by_devt(tty_class, devt);
 }
 
-- 
2.8.1


  parent reply	other threads:[~2021-05-12  9:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  9:26 [PATCH 00/17] tty: Fix some coding style issues Xiaofei Tan
2021-05-12  9:26 ` [PATCH 01/17] tty: tty_baudrate: Remove unnecessary tab and spaces in comment sentence Xiaofei Tan
2021-05-12  9:26 ` [PATCH 02/17] tty: tty_baudrate: Fix coding style issues of block comments Xiaofei Tan
2021-05-12  9:26 ` [PATCH 03/17] tty: tty_buffer: Add a blank line after declarations Xiaofei Tan
2021-05-12  9:26 ` [PATCH 04/17] tty: tty_buffer: Remove the repeated word 'the' Xiaofei Tan
2021-05-12  9:26 ` [PATCH 05/17] tty: tty_buffer: Fix coding style issues of block comments Xiaofei Tan
2021-05-12  9:26 ` [PATCH 06/17] tty: tty_io: Remove spaces before tabs Xiaofei Tan
2021-05-12  9:26 ` Xiaofei Tan [this message]
2021-05-12  9:26 ` [PATCH 08/17] tty: tty_io: Fix spaces required around that ':' Xiaofei Tan
2021-05-12  9:26 ` [PATCH 09/17] tty: tty_io: Fix trailing whitespace issues Xiaofei Tan
2021-05-12  9:26 ` [PATCH 10/17] tty: tty_io: Fix coding style issues of block comments Xiaofei Tan
2021-05-12  9:26 ` [PATCH 11/17] tty: tty_io: Remove the repeated word 'can' Xiaofei Tan
2021-05-12  9:26 ` [PATCH 12/17] tty: tty_io: Fix an issue of code indent for conditional statements Xiaofei Tan
2021-05-12  9:26 ` [PATCH 13/17] tty: tty_io: Delete a blank line before EXPORT_SYMBOL(foo) Xiaofei Tan
2021-05-12  9:26 ` [PATCH 14/17] tty: tty_io: Remove return in void function Xiaofei Tan
2021-05-12  9:26 ` [PATCH 15/17] tty: tty_port: Delete a blank line before EXPORT_SYMBOL(foo) Xiaofei Tan
2021-05-12  9:26 ` [PATCH 16/17] tty: tty_port: Add a blank line after declarations Xiaofei Tan
2021-05-12  9:26 ` [PATCH 17/17] tty: tty_port: Fix coding style issues of block comments Xiaofei Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1620811585-18582-8-git-send-email-tanxiaofei@huawei.com \
    --to=tanxiaofei@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.