All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jay Fang <f.fangjian@huawei.com>
To: <gregkh@linuxfoundation.org>
Cc: <linux-serial@vger.kernel.org>, <linuxarm@huawei.com>,
	<huangdaode@huawei.com>, <tangzihao1@hisilicon.com>
Subject: [PATCH 07/11] tty: serial: bcm63xx_uart: Fix some coding style issues
Date: Tue, 18 May 2021 09:57:14 +0800	[thread overview]
Message-ID: <1621303038-12062-8-git-send-email-f.fangjian@huawei.com> (raw)
In-Reply-To: <1621303038-12062-1-git-send-email-f.fangjian@huawei.com>

From: Zihao Tang <tangzihao1@hisilicon.com>

Fix 5 coding style warings reported by checkpatch.pl.

Fix 4 "WARNING: Block comments use a trailing */ on a separate line".
Fix 1 "WARNING: Prefer 'unsigned int' to bare use of 'unsigned'".

Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
---
 drivers/tty/serial/bcm63xx_uart.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serial/bcm63xx_uart.c b/drivers/tty/serial/bcm63xx_uart.c
index 5fb0e84..76e2ab6 100644
--- a/drivers/tty/serial/bcm63xx_uart.c
+++ b/drivers/tty/serial/bcm63xx_uart.c
@@ -231,21 +231,24 @@ static void bcm_uart_do_rx(struct uart_port *port)
 
 	/* limit number of char read in interrupt, should not be
 	 * higher than fifo size anyway since we're much faster than
-	 * serial port */
+	 * serial port
+	 */
 	max_count = 32;
 	do {
 		unsigned int iestat, c, cstat;
 		char flag;
 
 		/* get overrun/fifo empty information from ier
-		 * register */
+		 * register
+		 */
 		iestat = bcm_uart_readl(port, UART_IR_REG);
 
 		if (unlikely(iestat & UART_IR_STAT(UART_IR_RXOVER))) {
 			unsigned int val;
 
 			/* fifo reset is required to clear
-			 * interrupt */
+			 * interrupt
+			 */
 			val = bcm_uart_readl(port, UART_CTL_REG);
 			val |= UART_CTL_RSTRXFIFO_MASK;
 			bcm_uart_writel(port, val, UART_CTL_REG);
@@ -424,7 +427,8 @@ static void bcm_uart_flush(struct uart_port *port)
 	bcm_uart_writel(port, val, UART_CTL_REG);
 
 	/* read any pending char to make sure all irq status are
-	 * cleared */
+	 * cleared
+	 */
 	(void)bcm_uart_readl(port, UART_FIFO_REG);
 }
 
@@ -764,7 +768,7 @@ static int __init bcm63xx_console_init(void)
 
 console_initcall(bcm63xx_console_init);
 
-static void bcm_early_write(struct console *con, const char *s, unsigned n)
+static void bcm_early_write(struct console *con, const char *s, unsigned int n)
 {
 	struct earlycon_device *dev = con->data;
 
-- 
2.7.4


  parent reply	other threads:[~2021-05-18  1:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  1:57 [PATCH 00/11] tty: serial: Fix some coding style issues Jay Fang
2021-05-18  1:57 ` [PATCH 01/11] tty: serial: 21285: Fix some coding sytle issues Jay Fang
2021-05-18  1:57 ` [PATCH 02/11] tty: serial: amba-pl010: Fix 2 coding style issues Jay Fang
2021-05-18  1:57 ` [PATCH 03/11] tty: serial: amba-pl011: Replace the unsuitable spaces with tabs Jay Fang
2021-05-18  1:57 ` [PATCH 04/11] tty: serial: amba-pl011: Remove initialization of static variable Jay Fang
2021-05-18  1:57 ` [PATCH 05/11] tty: serial: apbuart: Fix some coding sytle issues Jay Fang
2021-05-18  1:57 ` [PATCH 06/11] tty: serial: atmel: Fix some coding style issues Jay Fang
2021-05-18  1:57 ` Jay Fang [this message]
2021-05-18  1:57 ` [PATCH 08/11] tty: serial: clps711x: Fix some coding style issuses Jay Fang
2021-05-18  1:57 ` [PATCH 09/11] tty: serial: digicolor: Use 'unsigned int' instead of 'unsigned' Jay Fang
2021-05-18  1:57 ` [PATCH 10/11] tty: serial: dz: " Jay Fang
2021-05-18  1:57 ` [PATCH 11/11] tty: serial: earlycon-arm-semihost : Fix some coding style issuses Jay Fang
2021-05-18  5:39 ` [PATCH 00/11] tty: serial: Fix some coding style issues Greg KH
2021-05-21  8:56 ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1621303038-12062-8-git-send-email-f.fangjian@huawei.com \
    --to=f.fangjian@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=huangdaode@huawei.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=tangzihao1@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.