All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Lucas De Marchi" <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Finish conversion to GRAPHICS_VER
Date: Thu, 27 May 2021 21:25:51 -0000	[thread overview]
Message-ID: <162215075190.12240.14496896454382533811@emeril.freedesktop.org> (raw)
In-Reply-To: <20210527181700.1676790-1-lucas.demarchi@intel.com>

== Series Details ==

Series: Finish conversion to GRAPHICS_VER
URL   : https://patchwork.freedesktop.org/series/90693/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c7eb65fd23b6 drm/i915/gt: replace IS_GEN and friends with IS_GRAPHICS_VER
-:2316: WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#2316: FILE: drivers/gpu/drm/i915/gt/selftest_llc.c:47:
+			       intel_gpu_freq(rps, gpu_freq * (GRAPHICS_VER(i915) >= 9 ? GEN9_FREQ_SCALER : 1)),

-:2325: WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#2325: FILE: drivers/gpu/drm/i915/gt/selftest_llc.c:57:
+			       intel_gpu_freq(rps, gpu_freq * (GRAPHICS_VER(i915) >= 9 ? GEN9_FREQ_SCALER : 1)),

total: 0 errors, 2 warnings, 0 checks, 2252 lines checked
dc0babe0e3f4 drm/i915/gt: Add remaining conversions to GRAPHICS_VER
bf349477ef65 drm/i915/gem: replace IS_GEN and friends with IS_GRAPHICS_VER
5f5511830f0a drm/i915/gvt: replace IS_GEN and friends with IS_GRAPHICS_VER
e466a8d9d7b2 drm/i915: replace IS_GEN and friends with IS_GRAPHICS_VER
-:149: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#149: FILE: drivers/gpu/drm/i915/i915_debugfs.c:500:
+			   (gt_perf_status & (GRAPHICS_VER(dev_priv) >= 9 ? 0x1ff00 : 0xff00)) >> 8);

total: 0 errors, 1 warnings, 0 checks, 1352 lines checked
39f44ce0df3a drm/i915: Add remaining conversions to GRAPHICS_VER
-:23: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#23: FILE: drivers/gpu/drm/i915/i915_drv.h:1567:
+#define IS_GEN9_LP(dev_priv)	(GRAPHICS_VER(dev_priv) == 9 && IS_LP(dev_priv))

-:24: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#24: FILE: drivers/gpu/drm/i915/i915_drv.h:1568:
+#define IS_GEN9_BC(dev_priv)	(GRAPHICS_VER(dev_priv) == 9 && !IS_LP(dev_priv))

-:59: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#59: FILE: drivers/gpu/drm/i915/i915_drv.h:1635:
+#define HAS_GMBUS_BURST_READ(dev_priv) (GRAPHICS_VER(dev_priv) >= 10 || \
 					IS_GEMINILAKE(dev_priv) || \
 					IS_KABYLAKE(dev_priv))

-:69: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#69: FILE: drivers/gpu/drm/i915/i915_drv.h:1642:
+#define HAS_128_BYTE_Y_TILING(dev_priv) (GRAPHICS_VER(dev_priv) != 2 && \
+					 !(IS_I915G(dev_priv) || IS_I915GM(dev_priv)))

-:78: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#78: FILE: drivers/gpu/drm/i915/i915_drv.h:1649:
+#define HAS_CUR_FBC(dev_priv)	(!HAS_GMCH(dev_priv) && GRAPHICS_VER(dev_priv) >= 7)

total: 0 errors, 0 warnings, 5 checks, 207 lines checked
473d823e7205 drm/i915/display: replace IS_GEN() in commented code


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-05-27 21:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 18:16 [Intel-gfx] [PATCH 0/7] Finish conversion to GRAPHICS_VER Lucas De Marchi
2021-05-27 18:16 ` [Intel-gfx] [PATCH 1/7] drm/i915/gt: replace IS_GEN and friends with IS_GRAPHICS_VER Lucas De Marchi
2021-06-01 16:58   ` Matt Roper
2021-06-01 17:15     ` Lucas De Marchi
2021-06-01 17:30       ` Matt Roper
2021-06-01 19:13         ` Lucas De Marchi
2021-06-01 20:39           ` Matt Roper
2021-06-01 20:53             ` Lucas De Marchi
2021-06-02  6:34             ` Lucas De Marchi
2021-06-02 16:00               ` Matt Roper
2021-05-27 18:16 ` [Intel-gfx] [PATCH 2/7] drm/i915/gt: Add remaining conversions to GRAPHICS_VER Lucas De Marchi
2021-05-27 18:16 ` [Intel-gfx] [PATCH 3/7] drm/i915/gem: replace IS_GEN and friends with IS_GRAPHICS_VER Lucas De Marchi
2021-05-27 18:16 ` [Intel-gfx] [PATCH 4/7] drm/i915/gvt: " Lucas De Marchi
2021-05-27 18:16 ` [Intel-gfx] [PATCH 5/7] drm/i915: " Lucas De Marchi
2021-05-27 18:16 ` [Intel-gfx] [PATCH 6/7] drm/i915: Add remaining conversions to GRAPHICS_VER Lucas De Marchi
2021-05-27 18:17 ` [Intel-gfx] [PATCH 7/7] drm/i915/display: replace IS_GEN() in commented code Lucas De Marchi
2021-05-27 21:25 ` Patchwork [this message]
2021-05-27 21:27 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Finish conversion to GRAPHICS_VER Patchwork
2021-05-27 21:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-05-28 19:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162215075190.12240.14496896454382533811@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.