From: "tip-bot2 for Peter Zijlstra" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: perf/urgent] irq_work: Make irq_work_queue() NMI-safe again
Date: Thu, 10 Jun 2021 07:02:50 -0000 [thread overview]
Message-ID: <162330857005.29796.2967900864699325697.tip-bot2@tip-bot2> (raw)
In-Reply-To: <YL+uBq8LzXXZsYVf@hirez.programming.kicks-ass.net>
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: dc6be79444d82d5b9d679c7d6bd77c672f1e28ca
Gitweb: https://git.kernel.org/tip/dc6be79444d82d5b9d679c7d6bd77c672f1e28ca
Author: Peter Zijlstra <peterz@infradead.org>
AuthorDate: Tue, 08 Jun 2021 19:54:15 +02:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 08 Jun 2021 20:03:59 +02:00
irq_work: Make irq_work_queue() NMI-safe again
Someone carelessly put NMI unsafe code in irq_work_queue(), breaking
just about every single user. Also, someone has a terrible comment
style.
Reported-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/YL+uBq8LzXXZsYVf@hirez.programming.kicks-ass.net
---
kernel/irq_work.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 23a7a0b..db8c248 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -70,9 +70,6 @@ bool irq_work_queue(struct irq_work *work)
if (!irq_work_claim(work))
return false;
- /*record irq_work call stack in order to print it in KASAN reports*/
- kasan_record_aux_stack(work);
-
/* Queue the entry and raise the IPI if needed. */
preempt_disable();
__irq_work_queue_local(work);
next prev parent reply other threads:[~2021-06-10 7:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 6:32 [PATCH] irq_work: record irq_work_queue() call stack qiang.zhang
2021-03-31 10:02 ` Dmitry Vyukov
2021-04-02 14:52 ` Andrey Konovalov
2021-06-08 17:51 ` Peter Zijlstra
2021-06-08 17:59 ` [PATCH] irq_work: Make irq_work_queue() NMI-safe again Peter Zijlstra
2021-06-10 7:02 ` tip-bot2 for Peter Zijlstra [this message]
2021-06-10 8:13 ` [tip: perf/urgent] " tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162330857005.29796.2967900864699325697.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.