From: "tip-bot2 for Peter Zijlstra" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: objtool/urgent] objtool/x86: Ignore __x86_indirect_alt_* symbols
Date: Mon, 21 Jun 2021 17:53:29 -0000 [thread overview]
Message-ID: <162429800985.395.5319249290550367396.tip-bot2@tip-bot2> (raw)
In-Reply-To: <YNCgxwLBiK9wclYJ@hirez.programming.kicks-ass.net>
The following commit has been merged into the objtool/urgent branch of tip:
Commit-ID: 31197d3a0f1caeb60fb01f6755e28347e4f44037
Gitweb: https://git.kernel.org/tip/31197d3a0f1caeb60fb01f6755e28347e4f44037
Author: Peter Zijlstra <peterz@infradead.org>
AuthorDate: Mon, 21 Jun 2021 16:13:55 +02:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Mon, 21 Jun 2021 17:26:57 +02:00
objtool/x86: Ignore __x86_indirect_alt_* symbols
Because the __x86_indirect_alt* symbols are just that, objtool will
try and validate them as regular symbols, instead of the alternative
replacements that they are.
This goes sideways for FRAME_POINTER=y builds; which generate a fair
amount of warnings.
Fixes: 9bc0bb50727c ("objtool/x86: Rewrite retpoline thunk calls")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/YNCgxwLBiK9wclYJ@hirez.programming.kicks-ass.net
---
arch/x86/lib/retpoline.S | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/x86/lib/retpoline.S b/arch/x86/lib/retpoline.S
index 4d32cb0..ec9922c 100644
--- a/arch/x86/lib/retpoline.S
+++ b/arch/x86/lib/retpoline.S
@@ -58,12 +58,16 @@ SYM_FUNC_START_NOALIGN(__x86_indirect_alt_call_\reg)
2: .skip 5-(2b-1b), 0x90
SYM_FUNC_END(__x86_indirect_alt_call_\reg)
+STACK_FRAME_NON_STANDARD(__x86_indirect_alt_call_\reg)
+
SYM_FUNC_START_NOALIGN(__x86_indirect_alt_jmp_\reg)
ANNOTATE_RETPOLINE_SAFE
1: jmp *%\reg
2: .skip 5-(2b-1b), 0x90
SYM_FUNC_END(__x86_indirect_alt_jmp_\reg)
+STACK_FRAME_NON_STANDARD(__x86_indirect_alt_jmp_\reg)
+
.endm
/*
next prev parent reply other threads:[~2021-06-21 17:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 11:36 linux-next: Tree for Apr 16 Stephen Rothwell
2021-04-16 17:50 ` linux-next: Tree for Apr 16 (objtool: warnings) Randy Dunlap
2021-06-21 13:34 ` Peter Zijlstra
2021-06-21 14:23 ` Peter Zijlstra
2021-06-21 17:53 ` tip-bot2 for Peter Zijlstra [this message]
2021-06-21 23:30 ` Randy Dunlap
2021-04-16 18:53 ` linux-next: Tree for Apr 16 (IMA appraise causing build error) Randy Dunlap
2021-04-16 20:25 ` Nayna
2021-04-16 20:32 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162429800985.395.5319249290550367396.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.