All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: hi6421v600: Fix setting idle mode
Date: Mon, 21 Jun 2021 19:45:49 +0100	[thread overview]
Message-ID: <162430087047.9551.3163979267051992655.b4-ty@kernel.org> (raw)
In-Reply-To: <20210619123423.4091429-1-axel.lin@ingics.com>

On Sat, 19 Jun 2021 20:34:23 +0800, Axel Lin wrote:
> commit db27f8294cd7 changed eco_mode << (ffs(sreg->eco_mode_mask) - 1)
> to sreg->eco_mode_mask << (ffs(sreg->eco_mode_mask) - 1) which is wrong.
> Fix it by simply set val = sreg->eco_mode_mask.
> 
> In additional, sreg->eco_mode_mask can be 0 (LDO3, LDO33, LDO34).
> Return -EINVAL if idle mode is not supported when sreg->eco_mode_mask is 0.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: hi6421v600: Fix setting idle mode
      commit: 57c045bc727001c43b6a65adb0418aa7b3e6dbd0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

      reply	other threads:[~2021-06-21 18:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-19 12:34 [PATCH] regulator: hi6421v600: Fix setting idle mode Axel Lin
2021-06-21 18:45 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162430087047.9551.3163979267051992655.b4-ty@kernel.org \
    --to=broonie@kernel.org \
    --cc=axel.lin@ingics.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.