From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9057EC49EA4 for ; Wed, 23 Jun 2021 09:02:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7364361263 for ; Wed, 23 Jun 2021 09:02:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbhFWJFO (ORCPT ); Wed, 23 Jun 2021 05:05:14 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:39569 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229833AbhFWJFN (ORCPT ); Wed, 23 Jun 2021 05:05:13 -0400 X-UUID: 552431a23ebe4ed6ab6a1b0e58b8b1c6-20210623 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=WHVs4dh6AbAKAbeIIKWBxdhvq+wckIntxxe4eFfwL3A=; b=gZMamKoetcWP3ttbQXdOp/wfPXqx/YKRVd5BPGlaE6AvZnbVcP01sgyKX9kWl7YOtN1nwYvKaDxrnEiknpXU19V0plkvv58G+rc7peFJyMUoNamQ4PIqtgbGL73P0aOV6vv+pNfZDxQ1TslBxrqooxHsFYo+GrbwSISXdsowYT4=; X-UUID: 552431a23ebe4ed6ab6a1b0e58b8b1c6-20210623 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1401636374; Wed, 23 Jun 2021 17:02:52 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Jun 2021 17:02:49 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 23 Jun 2021 17:02:48 +0800 Message-ID: <1624438968.2701.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 From: Jianjun Wang To: Lorenzo Pieralisi CC: Matthias Brugger , Chen-Yu Tsai , Ryder Lee , Bjorn Helgaas , Rob Herring , , , , , , Randy Wu , Date: Wed, 23 Jun 2021 17:02:48 +0800 In-Reply-To: <20210622110517.GB24565@lpieralisi> References: <20210601024408.24485-1-jianjun.wang@mediatek.com> <20210601024408.24485-2-jianjun.wang@mediatek.com> <1622526594.9054.6.camel@mhfsdcap03> <20210622110517.GB24565@lpieralisi> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 4D63936515B4AAF2E78DF35DD5D25263CB69BF69C06A8201811E5A3736340AA42000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVHVlLCAyMDIxLTA2LTIyIGF0IDEyOjA1ICswMTAwLCBMb3JlbnpvIFBpZXJhbGlzaSB3cm90 ZToNCj4gT24gV2VkLCBKdW4gMDIsIDIwMjEgYXQgMDE6MzM6MDdQTSArMDIwMCwgTWF0dGhpYXMg QnJ1Z2dlciB3cm90ZToNCj4gPiANCj4gPiANCj4gPiBPbiAwMS8wNi8yMDIxIDA4OjA3LCBDaGVu LVl1IFRzYWkgd3JvdGU6DQo+ID4gPiBIaSwNCj4gPiA+IA0KPiA+ID4gT24gVHVlLCBKdW4gMSwg MjAyMSBhdCAxOjUwIFBNIEppYW5qdW4gV2FuZyA8amlhbmp1bi53YW5nQG1lZGlhdGVrLmNvbT4g d3JvdGU6DQo+ID4gPj4NCj4gPiA+PiBPbiBUdWUsIDIwMjEtMDYtMDEgYXQgMTE6NTMgKzA4MDAs IENoZW4tWXUgVHNhaSB3cm90ZToNCj4gPiA+Pj4gSGksDQo+ID4gPj4+DQo+ID4gPj4+IE9uIFR1 ZSwgSnVuIDEsIDIwMjEgYXQgMTA6NTAgQU0gSmlhbmp1biBXYW5nIDxqaWFuanVuLndhbmdAbWVk aWF0ZWsuY29tPiB3cm90ZToNCj4gPiA+Pj4+DQo+ID4gPj4+PiBNVDgxOTUgaXMgYW4gQVJNIHBs YXRmb3JtIFNvQyB3aGljaCBoYXMgdGhlIHNhbWUgUENJZSBJUCB3aXRoIE1UODE5Mi4NCj4gPiA+ Pj4NCj4gPiA+Pj4gQmFzZWQgb24gd2hhdCBJJ20gc2VlaW5nIGludGVybmFsbHksIHRoZXJlIHNl ZW1zIHRvIGJlIHNvbWUgaW5jb25zaXN0ZW5jeQ0KPiA+ID4+PiBhY3Jvc3MgdGhlIE1lZGlhVGVr IHBsYXRmb3JtIG9uIHdoZXRoZXIgbmV3IGNvbXBhdGlibGUgc3RyaW5ncyBzaG91bGQgYmUNCj4g PiA+Pj4gaW50cm9kdWNlZCBmb3IgImZ1bGx5IGNvbXBhdGlibGUiIElQIGJsb2Nrcy4NCj4gPiA+ Pj4NCj4gPiA+Pj4gSWYgdGhpcyBoYXJkd2FyZSBibG9jayBpbiBNVDgxOTUgaXMgInRoZSBzYW1l IiBhcyB0aGUgb25lIGluIE1UODE5MiwgZG8gd2UNCj4gPiA+Pj4gcmVhbGx5IG5lZWQgdGhlIG5l dyBjb21wYXRpYmxlIHN0cmluZz8gQXJlIHRoZXJlIGFueSBjb25jZXJucz8NCj4gPiA+Pg0KPiA+ ID4+IEhpIENoZW4tWXUsDQo+ID4gPj4NCj4gPiA+PiBJdCdzIG9rIHRvIHJldXNlIHRoZSBjb21w YXRpYmxlIHN0cmluZyB3aXRoIE1UODE5MiwgYnV0IEkgdGhpbmsgdGhpcw0KPiA+ID4+IHdpbGwg YmUgZWFzaWVyIHRvIGZpbmQgd2hpY2ggcGxhdGZvcm1zIHRoaXMgZHJpdmVyIGlzIGNvbXBhdGli bGUgd2l0aCwNCj4gPiA+PiBlc3BlY2lhbGx5IHdoZW4gd2UgaGF2ZSBtb3JlIGFuZCBtb3JlIHBs YXRmb3JtcyBpbiB0aGUgZnV0dXJlLg0KPiA+ID4gDQo+ID4gPiBJZiBpdCdzIGp1c3QgZm9yIGlu Zm9ybWF0aW9uYWwgcHVycG9zZXMsIHRoZW4gaGF2aW5nIHRoZSBNVDgxOTIgY29tcGF0aWJsZQ0K PiA+ID4gYXMgYSBmYWxsYmFjayB3b3VsZCB3b3JrLCBhbmQgd2Ugd291bGRuJ3QgbmVlZCB0byBt YWtlIGNoYW5nZXMgdG8gdGhlIGRyaXZlci4NCj4gPiA+IFRoaXMgd29ya3MgYmV0dGVyIGVzcGVj aWFsbHkgaWYgd2UgaGF2ZSB0byBzdXBwb3J0IG11bHRpcGxlIG9wZXJhdGluZyBzeXN0ZW1zDQo+ ID4gPiB0aGF0IHVzZSBkZXZpY2UgdHJlZS4NCj4gPiA+IA0KPiA+ID4gU28gd2Ugd291bGQgd2Fu dA0KPiA+ID4gDQo+ID4gPiAgICAgIm1lZGlhdGVrLG10ODE5NS1wY2llIiwgIm1lZGlhdGVrLG10 ODE5Mi1wY2llIg0KPiA+ID4gDQo+ID4gPiBhbmQNCj4gPiA+IA0KPiA+ID4gICAgICJtZWRpYXRl ayxtdDgxOTItcGNpZSINCj4gPiA+IA0KPiA+ID4gYmUgdGhlIHZhbGlkIG9wdGlvbnMuDQo+ID4g PiANCj4gPiA+IFBlcnNvbmFsbHkgSSdtIG5vdCBzZWVpbmcgZW5vdWdoIHZhbHVlIHRvIGp1c3Rp ZnkgYWRkaW5nIHRoZSBjb21wYXRpYmxlIHN0cmluZw0KPiA+ID4ganVzdCBmb3IgaW5mb3JtYXRp b25hbCBwdXJwb3NlcyB0aG91Z2guIE9uZSBjb3VsZCBlYXNpbHkgZGlzY2VybiB3aGljaCBoYXJk d2FyZQ0KPiA+ID4gaXMgdXNlZCBieSBsb29raW5nIGF0IHRoZSBkZXZpY2UgdHJlZS4NCj4gPiA+ IA0KPiA+IA0KPiA+IEkgYWdyZWUsIGlmIG5vIGRpZmZlcmVuY2VzIGJldHdlZW4gdGhlIHR3byBj aGlwcyBhcmUga25vd24sIGFkZGluZyBhDQo+ID4gYmluZGluZyB3aXRoZSBuZXcgY29tcGF0aWJs ZSBhbmQgYSBmYWxsYmFjayBpcyBhIGdvb2QgdGhpbmcuIElmIHdlDQo+ID4gbGF0ZXIgb24gcmVh bGl6ZSB0aGF0IG10ODE5NSBQQ0kgYmxvY2sgaGFzIGRpZmZlcmVuY2VzLCB3ZSBjYW4gYWRkIHRo ZQ0KPiA+IG1hdGNoaW5nIHRvIHRoZSBkcml2ZXIuDQo+IA0KPiBTbyB0aGlzIHNlcmllcyBjYW4g YmUgZHJvcHBlZCwgcmlnaHQgPw0KDQpZZXMsIHdlIHdpbGwgc2VuZCBkdC1iaW5kaW5ncyB3aXRo IGR0cyBjaGFuZ2VzIGluIGFub3RoZXIgc2VyaWVzLA0KdGhhbmtzLg0KPiANCj4gVGhhbmtzLA0K PiBMb3JlbnpvDQo+IA0KPiA+IFJlZ2FyZHMsDQo+ID4gTWF0dGhpYXMNCj4gPiANCj4gPiA+IA0K PiA+ID4gUmVnYXJkcw0KPiA+ID4gQ2hlbll1DQo+ID4gPiANCj4gPiA+IA0KPiA+ID4+IFRoYW5r cy4NCj4gPiA+Pj4NCj4gPiA+Pj4NCj4gPiA+Pj4gVGhhbmtzDQo+ID4gPj4+IENoZW5ZdQ0KPiA+ ID4+Pg0KPiA+ID4+Pg0KPiA+ID4+Pj4gU2lnbmVkLW9mZi1ieTogSmlhbmp1biBXYW5nIDxqaWFu anVuLndhbmdAbWVkaWF0ZWsuY29tPg0KPiA+ID4+Pj4gLS0tDQo+ID4gPj4+PiAgRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9tZWRpYXRlay1wY2llLWdlbjMueWFtbCB8IDQg KysrLQ0KPiA+ID4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkNCj4gPiA+Pj4+DQo+ID4gPj4+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3BjaS9tZWRpYXRlay1wY2llLWdlbjMueWFtbCBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvbWVkaWF0ZWstcGNpZS1nZW4zLnlhbWwNCj4gPiA+ Pj4+IGluZGV4IGU3YjFmOTg5MmRhNC4uZDVlNGEzZTYzZDk3IDEwMDY0NA0KPiA+ID4+Pj4gLS0t IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9tZWRpYXRlay1wY2llLWdl bjMueWFtbA0KPiA+ID4+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L3BjaS9tZWRpYXRlay1wY2llLWdlbjMueWFtbA0KPiA+ID4+Pj4gQEAgLTQ4LDcgKzQ4LDkgQEAg YWxsT2Y6DQo+ID4gPj4+Pg0KPiA+ID4+Pj4gIHByb3BlcnRpZXM6DQo+ID4gPj4+PiAgICBjb21w YXRpYmxlOg0KPiA+ID4+Pj4gLSAgICBjb25zdDogbWVkaWF0ZWssbXQ4MTkyLXBjaWUNCj4gPiA+ Pj4+ICsgICAgb25lT2Y6DQo+ID4gPj4+PiArICAgICAgLSBjb25zdDogbWVkaWF0ZWssbXQ4MTky LXBjaWUNCj4gPiA+Pj4+ICsgICAgICAtIGNvbnN0OiBtZWRpYXRlayxtdDgxOTUtcGNpZQ0KPiA+ ID4+Pj4NCj4gPiA+Pj4+ICAgIHJlZzoNCj4gPiA+Pj4+ICAgICAgbWF4SXRlbXM6IDENCj4gPiA+ Pj4+IC0tDQo+ID4gPj4+PiAyLjE4LjANCj4gPiA+Pj4+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fDQo+ID4gPj4+PiBMaW51eC1tZWRpYXRlayBtYWlsaW5n IGxpc3QNCj4gPiA+Pj4+IExpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gPiA+ Pj4+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbWVk aWF0ZWsNCj4gPiA+Pg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B62C4743C for ; Wed, 23 Jun 2021 09:13:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E5F760698 for ; Wed, 23 Jun 2021 09:13:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E5F760698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zPMD8MYTsgSAufaI0f+QSxVA49qu1n1I+r951SwGD0M=; b=uQGzXfUD8vMQ9U BiAqQnok+jaWP30cyYlNxHLw8MWTmO488BEzucQPx8qvQtpPMUUxQYYrbeyJqgL6WduElmQ8KtjAY XECfq4aQC5sbkE3dokQfwO+MY4As5qbyFBb86kgihr7d4Vv2GCDndBToopjY5Gc8OKZv2WDhtFytG yNYt/xQBXtXFIfQfoTDhc5YPxt17enpfUgIETqu6+Ol5fiyQ9Nb4LYuU5oWTmJ30HOCEKhsfnST3I xuwRmoUQ7TSejYuIZts3PhWszIEVTMSSy2hxECM9U3V1dnzCgUwwv5TLdpZhb7PdmMIUV/CU94Mfq MJqS1Rzj2yQlWU74OA/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvywS-00A3K7-Ne; Wed, 23 Jun 2021 09:13:04 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvywO-00A3It-88; Wed, 23 Jun 2021 09:13:03 +0000 X-UUID: dcd4016213ef4570abd5bec7112b91d3-20210623 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=WHVs4dh6AbAKAbeIIKWBxdhvq+wckIntxxe4eFfwL3A=; b=gZMamKoetcWP3ttbQXdOp/wfPXqx/YKRVd5BPGlaE6AvZnbVcP01sgyKX9kWl7YOtN1nwYvKaDxrnEiknpXU19V0plkvv58G+rc7peFJyMUoNamQ4PIqtgbGL73P0aOV6vv+pNfZDxQ1TslBxrqooxHsFYo+GrbwSISXdsowYT4=; X-UUID: dcd4016213ef4570abd5bec7112b91d3-20210623 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1523586282; Wed, 23 Jun 2021 02:12:54 -0700 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Jun 2021 02:02:52 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Jun 2021 17:02:49 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 23 Jun 2021 17:02:48 +0800 Message-ID: <1624438968.2701.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 From: Jianjun Wang To: Lorenzo Pieralisi CC: Matthias Brugger , Chen-Yu Tsai , Ryder Lee , Bjorn Helgaas , Rob Herring , , , , , , Randy Wu , Date: Wed, 23 Jun 2021 17:02:48 +0800 In-Reply-To: <20210622110517.GB24565@lpieralisi> References: <20210601024408.24485-1-jianjun.wang@mediatek.com> <20210601024408.24485-2-jianjun.wang@mediatek.com> <1622526594.9054.6.camel@mhfsdcap03> <20210622110517.GB24565@lpieralisi> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 4D63936515B4AAF2E78DF35DD5D25263CB69BF69C06A8201811E5A3736340AA42000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_021300_643151_FD25915D X-CRM114-Status: GOOD ( 43.17 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2021-06-22 at 12:05 +0100, Lorenzo Pieralisi wrote: > On Wed, Jun 02, 2021 at 01:33:07PM +0200, Matthias Brugger wrote: > > > > > > On 01/06/2021 08:07, Chen-Yu Tsai wrote: > > > Hi, > > > > > > On Tue, Jun 1, 2021 at 1:50 PM Jianjun Wang wrote: > > >> > > >> On Tue, 2021-06-01 at 11:53 +0800, Chen-Yu Tsai wrote: > > >>> Hi, > > >>> > > >>> On Tue, Jun 1, 2021 at 10:50 AM Jianjun Wang wrote: > > >>>> > > >>>> MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192. > > >>> > > >>> Based on what I'm seeing internally, there seems to be some inconsistency > > >>> across the MediaTek platform on whether new compatible strings should be > > >>> introduced for "fully compatible" IP blocks. > > >>> > > >>> If this hardware block in MT8195 is "the same" as the one in MT8192, do we > > >>> really need the new compatible string? Are there any concerns? > > >> > > >> Hi Chen-Yu, > > >> > > >> It's ok to reuse the compatible string with MT8192, but I think this > > >> will be easier to find which platforms this driver is compatible with, > > >> especially when we have more and more platforms in the future. > > > > > > If it's just for informational purposes, then having the MT8192 compatible > > > as a fallback would work, and we wouldn't need to make changes to the driver. > > > This works better especially if we have to support multiple operating systems > > > that use device tree. > > > > > > So we would want > > > > > > "mediatek,mt8195-pcie", "mediatek,mt8192-pcie" > > > > > > and > > > > > > "mediatek,mt8192-pcie" > > > > > > be the valid options. > > > > > > Personally I'm not seeing enough value to justify adding the compatible string > > > just for informational purposes though. One could easily discern which hardware > > > is used by looking at the device tree. > > > > > > > I agree, if no differences between the two chips are known, adding a > > binding withe new compatible and a fallback is a good thing. If we > > later on realize that mt8195 PCI block has differences, we can add the > > matching to the driver. > > So this series can be dropped, right ? Yes, we will send dt-bindings with dts changes in another series, thanks. > > Thanks, > Lorenzo > > > Regards, > > Matthias > > > > > > > > Regards > > > ChenYu > > > > > > > > >> Thanks. > > >>> > > >>> > > >>> Thanks > > >>> ChenYu > > >>> > > >>> > > >>>> Signed-off-by: Jianjun Wang > > >>>> --- > > >>>> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++- > > >>>> 1 file changed, 3 insertions(+), 1 deletion(-) > > >>>> > > >>>> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > >>>> index e7b1f9892da4..d5e4a3e63d97 100644 > > >>>> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > >>>> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > >>>> @@ -48,7 +48,9 @@ allOf: > > >>>> > > >>>> properties: > > >>>> compatible: > > >>>> - const: mediatek,mt8192-pcie > > >>>> + oneOf: > > >>>> + - const: mediatek,mt8192-pcie > > >>>> + - const: mediatek,mt8195-pcie > > >>>> > > >>>> reg: > > >>>> maxItems: 1 > > >>>> -- > > >>>> 2.18.0 > > >>>> _______________________________________________ > > >>>> Linux-mediatek mailing list > > >>>> Linux-mediatek@lists.infradead.org > > >>>> http://lists.infradead.org/mailman/listinfo/linux-mediatek > > >> _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13803C48BC2 for ; Wed, 23 Jun 2021 09:15:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D61C5600CC for ; Wed, 23 Jun 2021 09:15:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D61C5600CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UuZXNwdu47D9fS1vIBUsMvpIT6NNTiMPOOV8yQcSPXo=; b=RnMUP/jQN6jYz6 WyJAisrnUy3XQ3d1xqEAHMtGX/qFDr6vIU4IMWFf56Q5AULl+gve7hG4tT1J09v///H54bkipQ8XY grA3ZCm8QCd25rom+kFD1+Spc/o0/A9KUx7Sj1ZWiURnyTwHV7T+d+OO0k0t88P25ZxAywnN7heLG DPvO1+sDKlpxOzwe0o448MRocKcaYyZ+qYEaaoN94b7M8XrS9TNrC+OkoeIqon7rDke4NrTEb9ula 69M1dO6p28AhwcBpkJC2Jy1HfI487s2rPjLDWZiqQoXCZOqK7RfH7hM29u7Xx6+uD88aIdd8Oal7V UlNBEKeWQZc6Tkzm3bxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvywU-00A3KD-Eu; Wed, 23 Jun 2021 09:13:06 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvywO-00A3It-88; Wed, 23 Jun 2021 09:13:03 +0000 X-UUID: dcd4016213ef4570abd5bec7112b91d3-20210623 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=WHVs4dh6AbAKAbeIIKWBxdhvq+wckIntxxe4eFfwL3A=; b=gZMamKoetcWP3ttbQXdOp/wfPXqx/YKRVd5BPGlaE6AvZnbVcP01sgyKX9kWl7YOtN1nwYvKaDxrnEiknpXU19V0plkvv58G+rc7peFJyMUoNamQ4PIqtgbGL73P0aOV6vv+pNfZDxQ1TslBxrqooxHsFYo+GrbwSISXdsowYT4=; X-UUID: dcd4016213ef4570abd5bec7112b91d3-20210623 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1523586282; Wed, 23 Jun 2021 02:12:54 -0700 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Jun 2021 02:02:52 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Jun 2021 17:02:49 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 23 Jun 2021 17:02:48 +0800 Message-ID: <1624438968.2701.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 From: Jianjun Wang To: Lorenzo Pieralisi CC: Matthias Brugger , Chen-Yu Tsai , Ryder Lee , Bjorn Helgaas , Rob Herring , , , , , , Randy Wu , Date: Wed, 23 Jun 2021 17:02:48 +0800 In-Reply-To: <20210622110517.GB24565@lpieralisi> References: <20210601024408.24485-1-jianjun.wang@mediatek.com> <20210601024408.24485-2-jianjun.wang@mediatek.com> <1622526594.9054.6.camel@mhfsdcap03> <20210622110517.GB24565@lpieralisi> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 4D63936515B4AAF2E78DF35DD5D25263CB69BF69C06A8201811E5A3736340AA42000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_021300_643151_FD25915D X-CRM114-Status: GOOD ( 43.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-06-22 at 12:05 +0100, Lorenzo Pieralisi wrote: > On Wed, Jun 02, 2021 at 01:33:07PM +0200, Matthias Brugger wrote: > > > > > > On 01/06/2021 08:07, Chen-Yu Tsai wrote: > > > Hi, > > > > > > On Tue, Jun 1, 2021 at 1:50 PM Jianjun Wang wrote: > > >> > > >> On Tue, 2021-06-01 at 11:53 +0800, Chen-Yu Tsai wrote: > > >>> Hi, > > >>> > > >>> On Tue, Jun 1, 2021 at 10:50 AM Jianjun Wang wrote: > > >>>> > > >>>> MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192. > > >>> > > >>> Based on what I'm seeing internally, there seems to be some inconsistency > > >>> across the MediaTek platform on whether new compatible strings should be > > >>> introduced for "fully compatible" IP blocks. > > >>> > > >>> If this hardware block in MT8195 is "the same" as the one in MT8192, do we > > >>> really need the new compatible string? Are there any concerns? > > >> > > >> Hi Chen-Yu, > > >> > > >> It's ok to reuse the compatible string with MT8192, but I think this > > >> will be easier to find which platforms this driver is compatible with, > > >> especially when we have more and more platforms in the future. > > > > > > If it's just for informational purposes, then having the MT8192 compatible > > > as a fallback would work, and we wouldn't need to make changes to the driver. > > > This works better especially if we have to support multiple operating systems > > > that use device tree. > > > > > > So we would want > > > > > > "mediatek,mt8195-pcie", "mediatek,mt8192-pcie" > > > > > > and > > > > > > "mediatek,mt8192-pcie" > > > > > > be the valid options. > > > > > > Personally I'm not seeing enough value to justify adding the compatible string > > > just for informational purposes though. One could easily discern which hardware > > > is used by looking at the device tree. > > > > > > > I agree, if no differences between the two chips are known, adding a > > binding withe new compatible and a fallback is a good thing. If we > > later on realize that mt8195 PCI block has differences, we can add the > > matching to the driver. > > So this series can be dropped, right ? Yes, we will send dt-bindings with dts changes in another series, thanks. > > Thanks, > Lorenzo > > > Regards, > > Matthias > > > > > > > > Regards > > > ChenYu > > > > > > > > >> Thanks. > > >>> > > >>> > > >>> Thanks > > >>> ChenYu > > >>> > > >>> > > >>>> Signed-off-by: Jianjun Wang > > >>>> --- > > >>>> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++- > > >>>> 1 file changed, 3 insertions(+), 1 deletion(-) > > >>>> > > >>>> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > >>>> index e7b1f9892da4..d5e4a3e63d97 100644 > > >>>> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > >>>> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > >>>> @@ -48,7 +48,9 @@ allOf: > > >>>> > > >>>> properties: > > >>>> compatible: > > >>>> - const: mediatek,mt8192-pcie > > >>>> + oneOf: > > >>>> + - const: mediatek,mt8192-pcie > > >>>> + - const: mediatek,mt8195-pcie > > >>>> > > >>>> reg: > > >>>> maxItems: 1 > > >>>> -- > > >>>> 2.18.0 > > >>>> _______________________________________________ > > >>>> Linux-mediatek mailing list > > >>>> Linux-mediatek@lists.infradead.org > > >>>> http://lists.infradead.org/mailman/listinfo/linux-mediatek > > >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel