From: Manish Narani <manish.narani@xilinx.com>
To: <peter.chen@kernel.org>, <gregkh@linuxfoundation.org>,
<michal.simek@xilinx.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<git@xilinx.com>, Piyush Mehta <piyush.mehta@xilinx.com>,
Manish Narani <manish.narani@xilinx.com>
Subject: [PATCH 5/6] usb: chipidea: core: Add return value function check
Date: Tue, 24 Aug 2021 22:46:17 +0530 [thread overview]
Message-ID: <1629825378-8089-6-git-send-email-manish.narani@xilinx.com> (raw)
In-Reply-To: <1629825378-8089-1-git-send-email-manish.narani@xilinx.com>
From: Piyush Mehta <piyush.mehta@xilinx.com>
Add return value validation for function phy exit and phy power off.
Addresses-Coverity: "USELESS_CALL"
Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
---
drivers/usb/chipidea/core.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 676346f..37f619e 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -324,7 +324,8 @@ static int _ci_usb_phy_init(struct ci_hdrc *ci)
ret = phy_power_on(ci->phy);
if (ret) {
- phy_exit(ci->phy);
+ if (phy_exit(ci->phy) < 0)
+ dev_dbg(ci->dev, "phy exit failed\r\n");
return ret;
}
} else {
@@ -341,12 +342,20 @@ static int _ci_usb_phy_init(struct ci_hdrc *ci)
*/
static void ci_usb_phy_exit(struct ci_hdrc *ci)
{
+ int ret;
+
if (ci->platdata->flags & CI_HDRC_OVERRIDE_PHY_CONTROL)
return;
if (ci->phy) {
- phy_power_off(ci->phy);
- phy_exit(ci->phy);
+ ret = phy_power_off(ci->phy);
+ if (ret < 0)
+ dev_dbg(ci->dev, "phy poweroff failed\r\n");
+
+ ret = phy_exit(ci->phy);
+ if (ret < 0)
+ dev_dbg(ci->dev, "phy exit failed\r\n");
+
} else {
usb_phy_shutdown(ci->usb_phy);
}
--
2.1.1
next prev parent reply other threads:[~2021-08-24 17:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 17:16 [PATCH 0/6] Chipidea USB driver Enhancements and Bug Fixes Manish Narani
2021-08-24 17:16 ` [PATCH 1/6] usb: chipidea: Add support for VBUS control with PHY Manish Narani
2021-10-07 4:44 ` Peter Chen
2021-10-08 4:59 ` Jun Li
2021-08-24 17:16 ` [PATCH 2/6] usb: chipidea: Use usb2 phy for Zynq platform Manish Narani
2021-10-07 4:52 ` Peter Chen
2021-08-24 17:16 ` [PATCH 3/6] usb: chipidea: Check usb_phy exists before using it Manish Narani
2021-10-07 4:54 ` Peter Chen
2021-08-24 17:16 ` [PATCH 4/6] usb: chipidea: Fix return value handling Manish Narani
2021-08-24 17:16 ` Manish Narani [this message]
2021-10-07 5:00 ` [PATCH 5/6] usb: chipidea: core: Add return value function check Peter Chen
2021-08-24 17:16 ` [PATCH 6/6] usb: chipidea: udc: Add xilinx revision support Manish Narani
2021-10-07 5:02 ` Peter Chen
2021-10-07 5:03 ` Peter Chen
2021-10-07 5:12 ` [PATCH 0/6] Chipidea USB driver Enhancements and Bug Fixes Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629825378-8089-6-git-send-email-manish.narani@xilinx.com \
--to=manish.narani@xilinx.com \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=peter.chen@kernel.org \
--cc=piyush.mehta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.